Received-SPF: pass (google.com: domain of linux-kernel+bounces-130006-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240318151631.1621881-1-d-gole@ti.com>
In-Reply-To: <20240318151631.1621881-1-d-gole@ti.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 3 Apr 2024 16:53:54 +0200
Message-ID: <CAJZ5v0iOEkmE741_hAmprYYxmi5p9WZPrxOu59Y3FqzLM9oJwg@mail.gmail.com>
Subject: Re: [PATCH V2 0/2] PM: wakeup: make device_wakeup_disable return void
To: Dhruva Gole <d-gole@ti.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>, Tony Lindgren <tony@atomide.com>, Len Brown <len.brown@intel.com>, 
	Pavel Machek <pavel@ucw.cz>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	Viresh Kumar <viresh.kumar@linaro.org>, theo.lebrun@bootlin.com, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 18, 2024 at 4:17=E2=80=AFPM Dhruva Gole <d-gole@ti.com> wrote:
>
> This is a follow up patch based on discussions with Rafael[0] on a previo=
us
> patch I sent to propagate return value from device_wakeup_disable
> further upward inside device_init_wakeup
>
> However, it doesn't seem like today any return values from
> device_wakeup_disable are very useful to the caller.
>
> I could only spot one caller of this function that was actually
> propagating the return value upward other than the PM core calls. I have
> tried to update sdhci-pci-core to work with the new changes
>
> [0] https://lore.kernel.org/all/CAJZ5v0jbHwiZemtNAoM-jmgB_58VqmKUkqv4P7qr=
PkxWzBzMyQ@mail.gmail.com/
>
> Changelog:
>
> v1 --> v2:
> * Squashed the mmc fix into first patch [Rafael]
>
> Dhruva Gole (2):
>   PM: wakeup: make device_wakeup_disable return void
>   PM: wakeup: Remove unnecessary else from device_init_wakeup
>
>  drivers/base/power/wakeup.c       | 11 +++++++----
>  drivers/mmc/host/sdhci-pci-core.c |  2 +-
>  include/linux/pm_wakeup.h         | 12 +++++-------
>  3 files changed, 13 insertions(+), 12 deletions(-)
>
> --

Both patches applied as 6.10 material, thanks!