Received-SPF: pass (google.com: domain of linux-kernel+bounces-130085-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9a07a658-dbd4-47e5-bc36-598a456fceca@intel.com>
Date: Wed, 3 Apr 2024 08:23:20 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dmaengine: idxd: Check for driver name match before sva
 user feature
Content-Language: en-US
To: Jerry Snitselaar <jsnitsel@redhat.com>, Fenghua Yu <fenghua.yu@intel.com>
Cc: Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240403050710.2874197-1-jsnitsel@redhat.com>
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240403050710.2874197-1-jsnitsel@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/2/24 10:07 PM, Jerry Snitselaar wrote:
> Currenty if the user driver is probed on a workqueue configured for
> another driver with SVA not enabled on the system, it will print
> out a number of probe failing messages like the following:
> 
>     [   264.831140] user: probe of wq13.0 failed with error -95
> 
> On some systems, such as GNR, the number of messages can
> reach over 100.
> 
> Move the SVA feature check to be after the driver name match
> check.
> 
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>

Seems reasonable. Thanks!

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>  drivers/dma/idxd/cdev.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index 8078ab9acfbc..a4b771781afc 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -517,6 +517,14 @@ static int idxd_user_drv_probe(struct idxd_dev *idxd_dev)
>  	if (idxd->state != IDXD_DEV_ENABLED)
>  		return -ENXIO;
>  
> +	mutex_lock(&wq->wq_lock);
> +
> +	if (!idxd_wq_driver_name_match(wq, dev)) {
> +		idxd->cmd_status = IDXD_SCMD_WQ_NO_DRV_NAME;
> +		rc = -ENODEV;
> +		goto wq_err;
> +	}
> +
>  	/*
>  	 * User type WQ is enabled only when SVA is enabled for two reasons:
>  	 *   - If no IOMMU or IOMMU Passthrough without SVA, userspace
> @@ -532,14 +540,7 @@ static int idxd_user_drv_probe(struct idxd_dev *idxd_dev)
>  		dev_dbg(&idxd->pdev->dev,
>  			"User type WQ cannot be enabled without SVA.\n");
>  
> -		return -EOPNOTSUPP;
> -	}
> -
> -	mutex_lock(&wq->wq_lock);
> -
> -	if (!idxd_wq_driver_name_match(wq, dev)) {
> -		idxd->cmd_status = IDXD_SCMD_WQ_NO_DRV_NAME;
> -		rc = -ENODEV;
> +		rc = -EOPNOTSUPP;
>  		goto wq_err;
>  	}
>