Received-SPF: pass (google.com: domain of linux-kernel+bounces-130110-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240403143852.13175-1-apais@linux.microsoft.com> <2024040314-unbuckled-botanist-1afc@gregkh>
In-Reply-To: <2024040314-unbuckled-botanist-1afc@gregkh>
From: Allen <allen.lkml@gmail.com>
Date: Wed, 3 Apr 2024 08:40:23 -0700
Message-ID: <CAOMdWS+Z1ZS2VPBXiYbtOyYBuCCx1i8M1aVMYHGhMRTv259xaA@mail.gmail.com>
Subject: Re: [PATCH v2] USB: Convert from tasklet to BH workqueue
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Allen Pais <apais@linux.microsoft.com>, linux-kernel@vger.kernel.org, tj@kernel.org, 
	keescook@chromium.org, duncan.sands@free.fr, stern@rowland.harvard.edu, 
	mathias.nyman@intel.com, oneukum@suse.com, linux-usb@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 3, 2024 at 8:02=E2=80=AFAM Greg KH <gregkh@linuxfoundation.org>=
 wrote:
>
> On Wed, Apr 03, 2024 at 02:38:52PM +0000, Allen Pais wrote:
> > The only generic interface to execute asynchronously in the BH context =
is
> > tasklet; however, it's marked deprecated and has some design flaws. To
> > replace tasklets, BH workqueue support was recently added. A BH workque=
ue
> > behaves similarly to regular workqueues except that the queued work ite=
ms
> > are executed in the BH context.
> >
> > This patch converts drivers/usb/* from tasklet to BH workqueue.
> >
> > Based on the work done by Tejun Heo <tj@kernel.org>
> > Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6=
10
> >
> > Changes in v2:
> >  - Update code comments and commit message.
> >       Suggested by Greg K h
> >  - Retain local variable name(hcd.c).
> >       Suggested by Alan Stern
> >
> > Link to v1:https://lore.kernel.org/all/20240327160314.9982-1
> > -apais@linux.microsoft.com/T/#m2ec7868fbf102f1551ebe4c92d200848b94af3b1
>
> Why the line-wrap?
>
> And v2 info should all go below the --- line, right?
>
> v3 perhaps?

 I missed that bit. I will send out a v3.

Thank you.