Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2796025lqz; Wed, 3 Apr 2024 08:51:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWDSpq+oelfu/Y5zBkcF/IqKuZbhWz/LsL1/8mAo58PodE0yaKOHrBMlB2jG+lzeP9kylP/rYKGgdHfuEbNeZncjPfXAG1y0+3hZAZ7KQ== X-Google-Smtp-Source: AGHT+IG2AjkRUNON0+P8hSzMUbARTU7Io2quOC2jae/tRXCrfwbqR+2678ozaKYPc95TDfnJZSE4 X-Received: by 2002:a17:906:3e53:b0:a4e:512a:903c with SMTP id t19-20020a1709063e5300b00a4e512a903cmr2801989eji.32.1712159464043; Wed, 03 Apr 2024 08:51:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712159464; cv=pass; d=google.com; s=arc-20160816; b=mTVY3PqQM92ZiyMPrKN3way84e8hBO28cVIEvwfc1gWS61EetanYgabITkHC3u+adv i5IlZ0bEU67kSqqcdY4Grma+Uh324fdPgEN45N1UsKJlvodu/4yDCTY9m/NYNwyyp5kU gQ3vSCI3YpvEj101fesOj4aCCXnhoOSel2OmGdBNg+tEfVDrjT3oHbUx54CnwdS/5nEL mOyQeO8B3fCqSqOAA/V2B+v03VcOcWW65cCqlcV5Ib0w4GdF10S5aREOVmZgOArLb58R R/S3rXhMsSFqWvtPkRSvIc5kR61rGB9yggdoDxx+hkkCyqJlYFyzzg/eiwHAoS7t2C/u X59w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=njh7zDbuWKEYmVbLhxPSXHhGkYDFXgG4Dth71aiTbpk=; fh=FmC2hJpJhN2HT2Kov+KiTeKhNOezP0K1ntHb8ZYpOKY=; b=ZDMm78T7HK7jfsGE3A964F05+2g4lfgSqdGdSjAarBbWM8WPUxeS53NWQV6TMkKLB2 BbXjTELNk8HF+/tgJZXF8TfU7iD37aHvpo44Blyj0ofkoA3kEvlfbNpsmmVqF2RzItDv 2wR1pTxRwQ8yTeR3cpWemIhyV9sw1Ox4Bpzds49BVHBdK7XC2nxY3s47o4PF2+/+HVPc ip0frhedqwmYSovmbFsBmMNrRs/rfwFRi0ttZS69r9WbMRMuAxBF8qd1XVG5zHwtwm5N K4Cgg4QgGs5Zewl/6Yixi+so0QZ8tVOfPerzOs7xDOWCko7IT2yPYCONQy8R+9p+ygJE W01w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-130132-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130132-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id s7-20020a170906284700b00a474486d6ffsi6897914ejc.936.2024.04.03.08.51.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 08:51:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-130132-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-130132-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130132-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C19DB1F28651 for ; Wed, 3 Apr 2024 15:51:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 172C914D453; Wed, 3 Apr 2024 15:49:38 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3286714D426; Wed, 3 Apr 2024 15:49:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712159377; cv=none; b=F74yhoar9FdkTSCXwhM3CVoWy2EJz2rN3RlmISXJfASV1dcxy5DWKxDRIYZUlEoPt7Sq70RQCk3e0kVZ8S5umDWnId/fhiJHvgcRQi27Tvx91aVYACJDSUVonYKbDzLbigAurIXJXBWazkr+7kqyO80/J1cLtWMslLtQL/3N/qE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712159377; c=relaxed/simple; bh=tsqqYBX34+zq0nQoQwApKnQcjJcj3i0phv23JxR4wVA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kaXO70fhTzjnGM0MX02xpkh2RRGYXtJXyJDWmvlzKiC/07SS4Bjepr6AQs1dH1qEyH3v3GIA9D2dyfa03VUrXczUuouNQW88hkeo629y/lgM7sCD5n7omMZ86MiOzJOsi4x/uG4y2okLQlhE93yGukUb1YgqcDIMLWF2/8dgaEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E158D1595; Wed, 3 Apr 2024 08:50:06 -0700 (PDT) Received: from e129166.arm.com (unknown [10.57.72.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 65B5D3F7B4; Wed, 3 Apr 2024 08:49:33 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org Subject: [PATCH v5 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage Date: Wed, 3 Apr 2024 16:49:07 +0100 Message-Id: <20240403154907.1420245-5-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240403154907.1420245-1-lukasz.luba@arm.com> References: <20240403154907.1420245-1-lukasz.luba@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the voltage for OPPs is adjusted there is a need to also update Energy Model framework. The EM data contains power values which depend on voltage values. The EM structure is used for thermal (IPA governor) and in scheduler task placement (EAS) so it should reflect the real HW model as best as possible to operate properly. Based on data on Exynos5422 ASV tables the maximum power difference might be ~29%. An Odroid-XU4 (with a random sample SoC in this chip lottery) showed power difference for some OPPs ~20%. Therefore, it's worth to update the EM. Reviewed-by: Krzysztof Kozlowski Reviewed-by: Dietmar Eggemann Signed-off-by: Lukasz Luba --- drivers/soc/samsung/exynos-asv.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c index d60af8acc3916..97006cc3b9461 100644 --- a/drivers/soc/samsung/exynos-asv.c +++ b/drivers/soc/samsung/exynos-asv.c @@ -11,6 +11,7 @@ #include #include +#include #include #include #include @@ -97,9 +98,16 @@ static int exynos_asv_update_opps(struct exynos_asv *asv) last_opp_table = opp_table; ret = exynos_asv_update_cpu_opps(asv, cpu); - if (ret < 0) + if (!ret) { + /* + * Update EM power values since OPP + * voltage values may have changed. + */ + em_dev_update_chip_binning(cpu); + } else { dev_err(asv->dev, "Couldn't udate OPPs for cpu%d\n", cpuid); + } } dev_pm_opp_put_opp_table(opp_table); -- 2.25.1