Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2822748lqz; Wed, 3 Apr 2024 09:30:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU700jdBgx092waOTjI/icJu2gPs5UZtjckHlvkuf6IpkM9C+PmFMc6Ux7AdnuWqUSnjZekAGQ3HfE/rhl0sXGAMbigprdMzAfTsNxc/Q== X-Google-Smtp-Source: AGHT+IGJ9NMwZerhMZQJt9TVCt2eVlcZoSOQiF1g0SEj3deTvCysPeJ6I4HY+2ou+Y/t7cmgleIp X-Received: by 2002:a05:6102:2229:b0:478:40d6:619c with SMTP id d9-20020a056102222900b0047840d6619cmr14992752vsb.24.1712161814203; Wed, 03 Apr 2024 09:30:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712161814; cv=pass; d=google.com; s=arc-20160816; b=uV+Yk6Sw1Q0VrPwvneuAaE7cs2fotejjrzaWpIPpa5EPyjGoCgxo/h1UHbBQT4DMMM 22mDEfGR0G8kW66fCS1D8W640d8fxjTPbo1UBZQWC692SsePH5z4DOox4qJntOYZIH5O uA8TJ/G6zG7k2VCdtsCo5gMhLwgTCI9JAN+2MfRBk/JPBvglGRVnjc99o8Bj99XKU8s/ 80hSAZ+eGLwfa0JadjhhsGbft3/A73r6Z9Yl2PdM7it9V1X2qi99A92sDFukUMp+2Pal gbi1sB+09sxiy9eT355n+xTHt4UcAM5iIwUzBppLVbV7scaRJ2D0sa/Lpgk/8p4d4WHF 0xvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=euAFO8Clw3pP5qIbVAUGnUfJ30fBuMGE4BnruenTn1M=; fh=0LShupjtLV4l8ZvGpgdlF+xPwapjuIdx6rBOhqeXbq4=; b=KA6B64R4g5PT0MuwjFkrrR84QiVLNvXETIYmURh0UAWQR+or7Mnf02aA24uZJyMz+F Z3iR4reBnL2yXvPfAQ92wC/XUWNdJjgvVvBDwy5JvI72I7RQX9kwGroprjl1xdD3b6MN EZ3drHA0n3DoJNa9qeX8ibXwsk9xgAv65SreMSwrlYtkhF4x9L8NUkdzg5HO24KLTB8m LnmAyHtyAhfflEA/hlfBJNgSjFXwbqejeq6aOykgWp3iUHCIRGkd12azPyK+KxcBKRen 3RD+BmYiEPp8ojw4WWybmOelCrDKP8V+X1zTksMbKTjI7pNfDJE51eigtoe4+9pD5Wy3 j9zQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="OuX/YlS6"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-130196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id dh27-20020a056102579b00b0047832912459si2177922vsb.3.2024.04.03.09.30.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 09:30:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-130196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="OuX/YlS6"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-130196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E72A11C25C0C for ; Wed, 3 Apr 2024 16:30:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5F0AB1487F8; Wed, 3 Apr 2024 16:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OuX/YlS6" Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21921B978 for ; Wed, 3 Apr 2024 16:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712161805; cv=none; b=PzkcUGaMkaizlsjYiw2ySmbnyH29iXbsa62LeBa1giTfKfB2RNhBgoE6OdrC9MLcO7PJ7T02OU2lRfHDXqTXzlP8e1lHVhvrdzVJTfkb8lmo4ZxyfABSleVWlJt2b6sYW1KjhgaplOHyXGc7d2y4/UeUe7s0ivlbxtjVMCans70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712161805; c=relaxed/simple; bh=euAFO8Clw3pP5qIbVAUGnUfJ30fBuMGE4BnruenTn1M=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=PW3f6Hcnqc218evMu3oBd9XUh9HcHAKTjJLc0jS1ZJ1AkjrtW/p9n3Rry8EvcJ0inKXBCr+bbemB+bvUtDO3rB86HIp2HgcGf3TwduK1U3j6ff7kV5a+pXzGdle2b3mVfBp02jyumMIDcVW8x0L4b6RnOfITZsvpMlOePRp7vZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OuX/YlS6; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-56dec96530bso47a12.0 for ; Wed, 03 Apr 2024 09:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712161802; x=1712766602; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=euAFO8Clw3pP5qIbVAUGnUfJ30fBuMGE4BnruenTn1M=; b=OuX/YlS6hFRVamHfsUEQxVkL8OipuVmE8x2/toE+hvMPLuWAjoeKOnLP7x/V4SdR2j /mThhrmUkLcy7ARb/cikquMaskrv3fk4Dy+JUtK0R6WvAtRK3EOqPI/Mo13DtaScrgrW rHjQxAUBvawDCcr/tylL0xGkFtn2+y8Y9Njnhdbo4VbdtpSabUjWRfxGUEBxqV4FA6T2 k8cs8UUdQTlpJAgwqhjhT57MLtWIGU+B9BkXumK1uWCp1y93FK6zHVVnnyYj4ebVWurL gDkjeUfQPvLKMz4XujD6NwTVUZ8PXp/YTr+d5vrkkIpPpRWjF9P5w6rbSW75VHBfj75N hH9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712161802; x=1712766602; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=euAFO8Clw3pP5qIbVAUGnUfJ30fBuMGE4BnruenTn1M=; b=iIhevJTwnpwGDMjnI4aB9tDAPUqjgf2/Ot3d4UTJGCp0HaQvcp1Ixb7RzaSyqrvf5P y03KIwq/qCsJf0iiNr2q/jTkTI88UOam7Ojolvz31yzhor1rmH4h5YS0ROqfMffvfKOl KAoqWzcIyP8iF9V40uA/6GW/mvDotbvVjiibuzF6BNkwTte2du/MjKG9VaKSiV8d5WHq DaD6TldkFsbGUcqsvLCYDd75FokfDmiqD0393FEJ9DdnE4pIn06tKmd+ZD5NdJbv0q/6 x4woSqfNEtg2kgoJTPVXjSc6ASY8RcgCWDpKzL42Oat2p5zyI1++pxf03Y+O1i3vJWsn qg3g== X-Forwarded-Encrypted: i=1; AJvYcCWd/7oGe5/YT4p6FSbDOVMw8f0W8ZXgzZxEKknJjED29hSf4yobCtfxK+LRxEeW8+XOsle1tSy+LsU//Q6YgKK2e0PAOdJZDKqJ4THT X-Gm-Message-State: AOJu0Yy+c1UkNlJABAD+QJPZg6QMxPYNOYIsQL1XcOFkc759HdMfB/Ms oGRg5ILirgyZvu1R8WYSWuO7wcj3wa8zsUALHOrthTF0TTBF9/hx7gshh0HEEx8kcziOFjnoOeJ cFAjMm0NRJ+JrvkgpPWxWR7oLsnUtpZXwXKhn X-Received: by 2002:a05:6402:1289:b0:56d:ecf2:2a14 with SMTP id w9-20020a056402128900b0056decf22a14mr246927edv.0.1712161802179; Wed, 03 Apr 2024 09:30:02 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240403152844.4061814-1-almasrymina@google.com> <20240403152844.4061814-4-almasrymina@google.com> In-Reply-To: <20240403152844.4061814-4-almasrymina@google.com> From: Eric Dumazet Date: Wed, 3 Apr 2024 18:29:51 +0200 Message-ID: Subject: Re: [PATCH net-next v4 3/3] net: remove napi_frag_unref To: Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ayush Sawal , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , David Ahern , Boris Pismenny , John Fastabend , Tariq Toukan , Dragos Tatulea , Simon Horman , Sabrina Dubroca , =?UTF-8?Q?Ahelenia_Ziemia=C5=84ska?= , Pavan Chebbi , Christophe JAILLET , Yunsheng Lin , Florian Westphal , David Howells , Alexander Lobakin , Lorenzo Bianconi , Johannes Berg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 3, 2024 at 5:28=E2=80=AFPM Mina Almasry wrote: > > With the changes in the last patches, napi_frag_unref() is now > reduandant. Remove it and use skb_page_unref directly. > > Signed-off-by: Mina Almasry > Reviewed-by: Dragos Tatulea > Reviewed-by: Eric Dumazet