Received-SPF: pass (google.com: domain of linux-kernel+bounces-130003-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 3 Apr 2024 07:50:49 -0700
From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Daniel Sneddon <daniel.sneddon@linux.intel.com>,
	antonio.gomez.iglesias@linux.intel.com,
	alyssa.milburn@linux.intel.com, andrew.cooper3@citrix.com,
	linux-kernel@vger.kernel.org,
	Alyssa Milburn <alyssa.milburn@intel.com>, stable@kernel.org
Subject: Re: [PATCH v3] x86/bugs: Default retbleed to =stuff when retpoline
 is enabled
Message-ID: <20240403145049.ab7v436ntlw7xtty@desk>
References: <20240402-retbleed-auto-stuff-v3-1-e65f275a8ec8@linux.intel.com>
 <6ffcc9bd-039a-4ab4-a84d-eeedbc6fa1cc@suse.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6ffcc9bd-039a-4ab4-a84d-eeedbc6fa1cc@suse.com>

On Wed, Apr 03, 2024 at 05:32:40PM +0300, Nikolay Borisov wrote:
> 
> 
> On 3.04.24 г. 8:54 ч., Pawan Gupta wrote:
> > On Intel systems when retpoline mitigation is enabled for spectre-v2,
> > retbleed=auto does not enable RSB stuffing. This may make the system
> > vulnerable to retbleed. Retpoline is not the default mitigation when
> > IBRS is present, but in virtualized cases a VMM can hide IBRS from
> > guests, resulting in guest deploying retpoline by default. Even if IBRS
> > is enumerated, a user can still select spectre_v2=retpoline.
> > 
> > As with other mitigations, mitigate retbleed by default. On Intel
> > systems when retpoline is enabled, and retbleed mitigation is set to
> > auto, enable Call Depth Tracking and RSB stuffing i.e. retbleed=stuff
> > mitigation. For AMD/Hygon auto mode already selects the appropriate
> > mitigation.
> > 
> > Reported-by: Alyssa Milburn <alyssa.milburn@intel.com>
> > Cc: stable@kernel.org
> > Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
> 
> Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>

Thanks.