Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2883075lqz; Wed, 3 Apr 2024 11:11:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWNUnVWrb04zNdrCLBiFxluQDfeSwm/1cKYTIo0kunturIc7b065Gd0DbJs1dpqvOMZtP4Ju1M/Bhir1PAexafdeXvurohIIqZ74dK8nA== X-Google-Smtp-Source: AGHT+IFMXRp1BK18GyFpermh+Mfu/KluNclTQjkzLGu843dPRWWuGDWMKAP2CVRTHSa6MfkCOQAU X-Received: by 2002:a17:90a:d515:b0:2a2:a9af:9197 with SMTP id t21-20020a17090ad51500b002a2a9af9197mr278019pju.3.1712167908855; Wed, 03 Apr 2024 11:11:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712167908; cv=pass; d=google.com; s=arc-20160816; b=hRYpXsWCS5sbDKKzHvlvef+4JL0o8J9c12i8Zi+19ZKp8D4JCPZW+1SMItUfh5/v+i xrVNuFuxJpYrasx75hrmVw6/5xrAh3iAi4gQc/l9e2y8vGjqxma7gLu3JpiwtczBhjiJ QksJ8LZs25cNG8xkUg39U3mODimHd31iNBg+8eGonR4I+ngIaj5FBdP+NtTEeCODQhQL wythSl1ve8o1Dik3oKXnHcwdGNwVXJZSkHtNfPxFn2kuyXA1IC6HPzuHfzX0AxHIQBqS J4JxPMcNeuB26PYaUA8TH88OHhWPWV+SjFzxCc5tTso3fImxhRC+QgMtyviyXrWqvqfo L2hQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=Q4229GQboyilO9bju77cSM01laSLD70bFXF2KktzIs4=; fh=MSF9Gpun6xJBWaXToD5Brtt1cByQUpvBoviPSALQ8DU=; b=eM/NARNJ2d0Skp9Hmg1PU7CTV87VqzsDZWVu4ddAUh5v0lxGdipd3igaBx0KgPXf/f tN5T7CDiPQ33MKiKkw1jQE1T/zZcm5vDff3xHHTCcsu+YsJbXBHkVyTLdGC76xo/dWTh h5l3WS6MpgNUybP1bB7mdAc6ywRLChzVZyxGK/z0xVf/Edv+lwiJlP7y7pvELf3VXUeo Xc16Y5jpEbGbvvaN9l/Quorss2pnfPPSvqq8kIeMVwBIexg36Si6AjWVhzBgh2uQsqFy lYsdcZ8ExiriFmkO6mTHD9VdSQE/JlmOUclsgxdbVOFGhRTHa4rNFOjOcIIaJX+CH7yt pBKw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uuW9hdd6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-130423-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id c13-20020a17090aa60d00b002a092f4c4b0si15668909pjq.164.2024.04.03.11.11.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 11:11:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-130423-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uuW9hdd6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-130423-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C17072823D0 for ; Wed, 3 Apr 2024 18:11:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5DA4B153518; Wed, 3 Apr 2024 18:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uuW9hdd6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8357D17C98; Wed, 3 Apr 2024 18:11:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712167879; cv=none; b=YHJRtbiSvu5BYdBuJkavFl2cZB5Cp27gNbWFMTQ+73E+JY8TlcR1lN5QOd9tL9WAsBytPAxvszo11dGyuoChhNi0wjw+4WLOEiv4UOVuh6WF4o4WiDL+ssaOyDNOWK9lWErxcu4a8WK5PWdmVUkkcIgJsr1gwj8IiXiq1R71Afg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712167879; c=relaxed/simple; bh=cW+1HWqnie4/n+kUXN9FoZATD7nr4nMkde58cSOxrkI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=KcniAXPOMVC4Fh+AJqNlWeCmJTdEM5epKqieE2S8ssd/jbxdxSYyI+TwcHAUw+RbuY+CGv6thl8cy+d8fV5d8K5k5ZPXg6h8CJ24AigQ6EEHBwls8GtEdzvYdfBASDAhoOJtdv2+yOTVSjRXEfVCRTEAW0h2VrXX1LzLEoyk6R4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uuW9hdd6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3577C433F1; Wed, 3 Apr 2024 18:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712167879; bh=cW+1HWqnie4/n+kUXN9FoZATD7nr4nMkde58cSOxrkI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=uuW9hdd6u7gpsFeThusi2JMFwN4+vxAt8XFb16nGKo1Nyp69VaGyDfoRackM4inlO DBbu+JCgKCrTS04jzUXkHojCJaPNT4745zjnw/9eufqgpzb3rSQCAXLtixJqqoZy9O Uw8cOCBMggl59tJfeIDd3UIJcvvUBu4biuFsJ/pLV7LOS25ChF16cTFs9RI0L0gRxx xBM0mMMTO5zwJBw5ZfaQMwPyS6xporcdMR6tgKxDPj+D60KIHf33qOuV+WVYQKP0Vh K848vaDgwX6lECAjkc8Yn7RHF0xyF9SkQUoZRCLGHPcQUqorhqZ5/kjvTeZBvnV5gA NuImwKmbCpmCg== Date: Wed, 3 Apr 2024 20:11:16 +0200 (CEST) From: Jiri Kosina To: Max Staudt cc: Roderick Colenbrander , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] HID: playstation: DS4: LED bugfix, third-party gamepad support In-Reply-To: Message-ID: References: <20240207163647.15792-1-max@enpas.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 27 Feb 2024, Jiri Kosina wrote: > > Dear hid-playstation maintainers, > > > > Here is v2 of my patch series, with the discussed changes. > > > > > > Differences since v1: > > - Dropped patch for 7545:0104 (SZ-MYPOWER controllers) > > - Dropped patch for DS4 clones without a MAC address on USB > > - Changed hid_err() to hid_warn() where things are no longer fatal > > - Simplified goto as return in minimal report parsing > > > > > > I've included the patch to simplify the PID/VID mapping to controller > > types, since the previous discussion made it sound useful for future > > support of second-party controllers. Please feel free to drop it if you > > don't think it's relevant now. > > > > > > Thanks for your feedback! > > > > Max > > > > > > Patches in this series: > > [PATCH v2 1/5] HID: playstation: DS4: Fix LED blinking > > [PATCH v2 2/5] HID: playstation: DS4: Don't fail on FW/HW version > > [PATCH v2 3/5] HID: playstation: DS4: Don't fail on calibration data > > [PATCH v2 4/5] HID: playstation: DS4: Parse minimal report 0x01 > > [PATCH v2 5/5] HID: playstation: Simplify device type ID > > Roderick, any word on this series please? Roderick, please speak up now, or I'll queue this as-is for 6.10 in the coming few days. Thanks, -- Jiri Kosina SUSE Labs