Received-SPF: pass (google.com: domain of linux-kernel+bounces-130529-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <2f509949-7e7e-cbf6-c1d0-f25971c2d890@quicinc.com>
Date: Wed, 3 Apr 2024 12:58:50 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3] phy/qcom-qmp-combo: propagate correct return value at
 phy_power_on()
Content-Language: en-US
To: Stephen Boyd <swboyd@chromium.org>,
        Kuogee Hsieh
	<quic_khsieh@quicinc.com>, <abel.vesa@linaro.org>,
        <agross@kernel.org>, <airlied@gmail.com>, <andersson@kernel.org>,
        <daniel@ffwll.ch>, <dianders@chromium.org>,
        <dmitry.baryshkov@linaro.org>, <dri-devel@lists.freedesktop.org>,
        <robdclark@gmail.com>, <sean@poorly.run>, <vkoul@kernel.org>
CC: <quic_jesszhan@quicinc.com>, <quic_sbillaka@quicinc.com>,
        <marijn.suijten@somainline.org>, <freedreno@lists.freedesktop.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1711741835-10044-1-git-send-email-quic_khsieh@quicinc.com>
 <CAE-0n50Z2pDGH+ncjQq-huDsn9jdN=1SfaaU+qw229nZpUVCDw@mail.gmail.com>
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
In-Reply-To: <CAE-0n50Z2pDGH+ncjQq-huDsn9jdN=1SfaaU+qw229nZpUVCDw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 4/3/2024 12:51 PM, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2024-03-29 12:50:35)
>> Currently qmp_combo_dp_power_on() always return 0 in regardless of
>> return value of cfg->configure_dp_phy(). This patch propagate
>> return value of cfg->configure_dp_phy() all the way back to caller.
> 
> Is this found via code inspection or because the phy is failing to power
> on sometimes? I ask because I'm looking at a DP bug on Trogdor with
> chromeos' v6.6 based kernel and wondering if this is related.
> 

No, we actually hit an issue. This issue was originally reported as a 
link training issue while bringing up DP on x1e80100.

While debugging that we noticed that we should not have even proceeded 
to link training because the PLL was not getting locked and it was 
failing silently since there are no other error prints (and hence the 
second part of the patch to improve the error logs), and we do not 
return any error code from this driver, we could not catch the PLL 
unlocked issue.

> Also, is the call to phy_power_on() going to be checked in
> the DP driver?
> 
>   $ git grep -n phy_power_on -- drivers/gpu/drm/msm/dp/
>   drivers/gpu/drm/msm/dp/dp_ctrl.c:1453:  phy_power_on(phy);

Yes, this is a good point. We should also post the patch to add the 
error checking in DP driver to fail if phy_power_on fails.