Received-SPF: pass (google.com: domain of linux-kernel+bounces-130623-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 3 Apr 2024 14:28:36 -0700
From: Kees Cook <keescook@chromium.org>
To: Phillip Lougher <phillip@squashfs.org.uk>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	justinstitt@google.com
Subject: Re: [PATCH] Squashfs: remove deprecated strncpy by not copying the
 string
Message-ID: <202404031428.867B90D87D@keescook>
References: <20240403183352.391308-1-phillip@squashfs.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240403183352.391308-1-phillip@squashfs.org.uk>

On Wed, Apr 03, 2024 at 07:33:52PM +0100, Phillip Lougher wrote:
> Squashfs copied the passed string (name) into a temporary buffer
> to ensure it was NUL-terminated.  This however is completely
> unnecessary as the string is already NUL-terminated.  So remove
> the deprecated strncpy() by completely removing the string copy.
> 
> The background behind this unnecessary string copy is that it
> dates back to the days when Squashfs was an out of kernel patch.
> The code deliberately did not assume the string was NUL-terminated
> in case in future this changed (due to kernel changes).  This
> would mean the out of tree patches would be broken but still
> compile OK.
> 
> Signed-off-by: Phillip Lougher <phillip@squashfs.org.uk>

Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook