Received-SPF: pass (google.com: domain of linux-kernel+bounces-130632-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Cc: ahmed.zaki@intel.com,
	aleksander.lobakin@intel.com,
	alexandre.torgue@foss.st.com,
	andrew@lunn.ch,
	cjubran@nvidia.com,
	corbet@lwn.net,
	davem@davemloft.net,
	dtatulea@nvidia.com,
	edumazet@google.com,
	gal@nvidia.com,
	hkallweit1@gmail.com,
	jacob.e.keller@intel.com,
	jiri@resnulli.us,
	joabreu@synopsys.com,
	justinstitt@google.com,
	kory.maincent@bootlin.com,
	kuba@kernel.org,
	leon@kernel.org,
	liuhangbin@gmail.com,
	maxime.chevallier@bootlin.com,
	pabeni@redhat.com,
	paul.greenwalt@intel.com,
	przemyslaw.kitszel@intel.com,
	rdunlap@infradead.org,
	richardcochran@gmail.com,
	saeed@kernel.org,
	tariqt@nvidia.com,
	vadim.fedorenko@linux.dev,
	vladimir.oltean@nxp.com,
	wojciech.drewek@intel.com,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: [PATCH net-next v2 5/6] netlink: specs: ethtool: add header-flags enumeration
Date: Wed,  3 Apr 2024 14:28:43 -0700
Message-ID: <20240403212931.128541-6-rrameshbabu@nvidia.com>
In-Reply-To: <20240403212931.128541-1-rrameshbabu@nvidia.com>
References: <20240403212931.128541-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?55bsp0A+DZFUp3tNdN/6EWsq/W9VYAbkbYpUo73GjacqgJA36rYf/GKnV0KW?=
 =?us-ascii?Q?0aEiT41fEwx896q5SU/daCgTOScJA4LksT3viRnULNeb9IHtQ8Ml2XtjvEf3?=
 =?us-ascii?Q?xFLUYSY+KHhcGMQHQQZFF9bk7C8Z6BYG4RaTnn+xLx6ZUU8iYzSp0cf4GFzb?=
 =?us-ascii?Q?2PeOHlrnhPIRzGq8g0MdSQukrpL6SIbGStMUZRIRikshtZgekGAibiKTzDUl?=
 =?us-ascii?Q?TjCDi7QX8clRRVp4pK6ZjE2+bwxZ0XrRfdlpBO7wX7z/9h6WxDCVciCRBNZ/?=
 =?us-ascii?Q?+V4zb783WCkgq1+6qz1JFczPxr2DniJLNeq0UVRQwaoCLxU4APCTXMxmZVCk?=
 =?us-ascii?Q?NYYTPqUSsEE9lRSmYZF7z400dwrldoND8yMDr/cAwGa5DpAt3pof5WC5jLoL?=
 =?us-ascii?Q?aH/801MKAx4MQGUoiPgtHjfGKX2DQWS6NDvq8D6bFndwE70YzDUWEdkHVNUv?=
 =?us-ascii?Q?Ir9VhNvI7vD3aHNT8N+Cdnv1pPJkmN8gimUtIrLWQcMsb56Valxq/YGcJG2r?=
 =?us-ascii?Q?82umXIHrOCkogfwBXwg8klDq7XwnT91dcxxRf6GMVqbAkcNQJlXJAZNMmfQH?=
 =?us-ascii?Q?yncB/MMEQI4VTQNrffGbJoIJEYnILBQ7DEaQmirJTjtB7IwNgH5cshY4sp7C?=
 =?us-ascii?Q?px8NnQ0z/dRx0SjZSPoddJqpYVhdGX0gSSmjQL/tn78qfV38ldjdItfAfaEN?=
 =?us-ascii?Q?L/HTl84AcawNnmDE9zqA8jjo9qb1y59gp25gMeclLfEz3c/NVKSuGX5MMPX9?=
 =?us-ascii?Q?+caS7ttz0pzUlxvqcVhVvnHCdApwNbyGwPn6ovAhXrn94ibvT76mvVspd0bD?=
 =?us-ascii?Q?uY+AwYp4akS63czMepvQMcsHXGZwK0EODcVyRr52kk3Je5rbdQOv0QAP3x0n?=
 =?us-ascii?Q?TzVKZf7mCZMpBDAaLWFJo2OzvUE0i+KIDTNag1cHJQ1nTeZUSqqH0/In97oN?=
 =?us-ascii?Q?Eg53Co9/xKeGF7wO59LacbTFiP2wU3tDrD24Eqxg/5Sg4WWb5r+WhPFs88Q/?=
 =?us-ascii?Q?J/H8nzpaOT3OjUZ94Pqpp4f9XlPDlxWo3GjgWjYRofHIh0SfUlf2qICUGU96?=
 =?us-ascii?Q?ra8oOJ5rDGy2mX9AM7nvln31WLtUdV+5IlRZRmpz1JZ+kgqYXD2BvhQghhNy?=
 =?us-ascii?Q?vrImSPJ0X9aTp3tFzgYEW9Ei1w9Sfg2gpbvIOrqM+LsRcHxRH84aWM+t6/6e?=
 =?us-ascii?Q?vfDQcChKDM74DxRKy0xSgArRkM70+2qgS1XJWKoMmjDN/IeIpd/9rIar91+L?=
 =?us-ascii?Q?p42pH3wkIVBY5ya6q5fGYP7CKeb1Nu446xIB75evNzwunIhkEnfnOng04M0y?=
 =?us-ascii?Q?kIG/QqoruwudRmJfLTE9WLCdf2DmqHQgAXwbkSmzF6IqLBH699ALuhGG5B7a?=
 =?us-ascii?Q?ZbOUP8mCaY71sHacC7VPqRBxbGL0PeOOuzLCsPvB2TFmxUBF2FmFmTJKER+r?=
 =?us-ascii?Q?pZYx20+uLRbGM6NHSECzyKlj22jSE8LpZ4HQQ1gRBKexO21AUj8WRF+NF1Oy?=
 =?us-ascii?Q?FJPNcV+SLlPI5mE4Li46HiJomjgsOvx02AhYowrclwgtMpZhqsJT5yFKPwqC?=
 =?us-ascii?Q?jZBJ77k87GHVyDIkvmS4qxF55s/xn0kg+srtPfuhIWy6yYGgSd4tzDoVtz9Z?=
 =?us-ascii?Q?fQ=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d617e90a-83f2-4fdc-1c0e-08dc54252bcd
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 21:29:40.6332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /B23eES0EGZeFyALx96uvqV4moIFu8e3j5WPalOTPRzyBob1k5xPaCraS34f5cDFoE2QFVj26qxHC2bWTMAQXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8586

Enable specifying header flags using enumerated entries in the spec file
rather than raw flag values.

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
---
 Documentation/netlink/specs/ethtool.yaml |  5 +++++
 include/uapi/linux/ethtool_netlink.h     | 11 +++++------
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index f5aa1e7f3383..bae3bb013787 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -16,6 +16,10 @@ definitions:
     name: stringset
     type: enum
     entries: []
+  -
+    name: header-flags
+    type: flags
+    entries: [ compact-bitset, omit-reply, stats ]
 
 attribute-sets:
   -
@@ -30,6 +34,7 @@ attribute-sets:
       -
         name: flags
         type: u32
+        enum: header-flags
 
   -
     name: bitset-bit
diff --git a/include/uapi/linux/ethtool_netlink.h b/include/uapi/linux/ethtool_netlink.h
index 8dfd714c2308..34a4a64262b2 100644
--- a/include/uapi/linux/ethtool_netlink.h
+++ b/include/uapi/linux/ethtool_netlink.h
@@ -117,12 +117,11 @@ enum {
 
 /* request header */
 
-/* use compact bitsets in reply */
-#define ETHTOOL_FLAG_COMPACT_BITSETS	(1 << 0)
-/* provide optional reply for SET or ACT requests */
-#define ETHTOOL_FLAG_OMIT_REPLY	(1 << 1)
-/* request statistics, if supported by the driver */
-#define ETHTOOL_FLAG_STATS		(1 << 2)
+enum ethtool_header_flags {
+	ETHTOOL_FLAG_COMPACT_BITSETS	= 1 << 0,	/* use compact bitsets in reply */
+	ETHTOOL_FLAG_OMIT_REPLY		= 1 << 1,	/* provide optional reply for SET or ACT requests */
+	ETHTOOL_FLAG_STATS		= 1 << 2,	/* request statistics, if supported by the driver */
+};
 
 #define ETHTOOL_FLAG_ALL (ETHTOOL_FLAG_COMPACT_BITSETS | \
 			  ETHTOOL_FLAG_OMIT_REPLY | \
-- 
2.42.0