Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2999914lqz; Wed, 3 Apr 2024 15:10:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV3Z/ESMxWgmaVVZHQ5tGPGVz1me1I5fTq8uOWmWLTDYJ9HlU6TqhsTIseDy0Z+MFy8IvPI0TE//JQ2AyIWa+TF8ax+yidussU6sjWuWQ== X-Google-Smtp-Source: AGHT+IHrT15LFDOxiBs+QoRR54b8GQGDquzKjoXS0SA7cQJcsJ3TeRnFmM3F0gDKcztdsmhxrS1s X-Received: by 2002:a50:cd9c:0:b0:568:c6a2:f427 with SMTP id p28-20020a50cd9c000000b00568c6a2f427mr318632edi.27.1712182210146; Wed, 03 Apr 2024 15:10:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712182210; cv=pass; d=google.com; s=arc-20160816; b=D2aMeYbKW0ShgImOT5w/5X6yWaYH04aeq5IU76z9oo3DzJDtnkkUAv3e2H6cmiC3hW V/ArFG3kJI1xh2llm/3FDbDHNOTJR9DuF9T0bfJm5CBlodvydP08xxQr2jmjpoGC4gTl fSWLzbsA6yCp65J8JHojOUqPgW5ukmnoV/hecRTsxeW41MQRY2ZGqjg2kUKolI73TMj3 f29gJf2DjrmVK8IXAWdNSz363w1LBtT3D0KTeUpD/othXkxH8hhQWiAGa/3CjogKdezj Fiq/2hQGaNvWDFVtvPjllqglH23lSv5lGZcB1c706XqVyh3s8R5ATd5bQpkkGcBOuAau 61dg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:feedback-id:references :in-reply-to:message-id:subject:cc:from:to:date:dkim-signature; bh=uwNMpeVW0XerVfkSfw/u0neKwfY6b63R2YNbmJr2Yis=; fh=FQcgQPOmGl3rZg8VF3+1ji0KZEvpy/XdHFqbDjtxxkQ=; b=OG/0AEWKYDMqhakUWNoXsH4z1JkPROr850JvbXklrhrPwjaCWBjwTG3ksAQng4ZWB+ SESdDi8vInyTyllmNuEbBaDWNalroa4yR6lSVwF4elTab+dUs0fAH0wtBU6Cc6Xbml5j 2J5dPnHF3QMst6GZ1LU2upHCrsqArK3WyyoBd0lzE6M0W03OINYyGecoVvPTshyyBsEW NcNj6cx6esUhnTWcARkE+E+TRDcGc+0iIYXG/IQulebNlaqe/qRhxJGWHng2FxfNoPek KqT6ZmiX89khilU2G7x/fP3DXIpf4MF8grfkOggjJ4s8r9X3Vn4M1aVDfJFsQx8WODhL 9SQQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@proton.me header.s=protonmail header.b=g5bYXxoG; arc=pass (i=1 spf=pass spfdomain=proton.me dkim=pass dkdomain=proton.me dmarc=pass fromdomain=proton.me); spf=pass (google.com: domain of linux-kernel+bounces-130666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130666-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=proton.me Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id i29-20020a50d75d000000b0056dfa248aa8si1565999edj.153.2024.04.03.15.10.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 15:10:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-130666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@proton.me header.s=protonmail header.b=g5bYXxoG; arc=pass (i=1 spf=pass spfdomain=proton.me dkim=pass dkdomain=proton.me dmarc=pass fromdomain=proton.me); spf=pass (google.com: domain of linux-kernel+bounces-130666-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130666-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=proton.me Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D9AAA1F223DD for ; Wed, 3 Apr 2024 22:10:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A3B7156981; Wed, 3 Apr 2024 22:10:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="g5bYXxoG" Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C242A138494; Wed, 3 Apr 2024 22:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.22 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712182199; cv=none; b=RGp/G2TZsV+XYopKKjH+nfdZf1V2Y86OGPkvDHsuFpih1uxtZy578cG3lzt4JzEQhS2bUMZvMaWIUrqIKPpGdCjktuRjPvC/UYwMeBedrjQxNLTIU/DHrVVeBu3TyeSQnGTiGw9T/WKxD1oEIwvswUVaeNB/FZC/RvO0+lZTxWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712182199; c=relaxed/simple; bh=uwNMpeVW0XerVfkSfw/u0neKwfY6b63R2YNbmJr2Yis=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hUNoS4pF/1cdJ1LvyfZJU5lcTHHSjlnW+Zz1/8rkRs2nqRF9wLLeFFaHMZB9A8CTNq4iyzkJHGby6cRiDjZ9KmHMacy3I3h7FvRVbIE46fLyDHEzEyy7rfvAj0X+FinAzd5TUN1FctVNTRTEPX2UhPQ7vXtzTTNKby+4VBmpew4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=g5bYXxoG; arc=none smtp.client-ip=185.70.43.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1712182194; x=1712441394; bh=uwNMpeVW0XerVfkSfw/u0neKwfY6b63R2YNbmJr2Yis=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=g5bYXxoGqxndHYNWtHzNmrse6m3z5qOIF+gu68LKmOKnr+k4nvWNFRZFmuzSCL27m MEtSUXKDZvUfSeTxpEOSlJpmmThUZJzQ6WzqxVovKrEkcysS97yv4+8BFV+aDZjLaZ MFeElpdfeFKDS5otZd6M348XeEjWZgehSR8Lyl2NEcEbZ5f8ir2AhzN5IntLWazftB 6hxFE16N5sOG0dSm9nAnK8o7iWeXqd2DpCBjMUFMvbps39F9y6KPva2/P8lq3yGP7F Z7kJvVtgIEJNLy4s7laA1lq2v7sOS10fHlXrivXbvnjsnBs/L7IcqUAz1E2D2odndk gGihGxgtcgB+Q== Date: Wed, 03 Apr 2024 22:09:49 +0000 To: Boqun Feng From: Benno Lossin Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Martin Rodriguez Reboredo , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust: init: change the generated name of guard variables Message-ID: In-Reply-To: References: <20240403194321.88716-1-benno.lossin@proton.me> Feedback-ID: 71780778:user:proton Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03.04.24 23:20, Boqun Feng wrote: > On Wed, Apr 03, 2024 at 07:43:37PM +0000, Benno Lossin wrote: >> The initializers created by the `[try_][pin_]init!` macros utilize the >> guard pattern to drop already initialized fields, when initialization >> fails mid-way. These guards are generated to have the same name as the >> field that they handle. To prevent namespacing issues when the field >=20 > Do you have an example of this kind of issues? https://lore.kernel.org/rust-for-linux/1e8a2a1f-abbf-44ba-8344-705a9cbb1627= @proton.me/ --=20 Cheers, Benno