Received-SPF: pass (google.com: domain of linux-kernel+bounces-130671-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <58e0cf59-1397-44a3-a6a0-e26b2e51ba7b@intel.com>
Date: Thu, 4 Apr 2024 11:13:49 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 038/130] KVM: TDX: create/destroy VM structure
To: "Yamahata, Isaku" <isaku.yamahata@intel.com>, "Gao, Chao"
	<chao.gao@intel.com>
CC: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>, Paolo Bonzini
	<pbonzini@redhat.com>, "Aktas, Erdem" <erdemaktas@google.com>, "Sean
 Christopherson" <seanjc@google.com>, Sagi Shahar <sagis@google.com>, "Chen,
 Bo2" <chen.bo@intel.com>, "Yuan, Hang" <hang.yuan@intel.com>, "Zhang, Tina"
	<tina.zhang@intel.com>, Sean Christopherson
	<sean.j.christopherson@intel.com>, "isaku.yamahata@linux.intel.com"
	<isaku.yamahata@linux.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <7a508f88e8c8b5199da85b7a9959882ddf390796.1708933498.git.isaku.yamahata@intel.com>
 <ZfpwIespKy8qxWWE@chao-email>
 <20240321141709.GK1994522@ls.amr.corp.intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240321141709.GK1994522@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFdEUko2OUVnN1B4MjBZMUE0SmZ4aVY0QWp4Y3p0SUU2czRpVTVSdFZuYXRR?=
 =?utf-8?B?Kzk3OW9hQUhrVVNNdklJQjVPUVkxRG03cG1RbzcwZ1crZCtZQTJJT0Y1VUJG?=
 =?utf-8?B?RGFtbWNLMkhxLzZia1FNTGZlOGs4ZVhSekVCSnVzcnhwdlNCak1PZisvejhy?=
 =?utf-8?B?UzRLbzJoa3lzelJnQ2pReWtHUnNad2RFVGtpVG04Yk9HSGNFaURHNU1ZOERE?=
 =?utf-8?B?WlRIZTlGRnlwNWx2M0VOK205NUJrc1pZbDNoWkZDdDQ5cW03VC80VFJvRUUx?=
 =?utf-8?B?S21zTVFGMmpXdGRkOGl6YlE4UGxDcEYvajlwOUtJTWFnZjhYeGNMNDBkaVAx?=
 =?utf-8?B?eFdjclJxREFHaDVrLzZ0aFZuenVxRThXNlZHcUxmUm9qQm1SK2pJU3YxSUxn?=
 =?utf-8?B?MnNaT1Q5WlpMQ0N6ZWdEYW9uUDNQV2ppNVd0MGtKS1lwUHJzYlZnNFhncUZL?=
 =?utf-8?B?dFQ1Q3NFOHRtblJ2RGZPcTVDdHUvQWYwdXBxU2VZRk9yek9qNktWNDlTQzZT?=
 =?utf-8?B?WFk2M0lQeHBnZ2lRUXA2THlXWFgxR0kzMCt6SkUyR3pqc2hUQ1ZnakpBM0FG?=
 =?utf-8?B?WkN1WDNxSDBkVVl6LzEwYkg1VFRld0NxZldRdWErK3J2anRqc1RIZFVzbHAw?=
 =?utf-8?B?Y2lMaU5qOGRyN2Z5NldRMnBpbDh5T3NWdHkrZndFbzZTQnhEeUxsVUxzVkty?=
 =?utf-8?B?aGtITXZVcXd1UXVvZFk0aWVpamJLanZCNGZ1TC9SUFp2dFAxcnQ4NmVwdURz?=
 =?utf-8?B?NnVvSC9ScC9HYnRGYnYxQVlNYmdlNnh3VXNlVEdaSnB3dWZPZXpocE51Mktz?=
 =?utf-8?B?SFpjOUFQOWc4ZHpQM2pIdEw5WGZMWjNsM0hJTForamNOYUVuWTVRbEJHcWFv?=
 =?utf-8?B?MHY4RzhCVHZ4OG5pU1NDc0ErRHFzS1pWL3VIUWF3eXNsV3JCYk1KZmtvcEhO?=
 =?utf-8?B?ZUEvM2NQYmdCRk9NeGxXQzNvbnZjTC9Xek1Mc1o0R2t0ME50RGplblRpM0Rw?=
 =?utf-8?B?dUQraEo5YUhzdnU0b2tmMjZNcTJoRVRERmFkSnA5clFQOTZCWEZ6b3JmRGJU?=
 =?utf-8?B?MlhhUjlRYUx2N2lqbTBPNTNQcGlpQUhreC9EQllkREliVHJ2K0JuRDk1U3VE?=
 =?utf-8?B?MUV2YzFwSE1OT3ArcDkwc0JKM0V1RmgyRVh5U1EyRzI5R00vNnlxQWZGdURp?=
 =?utf-8?B?WE10SmF3bW8zODQ5K1FxUk9ucE9hNUNEWjRzMFJ2Y25EeDBQL3B3MDJqTU1m?=
 =?utf-8?B?aTE2ZWpxdlNOak9HSWFxdmFMM1lSNVRCYzIxMGhuaFVqWFV3YmhUa1U4ekdE?=
 =?utf-8?B?bHJNdG1ZdDFWaGJaUDNabStWUnMvajRQR0E4UGRBMWlwVUhyZk8wOU12UlZs?=
 =?utf-8?B?ZmdjaThzcUN4ZmxEVTllUTVsYkhTSmJwV3lKb2E4NGFXZlhyTFFSR2hlTE9u?=
 =?utf-8?B?QlpsL1BxZzdPeHN6L0NUMkliQ053Z0JNbkxRVUExWlZ2SDI5YVZJZFJqQ2JL?=
 =?utf-8?B?TlpLKzB4VDlNbHNkMkFaNXBoZHFXZllwMTN0RUgyVnlpVmxLcFR2L09VbFlo?=
 =?utf-8?B?T0NNQVlTdkdDVXlyZ0tXdkkwYStuL21GYlg1bnc0RVZBYlpScHM4a0ppNitp?=
 =?utf-8?B?RWNEb1F2c3IwSWl6Um51aGhON255cVRKbVVBL1dLdFNoU2M0eE1RcjZhaEFz?=
 =?utf-8?B?c2VlVWs1aXloUVIwbnZjZnpPc1NMR0JCMmdJaXlDeXF2K0wycUhPRWhFa2ZG?=
 =?utf-8?B?aHRVZVN0N2cxVjlmS244TExtOGxEV0FFZHFONnBFNzR4TzI4S09pdXpMR3BP?=
 =?utf-8?B?S084RHlJMkR1TE02eWs3NmdRY1pkM1BBcmlZaXBDeXVqYjBNZmhaNllzVmJh?=
 =?utf-8?B?R3A1MDJRbkZCR0VkTlo0OUlBeHB4ZytwSkczQ1VoTmJzN0lQd2VNQ0ZXc3E0?=
 =?utf-8?B?UHkzVEdUY3ZjWEFYaWdpY1pJeVkwbkFqdnI3VisrSThZYzJIWXhCMEZldGNX?=
 =?utf-8?B?TXpuRXU3UFJkM1dibm5UYlNDNVlVVG1jZzB4MTZrMzlHV1ZyZWFxendoT3hC?=
 =?utf-8?B?a2hRTy85dWhqQUxzYStMMHZpNG8vZ0hsMWd1V3dISE9OMXRXWjBIMFpDNThS?=
 =?utf-8?Q?Ymf6pFl6QsuuAbvEoXDNEoJT9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 374e9149-9685-471f-3fc3-08dc542b5cd7
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 22:13:59.9456
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w0zyqV0/NEfsnmeCr1Ufc7nfPJ/hgM/2JUR1w01YjwFpKrzj8LDk9z94jhaBxyA+9dg51fpBYkoPA2iW84z/8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5254
X-OriginatorOrg: intel.com


On 22/03/2024 3:17 am, Yamahata, Isaku wrote:
>>> +
>>> +	for_each_online_cpu(i) {
>>> +		int pkg = topology_physical_package_id(i);
>>> +
>>> +		if (cpumask_test_and_set_cpu(pkg, packages))
>>> +			continue;
>>> +
>>> +		/*
>>> +		 * Program the memory controller in the package with an
>>> +		 * encryption key associated to a TDX private host key id
>>> +		 * assigned to this TDR.  Concurrent operations on same memory
>>> +		 * controller results in TDX_OPERAND_BUSY.  Avoid this race by
>>> +		 * mutex.
>>> +		 */
>>> +		mutex_lock(&tdx_mng_key_config_lock[pkg]);
>> the lock is superfluous to me. with cpu lock held, even if multiple CPUs try to
>> create TDs, the same set of CPUs (the first online CPU of each package) will be
>> selected to configure the key because of the cpumask_test_and_set_cpu() above.
>> it means, we never have two CPUs in the same socket trying to program the key,
>> i.e., no concurrent calls.
> Makes sense. Will drop the lock.

Hmm.. Skipping in cpumask_test_and_set_cpu() would result in the second 
TDH.MNG.KEY.CONFIG not being done for the second VM.  No?