Received-SPF: pass (google.com: domain of linux-kernel+bounces-130709-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <13a50e06-2b35-4cc6-a3ea-d6e070195db7@acm.org>
Date: Wed, 3 Apr 2024 16:09:15 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: lpfc: Fix a possible null pointer dereference
To: Huai-Yuan Liu <qq810974084@gmail.com>, james.smart@broadcom.com,
 dick.kennedy@broadcom.com, jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
 baijiaju1990@outlook.com
References: <20240403014006.969441-1-qq810974084@gmail.com>
Content-Language: en-US
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20240403014006.969441-1-qq810974084@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/2/24 6:40 PM, Huai-Yuan Liu wrote:
> In function lpfc_xcvr_data_show, the memory allocation with kmalloc might
> fail, thereby making rdp_context a null pointer. In the following context
> and functions that use this pointer, there are dereferencing operations,
> leading to null pointer dereference.
> 
> To fix this issue, a null pointer check should be added. If it is null,
> write error message and jump to 'out_free_rdp'.
> 
> Fixes: 479b0917e447 ("scsi: lpfc: Create a sysfs entry called lpfc_xcvr_data for transceiver info")
> Signed-off-by: Huai-Yuan Liu <qq810974084@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc_attr.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> index b1c9107d3408..b11e5114b7f2 100644
> --- a/drivers/scsi/lpfc/lpfc_attr.c
> +++ b/drivers/scsi/lpfc/lpfc_attr.c
> @@ -1904,6 +1904,11 @@ lpfc_xcvr_data_show(struct device *dev, struct device_attribute *attr,
>   
>   	/* Get transceiver information */
>   	rdp_context = kmalloc(sizeof(*rdp_context), GFP_KERNEL);
> +	if (!rdp_context) {
> +		len = scnprintf(buf, PAGE_SIZE - len,
> +				"ERROR: Not enough memory\n");
> +		goto out_free_rdp;
> +	}
>   

Has this patch been verified with checkpatch? Checkpatch should have
reported the following for the above patch:

   Possible unnecessary 'out of memory' message

Thanks,

Bart.