Received: by 2002:ab2:2441:0:b0:1f3:1f8c:d0c6 with SMTP id k1csp2114lqe; Wed, 3 Apr 2024 19:07:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUOOlcMLjZnWxwzj/dBGKznWWghQVe33LzNYcw7FjBXMAJvEMCMVRWZ7IGJ+hm+5jnvJe9Rbd9pWIpZQoZNGoUKHjI8lJjbMaEdHkLvhQ== X-Google-Smtp-Source: AGHT+IHVKaWsZc8qRwYH8T1Jn/OZHLzojcqVSjm81z3K/U5zRnHRJKoVCfCu5dWPFLOJxqSm4kw2 X-Received: by 2002:a05:6214:1c85:b0:696:2023:e2f7 with SMTP id ib5-20020a0562141c8500b006962023e2f7mr990379qvb.10.1712196455113; Wed, 03 Apr 2024 19:07:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712196455; cv=pass; d=google.com; s=arc-20160816; b=sVduIi0q+MbCwj5HpCPtdUcE4FB5tTy9zmn52r2lDzaNBA8OwAdzN4gg8AnV78Rost 5tpiqhIZM+8P6zRwDaVfhOtUEQExW1KvedLPMRpkZBImrg2y0spONOGTiZ82xXMjawN2 vmff/nzFdkek02lLe5g3V6urJD4Ygc9yI+6EIElAp/rkO4dLT5uM6XxNT0u4Jlm1G17B hEEdIIyFE9HFWFuzYOLM5/vSCNSjHs/7hh7vPsr1WhW73T4juaE06UvvNjtGWP1IuRxz FpSl2mMJwcsb2z8HQtV/Cnw+5nWlQJHzylD5uuLbOmtgR5paD0uMOjlcXosZbCecGt7r lXyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=yiOV832QGyZ/wZTWs4pqNbXMVHbYoRwzOsx0W2v9+Yc=; fh=SGDwnl8IqaaUK4t7VXVEU6zzSrbpmnqc0vEHBFAgA5Y=; b=FSjEAD2bLx215RuQ6TCLnJfxvIQkgMvA63yA+xLBzAUZAmQye17HnHfDOzayNrx95I 7b/uYbM9fhGfva7Fq+rjDa9bAn7e17zo0JPvgdnT5rxzW0k+Y6VOYQs6f6Rt6V9Svk8q /sx/AZqL9KleTqADCOc0DsoxBln6PAH24A6vnEGHZpaxPJCQhf3VIWQ4tHPz7j5R+wIi ZvB5D1SdMOibbdBFOoXJAHjMr+lGRNs+TYWeSX4uijNcJGE49+WzBW/Fxv7QECETvtDV 1JykrXHJ5TIsPeim6bbqf1TVQhBziW6zvCmCgVKK8/8DJd3lfBRr40CEYpU5+Q6/MQRh oqlw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=braSIoFj; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-130827-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130827-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f3-20020a0cbec3000000b00696aca20e55si15274428qvj.59.2024.04.03.19.07.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 19:07:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-130827-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=braSIoFj; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-130827-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130827-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 08E791C22037 for ; Thu, 4 Apr 2024 02:07:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C722718E1F; Thu, 4 Apr 2024 02:07:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="braSIoFj" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF8314400 for ; Thu, 4 Apr 2024 02:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712196425; cv=none; b=Baztx8CX/Fq98a/oJ/ixF9ulP3iRC9QgYIZk2h0LIKq+/Ge/ltqZEpbpLgFR3JdQQARnsvcE5ps8qMxtpB1FrorAXOD1zlL3445wctkcj2x/SbhWXEkZHT1bJuDXxp/y5YY8K5EMSJ894Epev3EnVa4IwZULNSDlOQt+8spWmz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712196425; c=relaxed/simple; bh=rGl64jsFu4NFCV8xif7fw43EZgnfWoX5tPGbLV8aYnc=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=kSau5FYeBDCgH2rDSNgvfDsL80t9OL10wQnQD1wyV0DbnSqKBySXABdNA44J5fEUHNyccuZeZJPM3dPVe0Jur2sJtSZqd+gJl/+R1vn/+3hFRXOEgmGwgLpKFV20G4s/yZqDD+UHcMb/Y3ep5FEAzG4R44Ufx1tI6fIOP338UkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=braSIoFj; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 404EBC433C7; Thu, 4 Apr 2024 02:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1712196424; bh=rGl64jsFu4NFCV8xif7fw43EZgnfWoX5tPGbLV8aYnc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=braSIoFjIbIaY3sxJmyqNH9ciXzMsbgT0MQUJv483n4/7dDqMxpWYDmjKjgzAV088 m5UOTVSbwC4S7khMoULqhJiIE/l4c0Dgdc2nL2Kz3k1jd3G1Lzz3ustZ6AYU0izZTy joobb9mjm8cXnxb7AqSrah+25GiFn//jUuA5EM6g= Date: Wed, 3 Apr 2024 19:07:03 -0700 From: Andrew Morton To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, muchun.song@linux.dev, willy@infradead.org Subject: Re: [PATCH v2 0/3] Hugetlb fault path to use struct vm_fault Message-Id: <20240403190703.3faa039cc207f9f9bd175fdb@linux-foundation.org> In-Reply-To: <20240401202651.31440-1-vishal.moola@gmail.com> References: <20240401202651.31440-1-vishal.moola@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 1 Apr 2024 13:26:48 -0700 "Vishal Moola (Oracle)" wrote: > This patchset converts the hugetlb fault path to use struct vm_fault. > This helps make the code more readable, and alleviates the stack by > allowing us to consolidate many fault-related variables into an > individual pointer. The .text shrunk a little. x86_64 defconfig: 52873 4015 13796 70684 1141c mm/hugetlb.o-before 52617 4015 13796 70428 1131c mm/hugetlb.o-after