Received-SPF: pass (google.com: domain of linux-kernel+bounces-130832-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+9a5b0ced8b1bfb238b56@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [kernfs?] possible deadlock in kernfs_fop_llseek
Date: Thu,  4 Apr 2024 10:12:57 +0800
Message-Id: <20240404021257.4018-1-hdanton@sina.com>
In-Reply-To: <00000000000098f75506153551a1@google.com>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Wed, 03 Apr 2024 11:23:26 -0700
> syzbot found the following issue on:
> 
> HEAD commit:    fe46a7dd189e Merge tag 'sound-6.9-rc1' of git://git.kernel..
> git tree:       upstream
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=15c38139180000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  fe46a7dd189e

--- x/fs/overlayfs/util.c
+++ y/fs/overlayfs/util.c
@@ -1159,9 +1159,8 @@ int ovl_nlink_start(struct dentry *dentr
 			return err;
 	}
 
-	err = ovl_inode_lock_interruptible(inode);
-	if (err)
-		return err;
+	if (!mutex_trylock(&OVL_I(inode)->lock))
+		return -EBUSY;
 
 	err = ovl_want_write(dentry);
 	if (err)
--