Received-SPF: pass (google.com: domain of linux-kernel+bounces-130851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240402212039.51815-1-harishankar.vishwanathan@gmail.com> <82892691-a48f-ad06-7005-5bbd7d0757eb@iogearbox.net>
In-Reply-To: <82892691-a48f-ad06-7005-5bbd7d0757eb@iogearbox.net>
From: Harishankar Vishwanathan <harishankar.vishwanathan@gmail.com>
Date: Wed, 3 Apr 2024 23:05:00 -0400
Message-ID: <CAM=Ch045iUe1vHy+h9FSURbffj1GD_WDhcFJ2W7_amVx-BQATw@mail.gmail.com>
Subject: Re: [PATCH v2 bpf-next] bpf: Fix latent unsoundness in and/or/xor
 value tracking
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: ast@kernel.org, harishankar.vishwanathan@rutgers.edu, paul@isovalent.com, 
	Matan Shachnai <m.shachnai@rutgers.edu>, Srinivas Narayana <srinivas.narayana@rutgers.edu>, 
	Santosh Nagarakatte <santosh.nagarakatte@rutgers.edu>, John Fastabend <john.fastabend@gmail.com>, 
	Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau <martin.lau@linux.dev>, 
	Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>, 
	Yonghong Song <yonghong.song@linux.dev>, KP Singh <kpsingh@kernel.org>, 
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>, 
	Edward Cree <ecree@solarflare.com>, "David S. Miller" <davem@davemloft.net>, bpf@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 3, 2024 at 5:09=E2=80=AFAM Daniel Borkmann <daniel@iogearbox.ne=
t> wrote:
>
> On 4/2/24 11:20 PM, Harishankar Vishwanathan wrote:
> [...]
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index fcb62300f407..a7404a7d690f 100644
> > --- a/kernel/bpf/verifier.c
> > +++ b/kernel/bpf/verifier.c
> > @@ -13326,23 +13326,21 @@ static void scalar32_min_max_and(struct bpf_r=
eg_state *dst_reg,
> >               return;
> >       }
> >
> > -     /* We get our minimum from the var_off, since that's inherently
> > +     /* We get our minimum from the var32_off, since that's inherently
> >        * bitwise.  Our maximum is the minimum of the operands' maxima.
> >        */
> >       dst_reg->u32_min_value =3D var32_off.value;
> >       dst_reg->u32_max_value =3D min(dst_reg->u32_max_value, umax_val);
> > -     if (dst_reg->s32_min_value < 0 || smin_val < 0) {
>
> The smin_val is now unused, triggering the following warnings :
>
> ../kernel/bpf/verifier.c:13321:6: warning: unused variable 'smin_val' [-W=
unused-variable]
>   13321 |         s32 smin_val =3D src_reg->s32_min_value;
>         |             ^~~~~~~~
> ../kernel/bpf/verifier.c:13352:6: warning: unused variable 'smin_val' [-W=
unused-variable]
>   13352 |         s64 smin_val =3D src_reg->smin_value;
>         |             ^~~~~~~~
> ../kernel/bpf/verifier.c:13386:6: warning: unused variable 'smin_val' [-W=
unused-variable]
>   13386 |         s32 smin_val =3D src_reg->s32_min_value;
>         |             ^~~~~~~~
> ../kernel/bpf/verifier.c:13417:6: warning: unused variable 'smin_val' [-W=
unused-variable]
>   13417 |         s64 smin_val =3D src_reg->smin_value;
>         |             ^~~~~~~~
> ../kernel/bpf/verifier.c:13451:6: warning: unused variable 'smin_val' [-W=
unused-variable]
>   13451 |         s32 smin_val =3D src_reg->s32_min_value;
>         |             ^~~~~~~~
> ../kernel/bpf/verifier.c:13479:6: warning: unused variable 'smin_val' [-W=
unused-variable]
>   13479 |         s64 smin_val =3D src_reg->smin_value;
>         |             ^~~~~~~~
>
> Removing these builds fine then, please follow-up with a v3.

Apologies. Yes, these smin_vals are not required anymore. I'll remove
them when sending
the v3.

> Thanks,
> Daniel