Received: by 2002:ab2:2441:0:b0:1f3:1f8c:d0c6 with SMTP id k1csp61368lqe; Wed, 3 Apr 2024 22:29:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUKn3OCfveWi34EXEhgHGi1wpyNw7JE1L1qFnEinazmRUgBLezwhiYs6aXfefFypiXll1DEmCtNW1WI17GeWO3eVYGlmEH/Cx/1oBSC6A== X-Google-Smtp-Source: AGHT+IG7fXcPev1WW36wzPTn/akem8IvP2czE6/i/4j5+mQ/C29tCXMyA/UEheZvsoXnG0fIGUTM X-Received: by 2002:a17:907:2d2a:b0:a4e:38c0:8730 with SMTP id gs42-20020a1709072d2a00b00a4e38c08730mr788646ejc.77.1712208591637; Wed, 03 Apr 2024 22:29:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712208591; cv=pass; d=google.com; s=arc-20160816; b=zhnyrwOQfkCyqhW9lp5dcMKfymovwFvG9s3eJRv96xaIxCf3YVS8ns9nS4ZIjbPVNs I/GU9nntRoUxpfwIW6I4TaOypjsyTvZfpurKxV+zqibloSwbukdJYHsllf7lZbqQ4e0K v+/XvcSMqcoSeiZJTt/Cw055Za1hCAGo8hIVNGYllaVaPp7T9+nSPzIQaqnirjuL3K7Z FzjYG3iWxt28tInBJq7yS6YFne3JS0FT3r/8yhGSLmU4rDUCZpQrZH855SraD2OA1cmc sSiCtss3Xso8WuM1kDuATlE0h0t/NOlGrDoUf8kjYgLMrFUWnGDOGIQgrxvNONGgH3AS QOXA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id; bh=Mz9NJQ7ch3dRlIFAyABK1Q37Ak3ZNmvEQQgrRjTgS4o=; fh=s5KNhccL/XK4w1rS7QQlBM0kcdo+SEdLwibEw6k9+MA=; b=QR6/G4FKteTLHjQrqo8cyBKVjXGI5lfOF+BWc8d2oean8xVHNmM9UI7nx9Djy42xmi M3+Iui3xzxzV+XZTAAPNtb1ZXZ+WlkDdCWyyb6tAX645cr2/45zF1w6uFzmlaxW+fJ1m v8HQND2mDsWOZ4935pQsy5m6wGE6ZSt8CbvFAYiEAsAOjx+aJ2AdAuOs+35CnklAle65 FigyvdYewi8Y8fRAX/pGc+MCFXuNEw5FLnTNX45JCLj8BjGvwnql+PCu2UTYXybjSgS1 vGHRqDebNuWY50pQjVTQRe6IJuZWZhcpNMbRNtez05EPSpQxiJptiA8h+r3NrK1bPOwz ejBQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-130949-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130949-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id f23-20020a170906085700b00a45ed888130si7460153ejd.536.2024.04.03.22.29.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 22:29:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-130949-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-130949-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130949-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2FAAC1F210E6 for ; Thu, 4 Apr 2024 05:29:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3CA6A4CB3D; Thu, 4 Apr 2024 05:17:01 +0000 (UTC) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F22F22611; Thu, 4 Apr 2024 05:16:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712207820; cv=none; b=UsOpo+udnzGZ+W2/nSvAGs2y95TCCJGkLsAZ6za7ASBBDP5pWMr2rmfUMvq2rEgPsFz3IBfjlQjGawAZjobZwZDyqWdgpZ2EXm1hCbaUGMr++XhG41/Guy7vlySh9zdyVS+60t18bbVoqGVfegc0BzK0KT5Y7II0dcZcc4CAbpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712207820; c=relaxed/simple; bh=kLxk2xDPYEJwdhPF2hVs4UUw2PfOebmBM+7yLPdjSHU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OnnbrORqVlMZRytpYozDHbAkBoWRynH83EcVjyJ7Q7wrd1EuEgkFSrZwf+V6O1zmMqSHz7MfxOQADawY6+H5uYU8D/DjQjecjbo+Ay+HlKaQNpHsH2jFYFRiv8Baz4dq/Xc1veaLF6WkwlZVePlbPY7lNTfB9FBeY3sZ0sEBK3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4155baa696eso4064845e9.2; Wed, 03 Apr 2024 22:16:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712207817; x=1712812617; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mz9NJQ7ch3dRlIFAyABK1Q37Ak3ZNmvEQQgrRjTgS4o=; b=qPBjkfyGCV13tBzIA7dEElElyfuCwI2eKxmo1Kjis8L3wnTCMIsAtGO+b9O4PUjesO LklNttO1+Bo46SHfARvtShifPz7KT2lJQh6zUBdyNUqbhYl0m+9FqMtF8bT+/LcVMTWR T2nzgvs+7n0aSPFA8IP98cCDzURWXQOZjHXZeaEc//lvEvf+c7YkNBzIeofH0nNSMpaX g/Dg0pVNCziOVYhDIHrbMg7gelCSM2mdm/IZn4+7+fTJ7fxCV09hY+NtRX06lrUykWdh WYqpcd1QnoHWH4vv9QXIOEXjjYZY0D7w5b8G3y0qI1oZ3rHXPsiOMuVguDmpxs+oQq6u Kmkg== X-Forwarded-Encrypted: i=1; AJvYcCUC0eJkCBuCaL79in8d8e947z+AM7ZDkcXL/0+Oz2Nvp5ompee459iA2AecECRgn/greloxLdgnnEsQ9BcILWFs8V5ngfsjYVsvM03Ca0lMXpzCO3gHbAJPKgu8N1qgiYH02eKYALH7PMLW X-Gm-Message-State: AOJu0YzzPPcYUlzzY85ctOfn9ZpJ+cBm5KGHQqtKLe+qLJnNzODaAF6p Jdx7Db8QlWLFePj8HzwEET+fAbGfxDyMBdBpO432/Hhz+RGuotOc+8aC9VhkhAw= X-Received: by 2002:a05:600c:21ce:b0:414:860:bdc5 with SMTP id x14-20020a05600c21ce00b004140860bdc5mr1084800wmj.17.1712207817303; Wed, 03 Apr 2024 22:16:57 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:69? ([2a0b:e7c0:0:107::aaaa:69]) by smtp.gmail.com with ESMTPSA id d9-20020adfa349000000b00343ab9c3d39sm1829214wrb.5.2024.04.03.22.16.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 22:16:56 -0700 (PDT) Message-ID: <573aac92-9c9b-427b-a76f-3c0b7c3b6ce6@kernel.org> Date: Thu, 4 Apr 2024 07:16:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/3] serial: Do not count XON/XOFF in the statistics To: Andy Shevchenko , Andy Shevchenko Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang References: <20240403144722.860258-1-andriy.shevchenko@linux.intel.com> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04. 04. 24, 0:15, Andy Shevchenko wrote: > Wed, Apr 03, 2024 at 05:46:14PM +0300, Andy Shevchenko kirjoitti: >> Some drivers count XON/XOFF in the Tx statistics, some do not. >> I actually a bit uncertain, but I _think_ the correct way is not >> to count them, hence this series. > > Okay, it seems there are much more drivers doing that. Perhaps we need > to add that to the rest in this case (i.o.w. invert the series from removal > to addition)? Interesting, perhaps cut & paste? XON and XOFF are overhead IMO. So should not be counted. When they are, they mangle statistics as in transmitted (real) bytes per second. How are they handled on the RX side? thanks, -- js suse labs