Received-SPF: pass (google.com: domain of linux-kernel+bounces-130956-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 04 Apr 2024 10:51:10 +0500
From: Nikita Travkin <nikita@trvn.ru>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Raymond Hackley <raymondhackley@protonmail.com>,
 linux-kernel@vger.kernel.org, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob
 Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Stephan Gerhold <stephan@gerhold.net>, linux-arm-msm@vger.kernel.org,
 devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Joe Mason
 <buddyjojo06@outlook.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: msm8916-samsung-fortuna: Add
 touchscreen
In-Reply-To: <dyeqnhgvlzw44baihb257lhacei723iqoskthh2bjsfsgvxfrq@6hnk4f3ncsfl>
References: <20240312074536.62964-1-raymondhackley@protonmail.com>
 <dyeqnhgvlzw44baihb257lhacei723iqoskthh2bjsfsgvxfrq@6hnk4f3ncsfl>
Message-ID: <13170c97e7b84001da966ec06b62b002@trvn.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Bjorn Andersson писал(а) 03.04.2024 23:49:
> On Tue, Mar 12, 2024 at 07:45:42AM +0000, Raymond Hackley wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
> [..]
>> +&blsp_i2c5 {
>> +	status = "okay";
>> +
>> +	touchscreen: touchscreen@20 {
>> +		compatible = "zinitix,bt541";
>> +		reg = <0x20>;
>> +
>> +		interrupts-extended = <&tlmm 13 IRQ_TYPE_EDGE_FALLING>;
>> +
>> +		touchscreen-size-x = <540>;
>> +		touchscreen-size-y = <960>;
>> +
>> +		vcca-supply = <&reg_vdd_tsp_a>;
>> +		vdd-supply = <&pm8916_l6>;
>> +
>> +		pinctrl-0 = <&tsp_int_default>;
>> +		pinctrl-names = "default";
>> +
>> +		linux,keycodes = <KEY_APPSELECT KEY_BACK>;
> 
> linux,keycodes is not a valid property of zinitix,bt541 according to the
> DeviceTree binding. Is there a binding update for this somewhere?
> 

There is a series for this [1] that Dmitry seems to have no time to pick
up for a long while now, which we carry downstream. Without correct
touchkey definition the touch controller reassigns the tkey lanes to the
screen surface and display calibration breaks a bit, but since we don't
have the changes upstream for now, probably want to drop this line from
the submission so we don't introduce more dtbs_check warnings.

Nikita

[1] https://lore.kernel.org/r/20230801-zinitix-tkey-v4-0-b85526c5a474@trvn.ru/

> Regards,
> Bjorn