Received: by 2002:ab2:2441:0:b0:1f3:1f8c:d0c6 with SMTP id k1csp75951lqe; Wed, 3 Apr 2024 23:14:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWyMAhtqolbct3ODa8FdP6jWamM507QLnwn1POefXcGLP4uCNBLobzd4Tau4wxUvStO2LHEHgnMEe9M7Od7faTDT48zBSegxFA9Voh+kA== X-Google-Smtp-Source: AGHT+IFATvww2YAfB2AHwwN+pfErZdtsou2+fsjfCCVbyiAirONyMaCCrpfpiaIi/1WvaPu2vMpt X-Received: by 2002:a50:d618:0:b0:56e:3e5:965b with SMTP id x24-20020a50d618000000b0056e03e5965bmr958000edi.18.1712211243619; Wed, 03 Apr 2024 23:14:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712211243; cv=pass; d=google.com; s=arc-20160816; b=N2PNYb9VKc5dshsHvPFQ6i9MTo76o1G0ptNj10dkHVn+9xvETzaCxIa/m88kqrda2O v59NDRw3KXaw0n5cLJoIRQSNeR1rtdWcYlISTr0UXHF+noECU9rceEi6C2WFCou2l4QO 5gnpEnuzHa7SWeRC0v5TCujkaRIfSq6VRBO+5Nly9KOMv6qRCoUw8rZSd9NyBqZ/Rb1l 4fFGdKX4w+VGPZrhfCdT9jabg0tEyUX7k5yfpFaOEZbpgolGnXtRBEQo0coKSg8Ev0gy jW8sxGNJ1i96YoNbv92yiJT4xhwM//UycWY3ZmZrPp3ybuZSAvuebCLkdc3ml+TkKLxf HBBA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id; bh=/LQeNvn8CRkB9bLvweih3cjrt58Ut3yzCRbRnITZ2hY=; fh=fqJBRf3S0c9z8ylzaCvF+hIe5Y6xhvxyuWjkQex9+t4=; b=xCSkCHrXfk/jQ2fXFxwG8aFgbSe574v+bb4deg+yaKqaqSqpmlpvE9z06Z8i6LjLn6 qNTqr64QVUMQFnDkt0V47uj/ISF7Q0wyCYqTDbSEJ9Y3iNZ+rID937ztHqcZVvGdlap6 njHdYoVZXRXfD+UeF5IZPTHOmBFpp/JaXWWd/hQfqD8cv5FXqK1GawQzQOogha+NqaLG +eI9bpZXEmh2HdCJxUCVCgT6Me6E3jVfcV/QozrF51K2I8mZXdojMP+TOR/Q6ECv6luk 3jC7po2KlbbfSlvH2xDPeTh5lUBEDji892XaaGoF2M/33nx0UDTDwl9ZTr189nYoOKNV hGzw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-130967-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t30-20020a50ab5e000000b0056df37529a4si2224461edc.474.2024.04.03.23.14.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 23:14:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-130967-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-130967-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-130967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D919A1F24A51 for ; Thu, 4 Apr 2024 06:14:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6654048788; Thu, 4 Apr 2024 06:13:56 +0000 (UTC) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A06495FD; Thu, 4 Apr 2024 06:13:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712211235; cv=none; b=nIXBGCgFTzentGQZV2b5VaCO7MnGrvYtn2ZBKFjHGhIi2s9KhzJTOfUa43TlOSnzmGP9tNW2/lSPObtsyJwTPpDqst0s2YTg1nHhGxHFj1BK7FZN5MbQRji+jKQVNxC+kHVH2akjfEE5DMzx0SO0jlVwYkfC5NNA9PjNeGOQWdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712211235; c=relaxed/simple; bh=KMFVnRj1puoFTacPA+r3a1ZmpxceZFD6zL48kvYrs+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s8Gb9GgqupbZ1Pzj6a1KhTZcSh0YVwlCR1m3Y/L8JhJLgrC97FJN0D2Y/SSuZEWH7+8n6aL2N2C708XpZdsYXsYSZXlfEc+7udrWqdne3uG1GYxaisYx2b8+MGZE+6Kh5oqSJNkY/FyVtEoYJWnre5DsO5DbgCaL8GiiFFvT7F4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4162b5ba333so606225e9.1; Wed, 03 Apr 2024 23:13:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712211232; x=1712816032; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/LQeNvn8CRkB9bLvweih3cjrt58Ut3yzCRbRnITZ2hY=; b=ajsSkeT9EDSiFgRgHxPp1QNE5ytjrqKce4Ldv2V5QaenU7TizMSu6Nboo2HSgOBvTx b8UHSfEwvKvYM8yEjSsUgBN+W0cKD54WR+5cFnJlVBSp8Buuq/9dxWxuv27MkMW8gD4A utP2A1tfSBvM2xO0xoChE88eThxjZ6hJkT7Ca7RipCmV2RHzwqcAYiLZjSFFAfmTfs/c CG7tQc1CkdTCYgxarCwfmPpULLOQbIB5J9klyKY7S7IYNaW7f8uiMaG/1TeUdU2fFWE9 mcI4T6U/B8cRz3LoNqnbuVuaBS1+19xF1ctXyb9zU8w3gEJQInWXEdBQ6a3tuaklOh1A CLXg== X-Forwarded-Encrypted: i=1; AJvYcCX+023ylC/EAzr6zadaXo0lY6c+jBZyMQOb9fKUBxj2AtokY3bTQnN7SghEOrYvIY02CDvGVCs5NAPVL4pEFylJA6/4Eed0ln+mqotmt5GZb9oHFta2rpIcbb71VIEwAOQSLNoaVpLepP6h X-Gm-Message-State: AOJu0YwU/Zy5mxSygCd7xXH1dkrpoqeJwmL2Bw9DBTm3Jrh+MvO4B+qu fEwHUyQcPs/EF6jf1NX9Rf6OHgNyMKjU9H/RrNzFR0PHzGyiTcjw X-Received: by 2002:a5d:4384:0:b0:343:8097:3e3 with SMTP id i4-20020a5d4384000000b00343809703e3mr872816wrq.40.1712211232463; Wed, 03 Apr 2024 23:13:52 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:69? ([2a0b:e7c0:0:107::aaaa:69]) by smtp.gmail.com with ESMTPSA id t1-20020adfe441000000b0033e756ed840sm19019393wrm.47.2024.04.03.23.13.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 23:13:52 -0700 (PDT) Message-ID: <461a0f0c-c1c9-4bba-bc3e-787024b5de7d@kernel.org> Date: Thu, 4 Apr 2024 08:13:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tty: Convert from tasklet to BH workqueue To: Allen Pais , linux-kernel@vger.kernel.org Cc: tj@kernel.org, keescook@chromium.org, gregkh@linuxfoundation.org, richard.genoud@gmail.com, linux-serial@vger.kernel.org References: <20240403161559.19970-1-apais@linux.microsoft.com> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20240403161559.19970-1-apais@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03. 04. 24, 18:15, Allen Pais wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behaves similarly to regular workqueues except that the queued work items > are executed in the BH context. > > This patch converts drivers/tty/* from tasklet to BH workqueue. > > Based on the work done by Tejun Heo > Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10 > > Signed-off-by: Allen Pais > --- > drivers/tty/ipwireless/hardware.c | 15 +++--- > drivers/tty/serial/atmel_serial.c | 79 ++++++++++++++++--------------- > drivers/tty/serial/timbuart.c | 19 ++++---- > drivers/tty/vt/keyboard.c | 34 ++++++------- Could you CC maintainers of the drivers? -- js suse labs