Received-SPF: pass (google.com: domain of linux-kernel+bounces-131002-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <7fd8c4ab-22a2-2d0c-2257-14441ae79c29@quicinc.com>
Date: Thu, 4 Apr 2024 12:34:31 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH 2/7] dt-bindings: clock: qcom: Add DISPCC clocks for
 SM4450
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Michael Turquette
	<mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, Rob Herring
	<robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Vinod Koul <vkoul@kernel.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
CC: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Taniya Das <quic_tdas@quicinc.com>,
        "Jagadeesh Kona" <quic_jkona@quicinc.com>,
        Imran Shaik
	<quic_imrashai@quicinc.com>,
        "Satya Priya Kakitapalli"
	<quic_skakitap@quicinc.com>
References: <20240330182817.3272224-1-quic_ajipan@quicinc.com>
 <20240330182817.3272224-3-quic_ajipan@quicinc.com>
 <d020d14a-6f57-4283-ab71-293f1d9a9cc9@linaro.org>
From: Ajit Pandey <quic_ajipan@quicinc.com>
In-Reply-To: <d020d14a-6f57-4283-ab71-293f1d9a9cc9@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 3/31/2024 1:47 PM, Krzysztof Kozlowski wrote:
> On 30/03/2024 19:28, Ajit Pandey wrote:
>> Add support for qcom display clock controller bindings
>> for SM4450 platform.
> 
> You cannot add support for a binding. Either you add a binding or not.
> Please look at git history for inspiration.
> 
Thanks, will update commit msg in next series
>>
>> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
> 
> 
>> +
>> +  clocks:
>> +    items:
>> +      - description: Board XO source
>> +      - description: Board active XO source
>> +      - description: Display AHB clock source from GCC
>> +      - description: sleep clock source
>> +      - description: Byte clock from DSI PHY0
>> +      - description: Pixel clock from DSI PHY0
>> +
>> +  '#clock-cells':
>> +    const: 1
>> +
>> +  '#reset-cells':
>> +    const: 1
>> +
>> +  '#power-domain-cells':
>> +    const: 1
> 
> No power-domain? This looks incomplete.
> 
> Best regards,
> Krzysztof
> 

SM4450 doesn't support MMCX hence power-domain isn't required
-- 
Thanks, and Regards
Ajit