Received: by 2002:ab2:2441:0:b0:1f3:1f8c:d0c6 with SMTP id k1csp110160lqe; Thu, 4 Apr 2024 00:48:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVozR1VXunavPnkTh9AF+vhNotve5Eqz8oqdr8gbmphx3b1o4Z1U72GJSngebdElXjuTyVdSnqvk2wdO0qx+Onqo23HoRCNY+ptiO9Osw== X-Google-Smtp-Source: AGHT+IEncv1FX4vB/yrTOl+wgY93TJ2rwtRX9gyhIyHXlaD+2nLlpgdeXPjIbfoBrcKCpUwrZGJv X-Received: by 2002:a17:90a:ac11:b0:2a0:3c7e:b89e with SMTP id o17-20020a17090aac1100b002a03c7eb89emr1858208pjq.11.1712216896292; Thu, 04 Apr 2024 00:48:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712216896; cv=pass; d=google.com; s=arc-20160816; b=pc3lquXR63LG7V3hTCz6dWvQ5eBCC2UfvI8baqZLM9AAGlT3fPnVCeNS7rISQDArEN IMNqGtQ+GRPm2wtutvHVU5JEGNfiJHj3+hycl2+qmbNylQWwDCzpcW3pWnNBVa4ieQmx ow1QH9o2qlaJNpsJ6sBjb/I/YAyX/ukitnyisJQDB1tQpfVLq04ELRK3RFaS2+TMsRX+ 99o9T8TlhUlW42/hF/QfgMxO6BUDupk3Cul5ho1YW/B/1wid1KAbNmiaiebIxYSiqCFS kS3pdbBTpDOPIB4NO3AbUXW1wcfcLSIrKr5PjpTZMTj7E4otnaWshxto9pk1U9tKPCMj EftQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date :dkim-signature; bh=//sAcOVGiFM67Mc+7u0Jl/+UyvrH+ecyO1z9cymLgoc=; fh=2OFM1XMcgXt7J77o17Bc3gUiDHfRmyBMEyNKB4h3DLg=; b=OCtpcHW7E4+ITRQhFdpdySp7gnNSR+clfhoZb/vE6HY9La8TLiXvxyaD1FKOpT64aW jhRIxxpHXD64Hms8/280Dsp4DKdyD3Xh/dOhWVxIHIUjBItzfBrP6jQzrRUscGGWkE4p qSSpiv7pWoPmB+nJrGGgW2D1+7OuYwFRWGxnPU8SwEmBRJtGkSg6NU3IIQ//9fojwUDH exxYoKbfaauO7TrT+ETtITnqtNBHAOyGCQkp3ym5fTwCRCTM42AeDyBtTQdAF2tnBvYt SECGfGjlCfqfZ0tDvD48QJiFkYy3C4bnRx5r8dmlXlsmJGb0IBq902hgukslMRmpMYpn HABw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NI2aZhhX; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-131037-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131037-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id o12-20020a17090a5b0c00b0029bb297c136si1136884pji.67.2024.04.04.00.48.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 00:48:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-131037-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NI2aZhhX; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-131037-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131037-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AF7F1B2779F for ; Thu, 4 Apr 2024 07:32:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AAB935BACB; Thu, 4 Apr 2024 07:32:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NI2aZhhX" Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 381F359B75 for ; Thu, 4 Apr 2024 07:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712215934; cv=none; b=i1GBLe6Hpi4hLKe5fCdfvspPer12y0J2ZluwL7He+5DkJgCkvsfpmoBDDU+rPzPQfXiWtADk8e+aCpvGcYL8JjJNCgiNsF6+vDzgs+3RO0PNg3HnhsyDe7niV6m9XFo9xO8ltBFdV3pALpfSB3EUqndMR9r+OTTwTo/pyCwB1/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712215934; c=relaxed/simple; bh=Ls3PpIQ2YyG8xs+4rpQ3hM8m7hScp+Qun/2/ykjbdKw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=AzEzFxFtR7vDiopj+lRxQLb86hekz2zeR6f6qp2OMxWvBGUxWwhxsGx+C2Fbfa5SJyEdu2PaqwL8Tv21oos374i4MPsTDzmlSlsIt6BsWzrtuL1kxLK+Fqo9y+D2zJzadeO60uFg3X6DI3NBDeLm+9JKMutgLCBhTv6TyIZuZK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NI2aZhhX; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-56e22574eb3so42520a12.3 for ; Thu, 04 Apr 2024 00:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712215931; x=1712820731; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=//sAcOVGiFM67Mc+7u0Jl/+UyvrH+ecyO1z9cymLgoc=; b=NI2aZhhXCQ6QWkJfbx1MpJwSI0s0ENFJ4MmReW/55Nyo4LTX5UfIoPPFXSyvhXGtoZ vqu05wb51knuofbAk/7YoU8EFjH8BDWNOEFR1Zosl/twhmwQM29I1M1+y/Jrwt02JnZF OMoJJ6La5xVZdX56nO6UyO+J5ZQA1DpFSzVWpjnhSe7BOfZtr4s/KPJ6nD4TUiMWo+xk JyOt86SFO48KTzXeZNDwoPp2uF4uXwbY14XNO7YiJ9LUmJJCbFjouyeZpEcuYyMvsS5t XPZojwzwRKCOPoWJgWhwFAKdyIRQ14xpHVDLeAmOhU2HRq/xnNDo3rUkEXbV3dprPqNg /OpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712215931; x=1712820731; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=//sAcOVGiFM67Mc+7u0Jl/+UyvrH+ecyO1z9cymLgoc=; b=Tu9UBWXi4NmIEOUmfKWOkBLlA2j3AEFiuSoY2OEMueIp7PpC5pu/rO3uo82araQdVC IMxrlJ1YwhhbPU0QI95BGzP5siVfqiZg2BzyXhf4VuYH+6TJAhdUKvQSyUhtt20VFB8f aPIkp02EXgL1m1XdoxJzIbv34ZFbLHZOxIRfnksBmZ/5RObu/8elgdndd/dC521Seeoq 4hlrkbztWoN/slfGqUE8qff/TLPHm+IKEl+K2gf2/qT9qxvKQS+oycYBh3OQ9bBuxFFv KMCKVNoI07Hw8lFjOuf5N9OWk22WnQU2juj/A4D5z9jDRMlfPJScI/RQQHEggj8Kk+4w 1n/A== X-Forwarded-Encrypted: i=1; AJvYcCUcxvFahLDKtJ/EcsmzlshKZ69BMV/4VHW+uY43tbV/UTm8vJEciVpTVe7aGjZKoFHnf0N+qGLeCPFaZJz8vKGYFoM6B+Ke5QSVkI5k X-Gm-Message-State: AOJu0Yxr38ByX0piTnNzcbzFRopAK4GvBpna4HF6Uzci/HUtAzag5FOX 1JfBKvIHIEWF2u+OtEOtLkHVCc8VbdmmLYMxWIIXXE6QpcJ9DA4X5//3reJp/CI= X-Received: by 2002:a50:8add:0:b0:56d:ee61:6874 with SMTP id k29-20020a508add000000b0056dee616874mr1078667edk.20.1712215931473; Thu, 04 Apr 2024 00:32:11 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id s2-20020aa7cb02000000b0056c0d96e099sm8845373edt.89.2024.04.04.00.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 00:32:11 -0700 (PDT) Date: Thu, 4 Apr 2024 10:32:07 +0300 From: Dan Carpenter To: Rohit Visavalia Cc: Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Michal Simek , Vishal Sagar , Tomi Valkeinen , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm: xlnx: db: fix a memory leak in probe Message-ID: <86def134-9537-4939-912e-3a424e3a75b6@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding Free "dp" before returning. Fixes: be318d01a903 ("drm: xlnx: dp: Reset DisplayPort IP") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c index 5a40aa1d4283..8a15d18a65a6 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c @@ -1716,7 +1716,7 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub) ret = zynqmp_dp_reset(dp, true); if (ret < 0) - return ret; + goto err_free; ret = zynqmp_dp_reset(dp, false); if (ret < 0) -- 2.43.0