Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758730AbYAUI3t (ORCPT ); Mon, 21 Jan 2008 03:29:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757982AbYAUI3k (ORCPT ); Mon, 21 Jan 2008 03:29:40 -0500 Received: from ug-out-1314.google.com ([66.249.92.172]:16575 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757795AbYAUI3j (ORCPT ); Mon, 21 Jan 2008 03:29:39 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=C36CYKjdUNOhRqCIe9iv+dZtn+Frivtm3lisXTUJr08QtZz5EOr4q+TZaUPNWZGDdksMCFNicTtV4fFXxJOq3TqEIGyQj5dZZuSMXJ/rS8GAGkx6TPK2cvMNhT3jUuTWwjY06RDpTl8ItuFKKrRaoCRIs0mZPDg2vkL0/xZbTos= Date: Mon, 21 Jan 2008 09:36:09 +0100 From: Jarek Poplawski To: Dave Young Cc: Kay Sievers , Alan Stern , Greg KH , stefanr@s5r6.in-berlin.de, David Brownell , Kernel development list Subject: Re: [PATCH 7/7] driver-core : convert semaphore to mutex in struct class Message-ID: <20080121083608.GA1789@ff.dom.local> References: <1200626323.5640.21.camel@lov.site> <20080118073836.GA1703@ff.dom.local> <20080118082327.GC1703@ff.dom.local> <4791C555.9050205@gmail.com> <20080121013021.GB2832@darkstar.te-china.tietoenator.com> <20080121014335.GA3219@darkstar.te-china.tietoenator.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080121014335.GA3219@darkstar.te-china.tietoenator.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 20 On Mon, Jan 21, 2008 at 09:43:35AM +0800, Dave Young wrote: ... > Convert the class semaphore to mutex. > class_interface_register/unregister use class_device_* functions, so SINGLE_DEPTH_NESTING added for lockdep please in these functions. Looks fine to me now, but... I think you forgot again to make it clear that there were no lockdep warnings observed after this patch. And it seems there should be used something more complex than usb mouse or modem to verify this. Then IMHO it would be very nice if Andrew dares to merge this to -mm... Regards, Jarek P. PS: I miss a lot function names in this patch... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/