Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758793AbYAUIot (ORCPT ); Mon, 21 Jan 2008 03:44:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757443AbYAUIoj (ORCPT ); Mon, 21 Jan 2008 03:44:39 -0500 Received: from hs-out-0708.google.com ([64.233.178.250]:40939 "EHLO hs-out-2122.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758159AbYAUIoi (ORCPT ); Mon, 21 Jan 2008 03:44:38 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Ri6MRPzDo77nDoZX2lshE8AKyrpbEvgUouRiCXg5vu34GslCfk5XgO7TG79X8RpLQzoSvRHKwkWsajWovwO+T0rYrnI90qvwSIMybd0NN3ZPNTZhx2QAQ8DfBvAgxpvJ9M4YanhENnR28d9Qosyynck1Jfng44xTjpEJCAXiqEo= Message-ID: Date: Mon, 21 Jan 2008 16:44:36 +0800 From: "Dave Young" To: "Jarek Poplawski" Subject: Re: [PATCH 7/7] driver-core : convert semaphore to mutex in struct class Cc: "Kay Sievers" , "Alan Stern" , "Greg KH" , stefanr@s5r6.in-berlin.de, "David Brownell" , "Kernel development list" In-Reply-To: <20080121083608.GA1789@ff.dom.local> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080118073836.GA1703@ff.dom.local> <20080118082327.GC1703@ff.dom.local> <4791C555.9050205@gmail.com> <20080121013021.GB2832@darkstar.te-china.tietoenator.com> <20080121014335.GA3219@darkstar.te-china.tietoenator.com> <20080121083608.GA1789@ff.dom.local> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1119 Lines: 27 On Jan 21, 2008 4:36 PM, Jarek Poplawski wrote: > On Mon, Jan 21, 2008 at 09:43:35AM +0800, Dave Young wrote: > ... > > Convert the class semaphore to mutex. > > class_interface_register/unregister use class_device_* functions, so SINGLE_DEPTH_NESTING added for lockdep please in these functions. > > Looks fine to me now, but... I think you forgot again to make it > clear that there were no lockdep warnings observed after this patch. > And it seems there should be used something more complex than usb > mouse or modem to verify this. Then IMHO it would be very nice if > Andrew dares to merge this to -mm... I applied it in my kernel, built and run without warnings, but it need more testing. I will be very glad to see the test result about this if you could, thanks. > > Regards, > Jarek P. > > PS: I miss a lot function names in this patch... > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/