Received-SPF: pass (google.com: domain of linux-kernel+bounces-131111-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 4 Apr 2024 14:04:42 +0530
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
CC: Siddharth Vadapalli <s-vadapalli@ti.com>, <nm@ti.com>, <kristo@kernel.org>,
        <robh@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <srk@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am62p-main: use eFuse MAC Address for
 CPSW3G Port 1
Message-ID: <77abfbd6-ee24-4a25-a05b-51bd7716a26f@ti.com>
References: <20240402094200.4036076-1-s-vadapalli@ti.com>
 <ae04c041-688c-4413-8f15-b37b4ea44aac@ti.com>
 <f7cadda8-c3cf-48a0-846a-1ff317a28292@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f7cadda8-c3cf-48a0-846a-1ff317a28292@ti.com>

On Tue, Apr 02, 2024 at 04:02:07PM +0530, Siddharth Vadapalli wrote:
> On Tue, Apr 02, 2024 at 03:25:41PM +0530, Vignesh Raghavendra wrote:
> > 
> > 
> > On 02/04/24 15:12, Siddharth Vadapalli wrote:
> > > Assign the MAC Address programmed in the eFuse registers as the default
> > > MAC Address for CPSW3G MAC Port 1. Utilize the "ti,syscon-efuse"
> > > device-tree property to do so.
> > > 
> > > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> > > ---
> > > 
> > > This patch is based on linux-next tagged next-20240402.
> > > 
> > > Regards,
> > > Siddharth.
> > > 
> > >  arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> > > index 7337a9e13535..eb126f4a04dd 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> > > @@ -696,6 +696,7 @@ cpsw_port1: port@1 {
> > >  				label = "port1";
> > >  				phys = <&phy_gmii_sel 1>;
> > >  				mac-address = [00 00 00 00 00 00];
> > > +				ti,syscon-efuse = <&wkup_conf 0x200>;
> > 
> > Sorry, how does this work? wkup_conf is not marked as "syscon" compatible?
> 
> Sorry I failed to realize that. So this will also require adding a
> custom property similar to:
> https://github.com/torvalds/linux/commit/cc1965b02d6cb18d9220dae06f7e2e0b0ebbea48
> followed by adding a new sub-node within wkup_conf corresponding to the
> MAC Address CTRL_MMR registers.
> 
> Thank you for reviewing the patch and pointing this out.

I have posted the v2 patch at:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20240404081845.622707-1-s-vadapalli@ti.com/
verifying that the MAC Address present in the CTRLMMR_MAC_IDx registers
is assigned to the network interface corresponding to CPSW3G MAC Port 1.

Regards,
Siddharth.