Received-SPF: pass (google.com: domain of linux-kernel+bounces-131031-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 4 Apr 2024 07:27:47 +0000
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Yong Zhi <yong.zhi@intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
	Dan Scally <djrscally@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Tianshu Qiu <tian.shu.qiu@intel.com>, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Hyungwoo Yang <hyungwoo.yang@intel.com>,
	Rajmohan Mani <rajmohan.mani@intel.com>,
	Vijaykumar Ramya <ramya.vijaykumar@intel.com>,
	Samu Onkalo <samu.onkalo@intel.com>,
	Jouni =?iso-8859-1?Q?H=F6gander?= <jouni.hogander@intel.com>,
	Jouni Ukkonen <jouni.ukkonen@intel.com>,
	Antti Laakso <antti.laakso@intel.com>
Subject: Re: [PATCH] media: ipu-cio2: Remove unnecessary runtime PM power
 state setting
Message-ID: <Zg5Wc6DMPYBqlCFr@kekkonen.localdomain>
References: <20240325220325.1452712-1-helgaas@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240325220325.1452712-1-helgaas@kernel.org>

Hi Bjorn,

On Mon, Mar 25, 2024 at 05:03:25PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> ipu-cio2 uses generic power management, and pci_pm_runtime_suspend() and
> pci_pm_runtime_resume() already take care of setting the PCI device power
> state, so the driver doesn't need to do it explicitly.
> 
> Remove explicit setting to D3hot or D0 during runtime suspend and resume.
> 
> Remove #defines that are no longer used.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Hyungwoo Yang <hyungwoo.yang@intel.com>
> Cc: Rajmohan Mani <rajmohan.mani@intel.com>
> Cc: Vijaykumar Ramya <ramya.vijaykumar@intel.com>
> Cc: Samu Onkalo <samu.onkalo@intel.com>
> Cc: Jouni H?gander <jouni.hogander@intel.com>
> Cc: Jouni Ukkonen <jouni.ukkonen@intel.com>
> Cc: Antti Laakso <antti.laakso@intel.com>
> ---
> This code was initially added by c2a6a07afe4a ("media: intel-ipu3: cio2:
> add new MIPI-CSI2 driver").
> 
> Even at that time, the explicit power state setting should not have been
> necessary, so maybe there's a reason for it.  I have no way to test this,
> so if it *is* needed, please:
> 
>   - Add a comment about the reason and
> 
>   - Convert it to use pci_set_power_state() so the PCI core knows about the
>     change and all the required state transition delays are observed.

Thanks for the patch.

The device seems to work fine with the patch applied so I presume it wasn't
necessary to begin with.

-- 
Regards,

Sakari Ailus