Received-SPF: pass (google.com: domain of linux-kernel+bounces-131135-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <d74836a8-9e5d-4a2f-900c-90ceb66bed7b@bootlin.com>
Date: Thu, 4 Apr 2024 10:50:57 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] serial: 8250_of: Add clock_notifier
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Thomas Petazzoni
 <thomas.petazzoni@bootlin.com>, herve.codina@bootlin.com,
 christophercordahi@nanometrics.ca
References: <20240404074450.42708-1-bastien.curutchet@bootlin.com>
 <2024040455-bungee-subsidy-f5aa@gregkh>
Content-Language: en-US
From: Bastien Curutchet <bastien.curutchet@bootlin.com>
In-Reply-To: <2024040455-bungee-subsidy-f5aa@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Greg,

On 4/4/24 09:50, Greg Kroah-Hartman wrote:
> On Thu, Apr 04, 2024 at 09:44:50AM +0200, Bastien Curutchet wrote:
>> The UART's input clock rate can change at runtime but this is not
>> handled by the driver.
>>
>> Add a clock_notifier callback that updates the divisors when the input
>> clock is updated. The serial8250_update_uartclk() is used to do so.
>> PRE_RATE_CHANGE and ABORT_RATE_CHANGE notifications are ignored, only
>> the POST_RATE_CHANGE is used.
> 
> Why just this one notification?  You say they are ignored but do not say
> why.
> 

I don't need to react to PRE_RATE_CHANGE in my use case. A few bytes may
be corrupted during the rate change but it is not a problem for my
application (and I assumed that it would also be ok in many other use
cases).

>>
>> Reorder the #include to match alphabetic order.
> 
> That is not needed here, why do that now?  And "alphabetic order" is not
> an issue for tty drivers, no need to do that, but if you really want to,
> a separate patch series is good for that.

Ok sorry, I thought it was needed, I'll remove this in next iteration.


Best regards,
Bastien