Received-SPF: pass (google.com: domain of linux-kernel+bounces-131187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240402093539.184287-1-bigunclemax@gmail.com>
In-Reply-To: <20240402093539.184287-1-bigunclemax@gmail.com>
From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Thu, 4 Apr 2024 11:31:01 +0200
Message-ID: <CAPDyKFqat_wAa1zCH+VAebs4R3LodvDJ13Af5CU9xvzX6rzKTw@mail.gmail.com>
Subject: Re: [PATCH v1] mmc: sdhci-of-dwcmshc: th1520: Increase tuning loop
 count to 128
To: Maksim Kiselev <bigunclemax@gmail.com>
Cc: Drew Fustini <drew@pdp7.com>, Xi Ruoyao <xry111@xry111.site>, 
	Adrian Hunter <adrian.hunter@intel.com>, linux-mmc@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Tue, 2 Apr 2024 at 11:36, Maksim Kiselev <bigunclemax@gmail.com> wrote:
>
> Fix SD card tuning error by increasing tuning loop count
> from 40(MAX_TUNING_LOOP) to 128.
>
> For some reason the tuning algorithm requires to move through all the taps
> of delay line even if the THRESHOLD_MODE (bit 2 in AT_CTRL_R) is used
> instead of the LARGEST_WIN_MODE.
>
> Tested-by: Drew Fustini <drew@pdp7.com>
> Tested-by: Xi Ruoyao <xry111@xry111.site>
> Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>

Applied for fixes and by adding a fixes+stable tag, thanks!

Kind regards
Uffe


> ---
> Previous discussion was here:
> https://lore.kernel.org/lkml/CALHCpMhc1F5Ue7U_gsDXREHUZRVQJNYRCJxYxoNqbN=-39jf7A@mail.gmail.com/
>
>  drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 8d6cfb648096..1001b6ea1a89 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -706,6 +706,7 @@ static int th1520_execute_tuning(struct sdhci_host *host, u32 opcode)
>
>         /* perform tuning */
>         sdhci_start_tuning(host);
> +       host->tuning_loop_count = 128;
>         host->tuning_err = __sdhci_execute_tuning(host, opcode);
>         if (host->tuning_err) {
>                 /* disable auto-tuning upon tuning error */
> --
> 2.40.1
>