Received-SPF: pass (google.com: domain of linux-kernel+bounces-131202-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 4 Apr 2024 12:51:20 +0300 (EEST)
To: Lukas Wunner <lukas@wunner.de>
cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org, 
    Mahesh J Salgaonkar <mahesh@linux.ibm.com>, 
    Oliver O'Halloran <oohall@gmail.com>, LKML <linux-kernel@vger.kernel.org>, 
    linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/2] PCI: Add TLP Prefix reading into
 pcie_read_tlp_log()
In-Reply-To: <Zg50P2JcpvO8S-a7@wunner.de>
Message-ID: <cc4f4e53-22d3-b5b0-bc9d-3156bfec6652@linux.intel.com>
References: <20240403100206.4403-1-ilpo.jarvinen@linux.intel.com> <20240403100206.4403-2-ilpo.jarvinen@linux.intel.com> <Zg50P2JcpvO8S-a7@wunner.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-71238506-1712224280=:2725"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-71238506-1712224280=:2725
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 4 Apr 2024, Lukas Wunner wrote:

> On Wed, Apr 03, 2024 at 01:02:05PM +0300, Ilpo J=E4rvinen wrote:
> > pcie_read_tlp_log() handles only 4 TLP Header Log DWORDs but TLP Prefix
> > Log (PCIe r6.1 secs 7.8.4.12 & 7.9.14.13) may also be present.
> >=20
> > Generalize pcie_read_tlp_log() and struct pcie_tlp_log to handle also
> > TLP Prefix Log. The layout of relevant registers in AER and DPC
> > Capability is not identical but the offsets of TLP Header Log and TLP
>                 ^^^           ^^^
> Somehow this doesn't seem to make sense.  Is the "not" perhaps wrong here=
?

Hi Lukas,

How about changing it into plural and adding a comma:

The layouts of relevant registers in AER and DPC Capabilities are not=20
identical, but ...

Does that sound better?

> > Prefix Log vary so the callers must pass the offsets to
> > pcie_read_tlp_log().


--=20
 i.

--8323328-71238506-1712224280=:2725--