Received-SPF: pass (google.com: domain of linux-kernel+bounces-131287-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 4 Apr 2024 18:57:24 +0800
From: Pengfei Xu <pengfei.xu@intel.com>
To: syzbot <syzbot+93cdc797590ffc710918@syzkaller.appspotmail.com>
CC: <dgilbert@interlog.com>, <jejb@linux.ibm.com>,
	<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	<martin.petersen@oracle.com>, <syzkaller-bugs@googlegroups.com>,
	<pengfei.xu@intel.com>, <Alexander@wetzel-home.de>
Subject: Re: [syzbot] [scsi?] WARNING in sg_remove_sfp_usercontext
Message-ID: <Zg6HlGO8ZyRQZSUA@xpf.sh.intel.com>
References: <000000000000a6e0450614b960ac@google.com>
 <00000000000007e8290614c036a6@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <00000000000007e8290614c036a6@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2YjOVFyxSGDvTntGWR7NPydu1VfolvUWqJU6Krhe3jt+DYJR9hjS0nNxLykq?=
 =?us-ascii?Q?jsZk0DOs10t2XFMpEyiC2+tUDUJYf1t9T7fqxKrP+rnCsaoFQBSHE3NF9pXm?=
 =?us-ascii?Q?+RB3ciyjyywcRnvypssnt6vvtHqqUHdOBeC5hSA/U37G319zTPmLPGT4qT5C?=
 =?us-ascii?Q?KTLZGJPHGGY0LqQ/IaHMYwYkXI9mub6NWhu2QackRMMwj0lWL6RIotRcTYBM?=
 =?us-ascii?Q?2tnNVqC79V/rrltOHm5XyfYvj9/Odd/GNn4PmFOX7WBXBO0u0NGeXU5K3H2W?=
 =?us-ascii?Q?24cmA8CXT6FuSy4BTDvqFWhaXpUzbOTcXWibX8YxxISlnZkPRLMTI6rLz22E?=
 =?us-ascii?Q?DwM2lBmNt5ES8KdsEnWdLzkoai0zpFiFVw5zcMkDNRaM0jmIQb7NkbEiDCrR?=
 =?us-ascii?Q?+pXHLFTG5KY+xTPkjixphFnx1W5hYMH4XhSC/YUhcBn6WQaWZhMTApqrOn5l?=
 =?us-ascii?Q?S+4fHQEG+S/Upfz56ivHl0vml3+n/JSaPxfR6eoCT8UgHcm26yg/FQU/PZZl?=
 =?us-ascii?Q?MnVa8B+wsSGgltf1v5GKYXvKAoknAOtiyZ3OHfwvk5QSv8zT9tz+to3fwKOk?=
 =?us-ascii?Q?/gsMbPpYyZNgsifWoJ0lDMXbQxsVikbZh1uA/915qsNExpU/HRqe6Bl9gOXQ?=
 =?us-ascii?Q?tTh85yRw27vfh5qP1p15tov2IsLUgPEQ04xV+B3AewIBG3gUAuSIPOc8VCBw?=
 =?us-ascii?Q?HPH9Kb3M1im7HSMwN2slLvGRFOzVnPgkrhswg9nQLnyVB68m5yKkY1liV9NR?=
 =?us-ascii?Q?AgAXxxVF5nlzYyvVz1ohbVWZB4QIhWNVndT/GjEdzkOf8nYwjfYJNQla7tR1?=
 =?us-ascii?Q?PJLhlf+0YjF1y8uvZoy6HYx+SEVABOiEFa2IQ6p4snKgUV4xSu2kDoCKwhbs?=
 =?us-ascii?Q?9xCGD3oSPuBWFphTf7OEIkHoXcuX5cFVZj27r9WLAPgrvcuw04GYPwIeogU5?=
 =?us-ascii?Q?BhKtvG1yT/dXC+5uGKewAE2RpAXJukBuJ23ivq98z2y68v/k4GcRgMnvQvh/?=
 =?us-ascii?Q?IxGci0kqVQ12y3Zhyf7hDsWu0cZ+l8qSlaVTLyqI4l0wO83OMLi76ORFK7X/?=
 =?us-ascii?Q?1zFwQwfAkTTdoW9WygCuCtn8iv0jAgPKU31lsdcWTiBcqJpGOjbGWpQP0BRM?=
 =?us-ascii?Q?2UTZRpmp8KFndLFds8Y8gsAXTgOXt2tV4pvT8BIY2gLLZb/fI8lTGv4IHxqw?=
 =?us-ascii?Q?sO9MDZKYOqLnAuV45T01fiA4nNXIfr9aT7/dpiaCYVtGRvdAA6DoX2DE/fRW?=
 =?us-ascii?Q?CIWsN9SOVcU1qEQtzSuyEe2kPBFWmlOf1amo0IzT+Gfec/E9bsm3IE8wlIIi?=
 =?us-ascii?Q?+RdIeYxzw68xT24NZqHgRqWroe/70oTV4x9mO4UGfwpnuX5Bx0x0iax18guN?=
 =?us-ascii?Q?id1hSgVLtwsLzFAFuLlIf9dfjQwVNRCbT0ivM+JmOrwWH7qVvac9AQXnQQPA?=
 =?us-ascii?Q?tEpd3ulPuftDaUXcciEQrYiou4a1fmuj1HmTkmb/DHRsUftpTaVK7YbL67RF?=
 =?us-ascii?Q?MnRJgTRqvqU+3aMyxgwoDYWhkizMwqO9TR0zQV2eqJ/NFnplPYXApBBjY1yS?=
 =?us-ascii?Q?AdwOGQSoTA5+eXkHbEnqeD48wT6aLwnwQP5oN/rY?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9043a50f-a4a3-4d06-bf1e-08dc5496abda
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4844.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 11:02:08.5886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SntG3ObT9deAv6meSkqh006b+Say5LYXjtzJT+6j3iCpPJLWuXfQNwN+ovQSzGR9BL/wNRmoqOFA1w4C0O9wMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8030
X-OriginatorOrg: intel.com

cc Alexander Wetzel,

I used syzkaller and found the similar problem.

And bisected and found the related commit:
27f58c04a8f4 scsi: sg: Avoid sg device teardown race
Reverted the commit on top of v6.9-rc2, this issue was gone.

All detailed info: https://github.com/xupengfe/syzkaller_logs/tree/main/240401_231147_sg_remove_sfp_usercontext
Bisect log: https://github.com/xupengfe/syzkaller_logs/blob/main/240401_231147_sg_remove_sfp_usercontext/bisect_info.log
Kconfig(make olddefconfig): https://github.com/xupengfe/syzkaller_logs/blob/main/240401_231147_sg_remove_sfp_usercontext/kconfig_origin
v6.9-rc2 bzImage: https://github.com/xupengfe/syzkaller_logs/raw/main/240401_231147_sg_remove_sfp_usercontext/bzImage_v6.9-rc2.tar.gz
Reproduced code: https://github.com/xupengfe/syzkaller_logs/blob/main/240401_231147_sg_remove_sfp_usercontext/repro.c
Syscall reproduced steps: https://github.com/xupengfe/syzkaller_logs/blob/main/240401_231147_sg_remove_sfp_usercontext/repro.prog

I hope it's helpful and if it could be fixed.
Feel free to add the reported-by tag from me.

Best Regards,
Thanks!

On 2024-03-28 at 15:40:33 -0700, syzbot wrote:
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    a6bd6c933339 Add linux-next specific files for 20240328
> git tree:       linux-next
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=17e3ac29180000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=b0058bda1436e073
> dashboard link: https://syzkaller.appspot.com/bug?extid=93cdc797590ffc710918
> compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=14c87791180000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1013ac29180000
> 
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/7c1618ff7d25/disk-a6bd6c93.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/875519f620fe/vmlinux-a6bd6c93.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/ad92b057fb96/bzImage-a6bd6c93.xz
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+93cdc797590ffc710918@syzkaller.appspotmail.com
> 
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 24 at drivers/scsi/sg.c:2236 sg_remove_sfp_usercontext+0x3f3/0x530 drivers/scsi/sg.c:2236
> Modules linked in:
> CPU: 1 PID: 24 Comm: kworker/1:0 Not tainted 6.9.0-rc1-next-20240328-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
> Workqueue: events sg_remove_sfp_usercontext
> RIP: 0010:sg_remove_sfp_usercontext+0x3f3/0x530 drivers/scsi/sg.c:2236
> Code: 8b 36 49 8d 96 4d 01 00 00 48 c7 c7 a0 fe 4b 8c 48 c7 c1 c0 07 4c 8c 4d 89 e0 e8 d8 a3 eb ff e9 f7 fe ff ff e8 8e 9d 74 fb 90 <0f> 0b 90 e9 3f ff ff ff e8 80 9d 74 fb 48 8b 44 24 08 48 b9 00 00
> RSP: 0018:ffffc900001e7b48 EFLAGS: 00010293
> RAX: ffffffff8620cd42 RBX: 0000000000000002 RCX: ffff8880176f8000
> RDX: 0000000000000000 RSI: 0000000000000002 RDI: 0000000000000001
> RBP: 0000000000008000 R08: ffffffff8620cc7c R09: 1ffff11003fccfaf
> R10: dffffc0000000000 R11: ffffed1003fccfb0 R12: ffff888022830000
> R13: ffff888022831688 R14: ffff88801fe67d78 R15: ffff888022830148
> FS:  0000000000000000(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00000000005fdeb8 CR3: 000000000e134000 CR4: 00000000003506f0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
>  <TASK>
>  process_one_work kernel/workqueue.c:3218 [inline]
>  process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3299
>  worker_thread+0x86d/0xd70 kernel/workqueue.c:3380
>  kthread+0x2f0/0x390 kernel/kthread.c:388
>  ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
>  ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:243
>  </TASK>
> 
> 
> ---
> If you want syzbot to run the reproducer, reply with:
> #syz test: git://repo/address.git branch-or-commit-hash
> If you attach or paste a git patch, syzbot will apply it before testing.