Received-SPF: pass (google.com: domain of linux-kernel+bounces-131322-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542
Precedence: bulk
MIME-Version: 1.0
Message-Id: <6f79f3bd-e60a-484a-92b7-f6a26f845809@app.fastmail.com>
In-Reply-To: <2ffc8633-6ed8-4641-bd9f-313645dfff51@csgroup.eu>
References: <20240403080702.3509288-1-arnd@kernel.org>
 <20240403080702.3509288-19-arnd@kernel.org>
 <66a1d5f1-d9b2-402c-826d-955370288037@csgroup.eu>
 <bdcabb75-f9a5-4905-90b4-2c9c2cf0588a@app.fastmail.com>
 <2ffc8633-6ed8-4641-bd9f-313645dfff51@csgroup.eu>
Date: Thu, 04 Apr 2024 13:43:29 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Christophe Leroy" <christophe.leroy@csgroup.eu>,
 "Arnd Bergmann" <arnd@kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "Andrew Morton" <akpm@linux-foundation.org>,
 "Palmer Dabbelt" <palmer@rivosinc.com>
Cc: "Dave Hansen" <dave.hansen@linux.intel.com>,
 "Noah Goldstein" <goldstein.w.n@gmail.com>,
 "Charlie Jenkins" <charlie@rivosinc.com>
Subject: Re: [PATCH 18/34] lib: checksum: hide unused expected_csum_ipv6_magic[]
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 3, 2024, at 11:03, Christophe Leroy wrote:
> Le 03/04/2024 =C3=A0 10:58, Arnd Bergmann a =C3=A9crit=C2=A0:
>
>> On Wed, Apr 3, 2024, at 10:41, Christophe Leroy wrote:
>> Yes, I usually prefer that approach, and I think I tried it first
>> but ran into compile-time problems because csum_ipv6_magic()
>> is declared conditionally. Let me try again, maybe I misremember
>> what I did or I can remove some more #ifdef checks for this.
>
> FWIW, before replying I did a build check with pmac32_defconfig=20
> (powerpc) with CONFIG_NET removed. I was able to build=20
> lib/checksum_kunit.o and objdump shown there was no reference to=20
> csum_ipv6_magic() inside it.

Right, got it now. I was confused a bit by CONFIG_NET vs CONFIG_IPV6
given that the common definition for csum_ipv6_magic() is in
net/ipv6 but unlike other files there still gets build when IPV6
is disabled but NET remains turned on.

I've done a little more randconfig testing to verify it,
sending v2 now.

      Arnd