Received: by 2002:ab2:2441:0:b0:1f3:1f8c:d0c6 with SMTP id k1csp212753lqe; Thu, 4 Apr 2024 04:46:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWsMggfywDJvelvuWusAKH7pGOpTvFOKlgf75xOwquYizbI2O9zcSnRr8ckl1mAD3rk8dm1n9q4uzod1KnXLGodL5c3HRB2GPaI/f0xHA== X-Google-Smtp-Source: AGHT+IG+s0US6Qk2jmtO3C3QOpDyk1YbwJZ/h8fLFQzFJq30n8V1ItqOdQsZd1izCXtNEa/lSWxl X-Received: by 2002:a05:6a20:3ca1:b0:1a5:742b:8d88 with SMTP id b33-20020a056a203ca100b001a5742b8d88mr2779594pzj.3.1712231211930; Thu, 04 Apr 2024 04:46:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712231211; cv=pass; d=google.com; s=arc-20160816; b=02Ap6yLuwH6qOu52HqKPrcZm/MdSKyha7twaGfph1uIGVV16j3GIGegOk7QVjyXEjm JcKgQFL4ClSNPriTtTZ/SreKqdEtvqq/iK8hVv8mc0QAC7MvsuCj5s4t3JVk18/keeMm KtQNWPrm5cwtB+d+wLivDUoznyY+bE51AdM3uvPw7Lxwiu972sClegQFzG/BAolSLneC L01ginLw1IKFpFtRbIARFJD2WqwvRgHcmTmhv84TCbOFVY0KFBptzlyPWPyOkzmWz2Dy W357jvZ7K0TUxBzjqwjcOJyesiMxhjk291QKnsHjuXaTv0MQYS9T5IdoZ6B1XGZsnaQh +5rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=wP+VzfFW63qyysB0Bh2+zW42NqOuwVfw84JvK78B4e8=; fh=2I/ZjYm8ExPFsdgJd1PBjpupm+RBbaF6M8gVl6fVcoY=; b=LP+qYzfxxq+L7CKf0wzfSZmE0CDPhnb29kTlmvLNJETMlLtd4MAHrro6mXwOkrJcYD HnHGM1pygggwLkVryeyC8oAnGebr/8fpk6fPgNknYEyRMxC3p3MxhtYZ+ZpQPVLDYQbk OQY/qkSc3hqisfskMyhPxh0shQADsYhu0bomp/EyVvOj99fMCHRfZKLjyZUn7eKECU5T xSFQ9uuva/4yYY+u1tjzO4IXSJdGL7tDqVAtNYY3lFojIabZ4hwarOLWn9gprqQ9CMdT wR5BiqCDxGuI2l8+xNLSQKMTmZ/qYRpdGEgJ1LJCVhecsQCdMRymWEuVdNHl0WIEdEtp +q7g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-131325-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131325-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id q14-20020a65684e000000b005dd565d7626si398946pgt.900.2024.04.04.04.46.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 04:46:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-131325-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-131325-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131325-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 26C33B25F5A for ; Thu, 4 Apr 2024 11:45:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9D70784A3E; Thu, 4 Apr 2024 11:45:18 +0000 (UTC) Received: from mail78-59.sinamail.sina.com.cn (mail78-59.sinamail.sina.com.cn [219.142.78.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF9B885280 for ; Thu, 4 Apr 2024 11:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=219.142.78.59 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712231118; cv=none; b=P4X2qWKU5RoRQZA4H13eyXWh/FKlGj2NzcxlTsvG8a+RWNmOY5k7oeN/UqvhI8ufxXroteIXG4USB1qPuLBtq5DX4ulDXYC+YdBMdKWDofmu2Nqkqkxp+1cXSV+toHEngqgvn1LPmtT8d0GeWCB3jpGN+qG2OfxUjtKiV54LbFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712231118; c=relaxed/simple; bh=ylbl0xLM20RXeU86JQxIxQGnFc4IkTJwmxXrjH2ttMY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QL/L+kpaK6afUps2Y4eTAuOP3adhs+VHPfOTLIjfXlyqRp6ancyXGu0qgOJGmpmpcBXSr4tjpdfBKxgZ6mVtwZIlRCZ33EWKWN6zUB1AV2pnxDWtlNoi/MYCZwWC0uVvE7b654J5dJWxJrrXtKsDeCBkUxvUjxYJzVoY48BwRl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=219.142.78.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.88.48.253]) by sina.com (172.16.235.25) with ESMTP id 660E92BB00003139; Thu, 4 Apr 2024 19:45:02 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 70933534210418 X-SMAIL-UIID: C5660C13CBE64EE8B9A9F29231FF9B65-20240404-194502-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] WARNING: bad unlock balance in madvise_cold_or_pageout_pte_range Date: Thu, 4 Apr 2024 19:44:50 +0800 Message-Id: <20240404114450.4136-1-hdanton@sina.com> In-Reply-To: <000000000000b92a9d0615433065@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 04 Apr 2024 03:56:24 -0700 > syzbot has found a reproducer for the following issue on: > > HEAD commit: 727900b675b7 Add linux-next specific files for 20240403 > git tree: linux-next > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13764a3d180000 #syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 727900b675b7 --- x/mm/madvise.c +++ y/mm/madvise.c @@ -482,10 +482,7 @@ restart: err = split_folio(folio); folio_unlock(folio); folio_put(folio); - if (err) - continue; - start_pte = pte = - pte_offset_map_lock(mm, pmd, addr, &ptl); + start_pte = pte = pte_offset_map_lock(mm, pmd, addr, &ptl); if (!start_pte) break; arch_enter_lazy_mmu_mode(); --