Received-SPF: pass (google.com: domain of linux-kernel+bounces-131347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <5766468.DvuYhMxLoT@kreacher> <2318465.ElGaqSPkdT@kreacher> <6f950b18-4ff7-4570-957d-49b46167c12e@arm.com>
In-Reply-To: <6f950b18-4ff7-4570-957d-49b46167c12e@arm.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 4 Apr 2024 13:57:07 +0200
Message-ID: <CAJZ5v0hD=Nfk3=5gQuEKu8oq9PV6C_+7N0ZJYKkQ9OH505RpZg@mail.gmail.com>
Subject: Re: [PATCH v1 2/2] thermal: gov_step_wise: Simplify checks related to
 passive trips
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, LKML <linux-kernel@vger.kernel.org>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 4, 2024 at 1:26=E2=80=AFPM Lukasz Luba <lukasz.luba@arm.com> wr=
ote:
>
>
>
> On 4/3/24 19:12, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Make it more clear from the code flow that the passive polling status
> > updates only take place for passive trip points.
> >
> > No intentional functional impact.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > ---
> >   drivers/thermal/gov_step_wise.c |   14 ++++++--------
> >   1 file changed, 6 insertions(+), 8 deletions(-)
> >
> > Index: linux-pm/drivers/thermal/gov_step_wise.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- linux-pm.orig/drivers/thermal/gov_step_wise.c
> > +++ linux-pm/drivers/thermal/gov_step_wise.c
> > @@ -92,15 +92,13 @@ static void thermal_zone_trip_update(str
> >               if (instance->initialized && old_target =3D=3D instance->=
target)
> >                       continue;
> >
> > -             if (old_target =3D=3D THERMAL_NO_TARGET &&
> > -                 instance->target !=3D THERMAL_NO_TARGET) {
> > -                     /* Activate a passive thermal instance */
> > -                     if (trip->type =3D=3D THERMAL_TRIP_PASSIVE)
> > +             if (trip->type =3D=3D THERMAL_TRIP_PASSIVE) {
> > +                     /* If needed, update the status of passive pollin=
g. */
> > +                     if (old_target =3D=3D THERMAL_NO_TARGET &&
> > +                         instance->target !=3D THERMAL_NO_TARGET)
> >                               tz->passive++;
> > -             } else if (old_target !=3D THERMAL_NO_TARGET &&
> > -                        instance->target =3D=3D THERMAL_NO_TARGET) {
> > -                     /* Deactivate a passive thermal instance */
> > -                     if (trip->type =3D=3D THERMAL_TRIP_PASSIVE)
> > +                     else if (old_target !=3D THERMAL_NO_TARGET &&
> > +                              instance->target =3D=3D THERMAL_NO_TARGE=
T)
> >                               tz->passive--;
> >               }
> >
> >
> >
> >
>
> The patch looks good, although I got some warning while applying with
> my b4 tool:
> BADSIG: DKIM/rjwysocki.net

It's likely because it was sent from an address in the rjwysocki.net
domain, but it is perfectly fine to send "somebody else's" patches if
a replacement From: header is given.

Looks like a b4 issue to me.

> Anyway, it looks like false warning IMO.
>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

Thank you!