Received-SPF: pass (google.com: domain of linux-kernel+bounces-131357-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Elad Nachman <enachman@marvell.com>
To: Breno Leitao <leitao@debian.org>,
        "aleksander.lobakin@intel.com"
	<aleksander.lobakin@intel.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com"
	<pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "elder@kernel.org" <elder@kernel.org>,
        "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
        "linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
        "nbd@nbd.name" <nbd@nbd.name>,
        "sean.wang@mediatek.com" <sean.wang@mediatek.com>,
        "Mark-MC.Lee@mediatek.com"
	<Mark-MC.Lee@mediatek.com>,
        "lorenzo@kernel.org" <lorenzo@kernel.org>,
        Taras
 Chornyi <taras.chornyi@plvision.eu>
CC: "quic_jjohnson@quicinc.com" <quic_jjohnson@quicinc.com>,
        "kvalo@kernel.org" <kvalo@kernel.org>,
        "leon@kernel.org" <leon@kernel.org>,
        "dennis.dalessandro@cornelisnetworks.com"
	<dennis.dalessandro@cornelisnetworks.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net-next v3 2/5] net: marvell: prestera:
 allocate dummy net_device dynamically
Thread-Topic: [EXTERNAL] [PATCH net-next v3 2/5] net: marvell: prestera:
 allocate dummy net_device dynamically
Thread-Index: AQHahoZqP8FVQ8wG0EWJ9wkRDreQkrFYAftg
Date: Thu, 4 Apr 2024 11:59:35 +0000
Message-ID: 
 <BL1PR18MB42485B5BE1D65A5E4BFFAD66DB3C2@BL1PR18MB4248.namprd18.prod.outlook.com>
References: <20240404114854.2498663-1-leitao@debian.org>
 <20240404114854.2498663-3-leitao@debian.org>
In-Reply-To: <20240404114854.2498663-3-leitao@debian.org>
Accept-Language: he-IL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?bm6xj5h0/eB2hBqqtFqpNizBrGt8vWDGLOO9sQ7jDEv0VF/3FI4QOWH+0g23?=
 =?us-ascii?Q?6Z2rGtljgvODKWmOYloBWwSb+G8cHfvh80QitNpgNsILEij3eKYDZGbgQT+H?=
 =?us-ascii?Q?jZAx5vjvrn+Nm80LIUyjLL70b2w6koaDNwTEv0DQx2HKLpRukJU3hsdpOT72?=
 =?us-ascii?Q?ZM3X2Ycb7TlGYN+nlu7hGqAxp+v/3Z9FC55QtQOqYk1Jm3M7DntuY+IUEkT6?=
 =?us-ascii?Q?VSQMvRb2lTXbpgzBpPLBMt2pXb51xgUz2xR3F7L6/dJPjsf6WDzlVBZAssKG?=
 =?us-ascii?Q?dvb72zeCCyMM3gExPbqufBUWJVw5QdkiIYrhUBJfVDav0SKiTbXqbh7SVNNJ?=
 =?us-ascii?Q?jECA9GWYwxD1q/1HdUmx7CIiePA6CCImVH2pikXhdXTN8rz8Rcypzl9p2QTL?=
 =?us-ascii?Q?zyT6ybYLb4gEIpwm1CiqJDx+fkFT+8TA6NlTcuPT4p0rbnyuo1HbmBC8QEhT?=
 =?us-ascii?Q?G/yCNJEM2j00ucceFUNvwluuWKA0U9cx3BwvmzWspcnM4Z4ZBnkd7/qjscVy?=
 =?us-ascii?Q?n/QT1M70U77KUsa0Bj5LHARzOJQMgHJ4ZeiP9yD3FjThLlV2p553VAbcgZDy?=
 =?us-ascii?Q?7eamCetGp68vGwtC+HzXTaD/viO6/oBJdEmAg/3lHKKkNHC0CjAR/mfXLEGW?=
 =?us-ascii?Q?2euY/5OMzrfRFFQzugvdicQG0wzM7DQd8BMpmpnfv5KbGltDpcogXlM7f6+B?=
 =?us-ascii?Q?yxK4x0wXNeQXit/wj6rOe7chTZ7PWEW8MNTJuIPwLixINsg51/4K1RHk+ue4?=
 =?us-ascii?Q?E/PBMCNGFM3092+JOrvvJll66T1Aci5Pez3cVtXXqDl/iJlrGVAo8QYSExGO?=
 =?us-ascii?Q?Qur5C3hjeYeoY8rT00CGAAjTfAlSszWbp6KLvECopSTqQr7NCqVxvEi1x0N0?=
 =?us-ascii?Q?7Aa2+0wdyvdxNuiSqBe2RmWtThRQLPr8okT5aDl6xDFaz4H3+6NQuTFFdv6u?=
 =?us-ascii?Q?HAXNlGu2prfGNOBWnlxZHlKFOs5wtmDbPsWvvp5xXkuaPyXi04dOHAQd7We1?=
 =?us-ascii?Q?jUSJd1uJO8Te9NzoMSHxXvmnOTpQMfIQQTEPJnn9Yx2zPYKi9X/8QDqxQdcV?=
 =?us-ascii?Q?2Y2YrYaoTw2a9dgSUU/sF05g4Kcpa5fRpNgwjMQIFiO87AN5MxZR4LFgyoz/?=
 =?us-ascii?Q?pNqzh6qGkNemviEFQ2JWfz8VzW8sobX/nEM42Q50Eq1ZuOiJgQwO/ITny49g?=
 =?us-ascii?Q?xNJuP2W/adRBGtbvSYiIX9q0mlJTXl0KtP86MBd7xLlSupsvtTnJJeUNmRAC?=
 =?us-ascii?Q?US5dpNtUBzRTiOazlSjDlZbDSyaER2LiUGN4DX6X5bde68pOre57ZPyHxODm?=
 =?us-ascii?Q?btM71aFJagrZOletp200VmjbAeeu1rRBhmSLqApfih85iQpbWzW6hG1wfV4N?=
 =?us-ascii?Q?3NFhnCvbOwnDhftoiycHFF/+jFiO5wl7SdG3CgbWYQjXVzae27Q4FOGXDwMR?=
 =?us-ascii?Q?wtbOJ0S0w03V18sZZ9obnHx5IbM3QC1h9B8zSnTlZXxsVmxlyokEMZJZZ/1i?=
 =?us-ascii?Q?tfvBcFn25B7TK5MBlF/Z3+JTT3s+QFE+AeD5cJCvOAidVH7GaDcwb9uoZRo+?=
 =?us-ascii?Q?7IT+oRq00U3/dDzbUMoq1DKICo4QSPRC0a8JrOaHS0Foko+Ia918vQKPtayW?=
 =?us-ascii?Q?6d8COoqOnC36x7ve7ihrOEV7upVDUvVdMq8n2eduk5kO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR18MB4248.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fc65f80-31cf-439f-3411-08dc549eb244
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2024 11:59:35.1707
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ha22FzKSmSDhfu5WB4jv4fXuWk3yKFq1gY6pchfdavoYKfwpoRWharb0QevipPb91Geo87D1oBexLt8/nlXhJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB5449
X-Proofpoint-ORIG-GUID: OYo3Zh_de3VvhoORAxnAbfcn4934T1cO
X-Proofpoint-GUID: OYo3Zh_de3VvhoORAxnAbfcn4934T1cO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-04_08,2024-04-04_01,2023-05-22_02


> -----Original Message-----
> From: Breno Leitao <leitao@debian.org>
> Sent: Thursday, April 4, 2024 2:49 PM
> To: aleksander.lobakin@intel.com; kuba@kernel.org; davem@davemloft.net;
> pabeni@redhat.com; edumazet@google.com; elder@kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-mediatek@lists.infradead.org;
> nbd@nbd.name; sean.wang@mediatek.com; Mark-MC.Lee@mediatek.com;
> lorenzo@kernel.org; Taras Chornyi <taras.chornyi@plvision.eu>
> Cc: quic_jjohnson@quicinc.com; kvalo@kernel.org; leon@kernel.org;
> dennis.dalessandro@cornelisnetworks.com; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; bpf@vger.kernel.org
> Subject: [EXTERNAL] [PATCH net-next v3 2/5] net: marvell: prestera: alloc=
ate
> dummy net_device dynamically
>=20
> Prioritize security for external emails: Confirm sender and content safet=
y
> before clicking links or opening attachments
>=20
> ----------------------------------------------------------------------
> Embedding net_device into structures prohibits the usage of flexible arra=
ys in
> the net_device structure. For more details, see the discussion at [1].
>=20
> Un-embed the net_device from the private struct by converting it into a
> pointer. Then use the leverage the new alloc_netdev_dummy() helper to
> allocate and initialize dummy devices.
>=20
> [1] https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__lore.kernel.org_all_20240229225910.79e224cf-
> 40kernel.org_&d=3DDwIDAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DeTeNTLEK5-
> TxXczjOcKPhANIFtlB9pP4lq9qhdlFrwQ&m=3D8Fqw_UUg1WoXjQcCjAtMa9J6QAd
> lmUzCuk3nWriMXtYMbgBqNpdDSO4rBUanJDxw&s=3DlXBodHe9jPOjWAOTFCjnZ
> 2ZDZYoF79OGsWN38gbxhTE&e=3D
>=20
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  .../net/ethernet/marvell/prestera/prestera_rxtx.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_rxtx.c
> b/drivers/net/ethernet/marvell/prestera/prestera_rxtx.c
> index cc2a9ae794be..39d9bf82c115 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_rxtx.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_rxtx.c
> @@ -96,7 +96,7 @@ struct prestera_sdma {
>  	struct dma_pool *desc_pool;
>  	struct work_struct tx_work;
>  	struct napi_struct rx_napi;
> -	struct net_device napi_dev;
> +	struct net_device *napi_dev;
>  	u32 map_addr;
>  	u64 dma_mask;
>  	/* protect SDMA with concurrent access from multiple CPUs */ @@ -
> 654,13 +654,21 @@ static int prestera_sdma_switch_init(struct
> prestera_switch *sw)
>  	if (err)
>  		goto err_evt_register;
>=20
> -	init_dummy_netdev(&sdma->napi_dev);
> +	sdma->napi_dev =3D alloc_netdev_dummy(0);
> +	if (!sdma->napi_dev) {
> +		dev_err(dev, "not able to initialize dummy device\n");
> +		err =3D -ENOMEM;
> +		goto err_alloc_dummy;
> +	}
>=20
> -	netif_napi_add(&sdma->napi_dev, &sdma->rx_napi,
> prestera_sdma_rx_poll);
> +	netif_napi_add(sdma->napi_dev, &sdma->rx_napi,
> prestera_sdma_rx_poll);
>  	napi_enable(&sdma->rx_napi);
>=20
>  	return 0;
>=20
> +err_alloc_dummy:
> +	prestera_hw_event_handler_unregister(sw,
> PRESTERA_EVENT_TYPE_RXTX,
> +					     prestera_rxtx_handle_event);
>  err_evt_register:
>  err_tx_init:
>  	prestera_sdma_tx_fini(sdma);
> @@ -677,6 +685,7 @@ static void prestera_sdma_switch_fini(struct
> prestera_switch *sw)
>=20
>  	napi_disable(&sdma->rx_napi);
>  	netif_napi_del(&sdma->rx_napi);
> +	free_netdev(sdma->napi_dev);
>  	prestera_hw_event_handler_unregister(sw,
> PRESTERA_EVENT_TYPE_RXTX,
>  					     prestera_rxtx_handle_event);
>  	prestera_sdma_tx_fini(sdma);
> --
> 2.43.0
>=20

Acked-by: Elad Nachman <enachman@marvell.com>