Received-SPF: pass (google.com: domain of linux-kernel+bounces-131406-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 4 Apr 2024 15:23:13 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Nuno Sa <nuno.sa@analog.com>
Cc: Petr Mladek <pmladek@suse.com>, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Olivier Moysan <olivier.moysan@foss.st.com>,
	Jyoti Bhayana <jbhayana@google.com>,
	Chris Down <chris@chrisdown.name>,
	John Ogness <john.ogness@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/4] iio: backend: make use of dev_errp_probe()
Message-ID: <Zg6bsS3WMvp-nY3S@smile.fi.intel.com>
References: <20240404-dev-add_dev_errp_probe-v1-0-d18e3eb7ec3f@analog.com>
 <20240404-dev-add_dev_errp_probe-v1-3-d18e3eb7ec3f@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240404-dev-add_dev_errp_probe-v1-3-d18e3eb7ec3f@analog.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Apr 04, 2024 at 01:06:25PM +0200, Nuno Sa wrote:
> Using dev_errp_probe() to simplify the code.

..

> +	if (IS_ERR(fwnode))
> +		return dev_errp_probe(dev, PTR_ERR(fwnode),
> +				      "Cannot get Firmware reference\n");

ERR_CAST() seems quite good candidate to have here.

		return dev_errp_probe(dev, fwnode, "Cannot get Firmware reference\n");

(Assuming dev_errp_probe() magically understands that, note you may have it as
 a macro and distinguish parameter type with _Generic() or so and behave
 differently: ERR_PTR() vs. ERR_CAST(), see acpi_dev_hid_uid_match()
 implementation, but also keep in mind that it doesn't distinguish NULL/0, there
 is a patch available in the mailing list to fix that, though.)

-- 
With Best Regards,
Andy Shevchenko