Received-SPF: pass (google.com: domain of linux-kernel+bounces-131444-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Arnd Bergmann <arnd@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>,
	=?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Armin Wolf <W_Armin@gmx.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Henning Schild <henning.schild@siemens.com>,
	SungHwan Jung <onenowy@gmail.com>,
	Ai Chao <aichao@kylinos.cn>,
	Robert Joslyn <robert.joslyn@redrectangle.org>,
	Henry Shi <henryshi2018@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] platform/x86: quickstart: fix Kconfig selects
Date: Thu,  4 Apr 2024 14:34:30 +0200
Message-Id: <20240404123435.2684819-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Arnd Bergmann <arnd@arndb.de>

The new driver Kconfig entry has a typo that causes a link failure
when CONFIG_INPUT_SPARSEKMAP is disabled:

x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_notify':
quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event'
x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_probe':
quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup'

Select this symbol instead of the incorrect INPUT_SPARSE_KEYMAP.

Fixes: afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index ba88a7f259f1..21a37f1b73ab 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -647,7 +647,7 @@ config ACPI_QUICKSTART
 	tristate "ACPI Quickstart button driver"
 	depends on ACPI
 	depends on INPUT
-	select INPUT_SPARSE_KEYMAP
+	select INPUT_SPARSEKMAP
 	help
 	  This driver adds support for ACPI quickstart button (PNP0C32) devices.
 	  The button emits a manufacturer-specific key value when pressed, so
-- 
2.39.2