Received-SPF: pass (google.com: domain of linux-kernel+bounces-131448-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 04 Apr 2024 14:37:19 +0200
Message-Id: <D0BCDQS6LNJM.3IOKUKU7G06SI@fairphone.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>, "Neil Armstrong"
 <neil.armstrong@linaro.org>, "Nathan Chancellor" <nathan@kernel.org>,
 "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>,
 <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: typec: ptn36502: fix CONFIG_OF dependency
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Arnd Bergmann" <arnd@kernel.org>, "Heikki Krogerus"
 <heikki.krogerus@linux.intel.com>, "Greg Kroah-Hartman"
 <gregkh@linuxfoundation.org>, "Dmitry Baryshkov"
 <dmitry.baryshkov@linaro.org>
References: <20240404123534.2708591-1-arnd@kernel.org>
In-Reply-To: <20240404123534.2708591-1-arnd@kernel.org>

On Thu Apr 4, 2024 at 2:35 PM CEST, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_OF is disabled, TYPEC_MUX_PTN36502 causes a Kconfig warning:
>
> WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
>   Depends on [n]: HAS_IOMEM [=3Dy] && DRM_BRIDGE [=3Dy] && OF [=3Dn]
>   Selected by [y]:
>   - TYPEC_MUX_PTN36502 [=3Dy] && USB_SUPPORT [=3Dy] && TYPEC [=3Dy] && I2=
C [=3Dy] && (DRM [=3Dy] || DRM [=3Dy]=3Dn) && DRM_BRIDGE [=3Dy]
>
> It doesn't actually seem to be required here, so just avoid the warning
> with a narrower select statement and use the same condition that Nathan
> added for NB7VPQ904M.

Hi,

This has already been sent by Nathan, just hasn't been picked up yet I
guess.

https://lore.kernel.org/linux-patches/20240328-fix-ptn36502-drm_aux_bridge-=
select-v1-1-85552117e26e@kernel.org/

Regards
Luca

>
> Fixes: 9dc28ea21eb4 ("usb: typec: ptn36502: switch to DRM_AUX_BRIDGE")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/usb/typec/mux/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfi=
g
> index 4827e86fed6d..ce7db6ad3057 100644
> --- a/drivers/usb/typec/mux/Kconfig
> +++ b/drivers/usb/typec/mux/Kconfig
> @@ -60,7 +60,7 @@ config TYPEC_MUX_PTN36502
>  	tristate "NXP PTN36502 Type-C redriver driver"
>  	depends on I2C
>  	depends on DRM || DRM=3Dn
> -	select DRM_AUX_BRIDGE if DRM_BRIDGE
> +	select DRM_AUX_BRIDGE if DRM_BRIDGE && OF
>  	select REGMAP_I2C
>  	help
>  	  Say Y or M if your system has a NXP PTN36502 Type-C redriver chip