Received-SPF: pass (google.com: domain of linux-kernel+bounces-131425-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1712147341.git.vitaly@bursov.com> <03b7979666088f8d55db301c6649e0c75c727d6e.1712147341.git.vitaly@bursov.com>
In-Reply-To: <03b7979666088f8d55db301c6649e0c75c727d6e.1712147341.git.vitaly@bursov.com>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Thu, 4 Apr 2024 14:26:59 +0200
Message-ID: <CAKfTPtBCxpa0Pxx7=84dV1Mf_as6+YqcROGgGVr6Qpt-=ybrLg@mail.gmail.com>
Subject: Re: [PATCH v3 3/3] docs: cgroup-v1: clarify that domain levels are system-specific
To: Vitalii Bursov <vitaly@bursov.com>
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, 
	Juri Lelli <juri.lelli@redhat.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, 
	Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, 
	Daniel Bristot de Oliveira <bristot@redhat.com>, Valentin Schneider <vschneid@redhat.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Wed, 3 Apr 2024 at 15:28, Vitalii Bursov <vitaly@bursov.com> wrote:
>
> Add a clarification that domain levels are system-specific
> and where to check for system details.
>
> Signed-off-by: Vitalii Bursov <vitaly@bursov.com>

Acked-by: Vincent Guittot <vincent.guittot@linaro.org>

> ---
>  Documentation/admin-guide/cgroup-v1/cpusets.rst | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/cgroup-v1/cpusets.rst b/Documentation/admin-guide/cgroup-v1/cpusets.rst
> index 7d3415eea05d..f401af5e2f09 100644
> --- a/Documentation/admin-guide/cgroup-v1/cpusets.rst
> +++ b/Documentation/admin-guide/cgroup-v1/cpusets.rst
> @@ -568,7 +568,7 @@ on the next tick.  For some applications in special situation, waiting
>
>  The 'cpuset.sched_relax_domain_level' file allows you to request changing
>  this searching range as you like.  This file takes int value which
> -indicates size of searching range in levels ideally as follows,
> +indicates size of searching range in levels approximately as follows,
>  otherwise initial value -1 that indicates the cpuset has no request.
>
>  ====== ===========================================================
> @@ -581,6 +581,11 @@ otherwise initial value -1 that indicates the cpuset has no request.
>     5   search system wide [on NUMA system]
>  ====== ===========================================================
>
> +Not all levels can be present and values can change depending on the
> +system architecture and kernel configuration. Check
> +/sys/kernel/debug/sched/domains/cpu*/domain*/ for system-specific
> +details.
> +
>  The system default is architecture dependent.  The system default
>  can be changed using the relax_domain_level= boot parameter.
>
> --
> 2.20.1
>