Received-SPF: pass (google.com: domain of linux-kernel+bounces-131470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 4 Apr 2024 15:51:19 +0300 (EEST)
To: Carlos Ferreira <carlosmiguelferreira.2003@gmail.com>
cc: Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HP: wmi: added support for 4 zone keyboard rgb
In-Reply-To: <5181e9fa-2acc-4bc3-9f22-77ec519941ac@gmail.com>
Message-ID: <fde354a7-4947-e32f-4c35-8b5453257d8e@linux.intel.com>
References: <20240324180549.148812-1-carlosmiguelferreira.2003@gmail.com> <980459bc-a781-1d2b-374c-da023d601c58@linux.intel.com> <998ee474-5e0c-4877-8a95-b22b0edd7837@gmail.com> <69e28674-58b8-4e77-b4b1-033ccb7e4dce@linux.intel.com>
 <5181e9fa-2acc-4bc3-9f22-77ec519941ac@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-1823717409-1712234718=:2725"
Content-ID: <bdb796b6-f4a8-7bf1-8bd0-98d4177b0363@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1823717409-1712234718=:2725
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <b08fb703-b434-9196-93b3-c9bebfa2f57d@linux.intel.com>

On Wed, 27 Mar 2024, Carlos Ferreira wrote:

> On 3/27/24 1:05 PM, Ilpo J=E4rvinen wrote:
>=20
> > On Tue, 26 Mar 2024, Carlos Ferreira wrote:
> >=20
> >> Hi, i have changed some of the code. How does it look now?
> >>
> >> Signed-off-by: Carlos Ferreira <carlosmiguelferreira.2003@gmail.com>
> >> ---
> >=20
> > First of all, you need to make a proper submission with versioning, tha=
t=20
> > is:
> >=20
> > - Put version into the subject: PATCH v2
> > - Don't put extra stuff into changelog like the above question, if you=
=20
> > need to ask something, put your question underneath the first --- line.
> > - List the changes you made underneath the first --- line (see ML=20
> > archives for examples about formatting)
>=20
> Should i submit the v2 patch with the current state or with the changes=
=20
> suggested such as the use of the leds API?=20

Please send v3 once you've made the changes, there's no need to send=20
patches which we know to become obsolete.

> >>  drivers/platform/x86/hp/hp-wmi.c | 251 +++++++++++++++++++++++++++++-=
-
> >>  1 file changed, 241 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/h=
p/hp-wmi.c
> >> index e53660422..8108ca7e9 100644
> >> --- a/drivers/platform/x86/hp/hp-wmi.c
> >> +++ b/drivers/platform/x86/hp/hp-wmi.c
> >> @@ -27,6 +27,7 @@
> >>  #include <linux/rfkill.h>
> >>  #include <linux/string.h>
> >>  #include <linux/dmi.h>
> >> +#include <linux/bitfield.h>
> >=20
> > Try to put it earlier, these should eventually be in alphabetic order=
=20
> > (again, ordered by a separate patch, not this one).
>=20
> You mean organizing all the imports like this?
> #include <linux/acpi.h>
> #include <linux/bitfield.h>
> #include <linux/dmi.h>
> #include <linux/hwmon.h>
> #include <linux/init.h>
> #include <linux/input.h>
> #include <linux/input/sparse-keymap.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/platform_profile.h>
> #include <linux/rfkill.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> #include <linux/types.h>

Yes.

If adding to a non-sorted list, the include should be placed before any=20
entries that are alphabetically after it but providing another patch=20
to sort them is of course even better than that.

--=20
 i.
--8323328-1823717409-1712234718=:2725--