Received-SPF: pass (google.com: domain of linux-kernel+bounces-131552-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 4 Apr 2024 16:06:00 +0200
From: Gregor Herburger <gregor.herburger@ew.tq-group.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Dimitri Fedrau <dima.fedrau@gmail.com>,
	Stefan Eichenberger <eichest@gmail.com>, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux@ew.tq-group.com,
	alexander.stein@ew.tq-group.com
Subject: Re: Re: [PATCH] net: phy: marvell-88q2xxx: add support for Rev B1
 and B2
Message-ID: <Zg6zyJ8gMcwTiSOC@herburgerg-w2>
References: <20240403-mv88q222x-revb1-b2-init-v1-1-48b855464c37@ew.tq-group.com>
 <Zg1gycEDL4llYrjI@shell.armlinux.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Zg1gycEDL4llYrjI@shell.armlinux.org.uk>

Hi Russell,

On Wed, Apr 03, 2024 at 02:59:37PM +0100, Russell King (Oracle) wrote:
> I think a helper would be useful to write these sequences, rather than
> writing the same code several times:

Ok. Will add it to the next version.

> 
> static int mv88q2xxx_write_mmd_vals(struct phy_device *phydev,
> 				    const struct mmd_val *vals, size_t len)
> {
> 	int ret;
> 
> 	for (; len; vals++, len--) {
> 		ret = phy_write_mmd(phydev, vals->devad, vals->regnum,
> 				    vals->val);
> 		if (ret < 0)
> 			return ret;
> 	}
> 
> 	return 0;
> }
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/