Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp74869lqp; Thu, 4 Apr 2024 07:28:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW3QS1E8Y9H7fbjvIylWhJyx0DMRlbQtC9uQ8+SuwCeKrnOLsb98IKlhUVwoo+NFs4IamS3Z13MkSZrqmSzqAo//AMI3nw0v6S5idwm3g== X-Google-Smtp-Source: AGHT+IFP+J65c3p4yslrgLBWWNdSQ07AsKvAKt8FAQt614VCFrAIuFAhssjO/NmZcfUoJ//lI/9F X-Received: by 2002:a05:6808:1207:b0:3c3:de8e:5411 with SMTP id a7-20020a056808120700b003c3de8e5411mr2353861oil.38.1712240913046; Thu, 04 Apr 2024 07:28:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712240913; cv=pass; d=google.com; s=arc-20160816; b=mzn4R6onmlbPvFdvFGjhVGvSAnPeYXzcmhEelBgKmf5Z7RUVZk9AR3hYbzsPl9y3hu kPhBb5wBF0ulwDP8Rgrro7JXXeK/60N0KlKcbptQqGWyXByOl5F7FlZl0kbTRlMlb7gd 0jKQIh7wXKi87pNDau3vjrjau9qJHFArLR/UMqEIpgJScIB4z1S2UPHLbhAUnrBXtziF SVyME3tJmlWadUQcZ27FAr6NrZYd5FefjWnBI2Iw0fMZsW0x/BRot4fIGM0p5IfUnxsn D8b95gD5I4/HkIcvvpt+adzyIydlugcqizht7b82DauYpNrzWAsCamrLxVko5PYIlKDt xZGw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=BpmrQpItgEfZyg9zOQyLw/szytnUmTR8u0ANGhikdN0=; fh=WmcgMQCPoWUzu82qWhP6XSOAfECeRD4l1sKpLghcVAg=; b=oCx+ektdgniksVS55U7qKpmNX2hayIg4CDwHJSTuu2525o9erWqCzCEPu+Fw7H0jAx reZHNGRMe9TE9nMgLwwYpZFTn0YjO43GAlvFSwO8vvMUcu+YmYNl5wgIDRw7G5cjCFfH CenqZhumSADR7d9/rohNewhFc4sHXzohGpp2exJtmLKA+AIjFPX42/RkpIcS5DhD1itx HY//IY0lwK4KAibkCDHbPH2E6j158uCemj2jwuXaBKaEudvb0k7uxAgzpmHxFBeHuCRo FSGmF/yZZvFOP9EuA9s7OixOPyAk7TsuEj+1nPWg3dCHbl/VQFWogytq8hHdUj8A8tRZ LY4w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Gnq5wT+1; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-131611-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131611-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id l6-20020a05622a050600b004313f52bc18si16848565qtx.139.2024.04.04.07.28.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 07:28:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-131611-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Gnq5wT+1; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-131611-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131611-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C72601C2A7DF for ; Thu, 4 Apr 2024 14:25:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 42F1E129E80; Thu, 4 Apr 2024 14:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Gnq5wT+1" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF681272B4 for ; Thu, 4 Apr 2024 14:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712240655; cv=none; b=Qq1lYvffeSGuQelcpHrDeCMs66cAX3ngpLQNP4JOJLFJiYdqjv8AN/+DBuYtXH4RhucLSsFovGcIPTJnUBEx4TMnlBWSiOJS0cKz5HMYKCHZ3aBnEwAC9foC72YmjngDQNkwqBcMOs/MqKs0wRE5xazTaCVVgl+cRJDxaLBnFJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712240655; c=relaxed/simple; bh=1jlQruCFmv12qjXpwkFvj8PTdCWXAotqr8f5Rmk+4ls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AFSNj85/rp4pytA1vll5S4i7jd0FNedqe1ffSwrhpNMPtpx+xvp6nPBS3J13sxSIpzHLJU36p3C5xiARe7OoavxhaCEyqRT7IU4pjXiu3vSmLEFI0Mrv3DuMaUqJ4xJz4zX/hANM1LBD3IHaeSM9WhkvVWf4jDFtFXZFdUN3l98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Gnq5wT+1; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712240654; x=1743776654; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1jlQruCFmv12qjXpwkFvj8PTdCWXAotqr8f5Rmk+4ls=; b=Gnq5wT+1TN65rcrtQXWghTPIp35oqho+87Tt8wwNCGPUM6FAkVgQIC6E KGb0E+U3UjB0Nl1vNJkxVQ+SQ0v19jdtfvJiOGKqHuUoXVyN96dIHsFvU HKaqdngxAnoub7ckx+CkkwYNqRCaYR7gPHY1SXuBm5lGlsWUePf9Fx8wb l2tpjp4kzedanrp3GyB5rwruLRh1CAhEjKIhdnO7fBxn4ChzjE3AX3SSM t4w7D0C5FsV3alSmH3h0EbGkmKLkeuVfVfEPJI2hm8Wdt0RkoMKdnKB5+ 6VKkSk2pqoEIO3+E/g3RwlOnXLxYLE1YvNof9RKDJCp0N6LCZb1lrFlZn g==; X-CSE-ConnectionGUID: yyV1nYM0QUW3PFArTViBMw== X-CSE-MsgGUID: +daueu0mSO6GKzaoDCRVDQ== X-IronPort-AV: E=McAfee;i="6600,9927,11034"; a="7419209" X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="7419209" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 07:24:13 -0700 X-CSE-ConnectionGUID: 32kfjI7MSo2qz3NCyCXgcA== X-CSE-MsgGUID: eYVrfot2SYaOii9CbuCtlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="23298296" Received: from vzaharie-mobl.amr.corp.intel.com (HELO [10.209.26.243]) ([10.209.26.243]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 07:24:12 -0700 Message-ID: <8c49cc6b-f08f-4c2c-aabb-5cc164a1bae5@intel.com> Date: Thu, 4 Apr 2024 07:24:11 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] x86/xen: Enumerate NX from CPUID directly To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Dave Hansen , linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, x86@kernel.org, bp@alien8.de References: <20240403153508.7328E749@davehans-spike.ostc.intel.com> <20240403153514.CC2C9D13@davehans-spike.ostc.intel.com> <67938940-a7b9-4a75-883e-cc49c6097fcc@suse.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <67938940-a7b9-4a75-883e-cc49c6097fcc@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/4/24 03:44, Jürgen Groß wrote: >> @@ -1306,6 +1306,21 @@ static void __init xen_domu_set_legacy_f >>     extern void early_xen_iret_patch(void); >>   +/* >> + * It is too early for boot_cpu_has() and friends to work. >> + * Use CPUID to directly enumerate NX support. >> + */ >> +static inline void xen_configure_nx(void) >> +{ >> +    bool nx_supported; >> +    u32 eax = 0; > > I'd prefer to name this variable edx. > >> + >> +    get_cpuid_region_leaf(0x80000001, CPUID_EDX, &eax); Heh. That's a nice way to say it. :) I'll fix it up.