Received-SPF: pass (google.com: domain of linux-kernel+bounces-131644-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <091f53a0-4921-46c8-987a-3b11a499e46f@gmx.de>
Date: Thu, 4 Apr 2024 16:45:49 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86: quickstart: fix Kconfig selects
To: Arnd Bergmann <arnd@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Henning Schild
 <henning.schild@siemens.com>, SungHwan Jung <onenowy@gmail.com>,
 Ai Chao <aichao@kylinos.cn>, Robert Joslyn <robert.joslyn@redrectangle.org>,
 Henry Shi <henryshi2018@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240404123435.2684819-1-arnd@kernel.org>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <20240404123435.2684819-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:OsAq2A0ZZXM=;fse40cX9dYkNcfET9Da8iPzm9DO
 yAhnjkLyyRe6Dymh9q1jegZ0G5WDgXjill2yepsl/zMWltNUZ2nJQQHvMuMbz2zoFniEWVHpA
 /i8tkk+b1Dlbre7q2TgAXXnYBMzjx57lqDvd8I38pn6q+9F7f8kH4aCzgLXTbFYa03v6RgXql
 2qtj/uV29AdGe8dm9aOp2A2SeRs69chLQ4u26Tdk7VQVkMx6qYhkfm0ZyEfyVRRoLDTWWCW8/
 oUecoNkiyf/tcjRhk4W0LCRkCxVq6fnQtGpvR4VIiT437b9wRzkroWU3aVJK2Ocj1F9bx/ICb
 LDqWcX1zuQrrmQj8MctEoQk8m5kndd8s45dyyhtIOOOH07i92Bu4SlUa8LM7E2LWnWpyTZgDv
 O/MPd11NZNzleHKZX0PLlpphZuFc6I7i2XADMjTk03LZpK3Y2uZQI8KlU34FKWUtYqOQkJ5Wk
 mYJa2mev6I2+t6vu16su/6bhoIirPzNmUK2D5UA0H9sjdFAY5UVTNeSNyvz2F5GxPiaqXD0M4
 p6xaIlqfSK3ppjNN3aNij25+es8LjrkX96xrpB9C96CUwOPkbMbrIwIPGNqj3ZYkKqztTgEs1
 bNw+4JmLymnPo9o8nlW9BEwuuuuYZhNZgNrjjgcBzWSxSJ3R1o4QBdrvS78vdBGbSl9j00isI
 YxQkvYN7e0OXLX0j5iq1hFTFvVH3nd4rFgA+2AU7K6SbmCder8OVotqVwRnn0m3ItYj3dbEtm
 zXyiYCzVjbHLnbFJNB9O/H81xhyCvfsQH9B41W/0kirqda283mmslzSCDQnkgg192nGXeFaUz
 S2U6/yw/CaRreAVCaW6GdnUVjpEjyu+Yn/IRz7Wwa90w4=

Am 04.04.24 um 14:34 schrieb Arnd Bergmann:

> From: Arnd Bergmann <arnd@arndb.de>
>
> The new driver Kconfig entry has a typo that causes a link failure
> when CONFIG_INPUT_SPARSEKMAP is disabled:
>
> x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_notify':
> quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event'
> x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_probe':
> quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup'
>
> Select this symbol instead of the incorrect INPUT_SPARSE_KEYMAP.
>
> Fixes: afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/platform/x86/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index ba88a7f259f1..21a37f1b73ab 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -647,7 +647,7 @@ config ACPI_QUICKSTART
>   	tristate "ACPI Quickstart button driver"
>   	depends on ACPI
>   	depends on INPUT
> -	select INPUT_SPARSE_KEYMAP
> +	select INPUT_SPARSEKMAP
>   	help
>   	  This driver adds support for ACPI quickstart button (PNP0C32) devices.
>   	  The button emits a manufacturer-specific key value when pressed, so

Reviewed-by: Armin Wolf <W_Armin@gmx.de>