Received-SPF: pass (google.com: domain of linux-kernel+bounces-131657-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <9f91388faee750e16021f2c0544e7a158a16202b.camel@gmail.com>
Subject: Re: [PATCH 3/4] iio: backend: make use of dev_errp_probe()
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Nuno Sa
	 <nuno.sa@analog.com>
Cc: Petr Mladek <pmladek@suse.com>, Jonathan Cameron <jic23@kernel.org>, 
 Lars-Peter Clausen <lars@metafoo.de>, Olivier Moysan
 <olivier.moysan@foss.st.com>, Jyoti Bhayana <jbhayana@google.com>, Chris
 Down <chris@chrisdown.name>, John Ogness <john.ogness@linutronix.de>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>,  linux-kernel@vger.kernel.org,
 linux-iio@vger.kernel.org
Date: Thu, 04 Apr 2024 16:58:27 +0200
In-Reply-To: <Zg6bsS3WMvp-nY3S@smile.fi.intel.com>
References: <20240404-dev-add_dev_errp_probe-v1-0-d18e3eb7ec3f@analog.com>
	 <20240404-dev-add_dev_errp_probe-v1-3-d18e3eb7ec3f@analog.com>
	 <Zg6bsS3WMvp-nY3S@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-04-04 at 15:23 +0300, Andy Shevchenko wrote:
> On Thu, Apr 04, 2024 at 01:06:25PM +0200, Nuno Sa wrote:
> > Using dev_errp_probe() to simplify the code.
>=20
> ...
>=20
> > +	if (IS_ERR(fwnode))
> > +		return dev_errp_probe(dev, PTR_ERR(fwnode),
> > +				=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Cannot get Firmware reference\n");
>=20
> ERR_CAST() seems quite good candidate to have here.
>=20
> 		return dev_errp_probe(dev, fwnode, "Cannot get Firmware
> reference\n");
>=20
> (Assuming dev_errp_probe() magically understands that, note you may have =
it as
> =C2=A0a macro and distinguish parameter type with _Generic() or so and be=
have
> =C2=A0differently: ERR_PTR() vs. ERR_CAST(), see acpi_dev_hid_uid_match()
> =C2=A0implementation, but also keep in mind that it doesn't distinguish N=
ULL/0,
> there
> =C2=A0is a patch available in the mailing list to fix that, though.)
>=20

Do we care that much for going with that trouble? I understand like this we=
 go
PTR_ERR() to then comeback to ERR_PTR() but this for probe() which is not a
fastpath. So perhaps we could just keep it simple?

- Nuno S=C3=A1=20