Received-SPF: pass (google.com: domain of linux-kernel+bounces-131664-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f6d171499b622b463a174ce56fabc40c1e732bf9.camel@gmail.com>
Subject: Re: [PATCH 0/4] dev_printk: add dev_errp_probe() helper
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Nuno Sa
	 <nuno.sa@analog.com>, Andi Shyti <andi.shyti@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>, Jonathan Cameron <jic23@kernel.org>, 
 Lars-Peter Clausen <lars@metafoo.de>, Olivier Moysan
 <olivier.moysan@foss.st.com>, Jyoti Bhayana <jbhayana@google.com>, Chris
 Down <chris@chrisdown.name>, John Ogness <john.ogness@linutronix.de>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>,  linux-kernel@vger.kernel.org,
 linux-iio@vger.kernel.org
Date: Thu, 04 Apr 2024 17:03:53 +0200
In-Reply-To: <Zg6Z51uebr2dWLq2@smile.fi.intel.com>
References: <20240404-dev-add_dev_errp_probe-v1-0-d18e3eb7ec3f@analog.com>
	 <Zg6Z51uebr2dWLq2@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-04-04 at 15:15 +0300, Andy Shevchenko wrote:
> +Cc: Andi
>=20
> On Thu, Apr 04, 2024 at 01:06:22PM +0200, Nuno Sa wrote:
> > This series adds a dev_errp_probe() helper. This is similar to
> > dev_err_probe() but for cases where an ERR_PTR() is to be returned
> > simplifying patterns like:
> >=20
> > 	dev_err_probe(dev, ret, ...);
> > 	return ERR_PTR(ret)
>=20
> What about ERR_CAST() cases?

In theory not really needed (I think) but see my reply to the other patch.
>=20
> > The other three patches are adding users for it. The main motivator for
> > this were the changes in the commit ("iio: temperature: ltc2983: conver=
t
> > to dev_err_probe()"). Initially I just had a local helper [1] but then
> > it was suggested to try a new, common helper. As a result, I looked for
> > a couple more users.
> >=20
> > I then move into dev_errp_probe() [2] but it was then suggested to sepa=
rare
> > the patch series so we have onde dedicated for the printk helper.
> >=20
> > [1]:
> > https://lore.kernel.org/all/20240301-ltc2983-misc-improv-v3-1-c09516ac0=
efc@analog.com/
> > [2]:
> > https://lore.kernel.org/all/20240328-ltc2983-misc-improv-v4-0-0cc428c07=
cd5@analog.com/
>=20
> Have you seen mine?
>=20
> 20220214143248.502-1-andriy.shevchenko@linux.intel.com
>=20
> (Note, I'm pretty much fine and thankful that you take care of this)
>=20

Ups nope... I very prefer your naming :). I can take care of this only if y=
ou
don't intend to continue with your series. You sent it first so... :)

- Nuno S=C3=A1