Received-SPF: pass (google.com: domain of linux-kernel+bounces-131680-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b5ad9ab4e1785266fbf9f9b9e68b41bec95e5820.camel@irl.hu>
Subject: Re: [PATCH v3] platform/x86: ideapad-laptop: switch platform
 profiles using thermal management key
From: Gergo Koteles <soyer@irl.hu>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
  Ike Panhc <ike.pan@canonical.com>,
  Hans de Goede <hdegoede@redhat.com>,
  Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Thu, 04 Apr 2024 17:05:29 +0200
In-Reply-To: <45f12590-4f79-4875-a497-cbb1ac3deb38@linaro.org>
References:
	  <7c358ad8dd6de7889fa887954145a181501ac362.1712236099.git.soyer@irl.hu>
	 <45f12590-4f79-4875-a497-cbb1ac3deb38@linaro.org>
Autocrypt: addr=soyer@irl.hu; prefer-encrypt=mutual;
 keydata=mDMEZgeDQBYJKwYBBAHaRw8BAQdAD5oxV6MHkjzSfQL2O8VsPW3rSUeCHfbx/a6Yfj3NUnS0HEdlcmdvIEtvdGVsZXMgPHNveWVyQGlybC5odT6ImQQTFgoAQRYhBLSYvEYEgjzzEMQCqgtEJzXf/1IRBQJmB4NAAhsDBQkFo5qABQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEAtEJzXf/1IRmdYA/0bE1BX7zOGKBgCa1DwzH2UHXawSKLpptADvI/ao6OOtAP4+wYgpR0kWR28lhmkRTpzG/+8GiMWsT60SV2bz9B7sCbg4BGYHg0ASCisGAQQBl1UBBQEBB0CPo8ow/E97WYtaek9EsLXvsvwpBsjWLq5mMOgJL/ukCwMBCAeIfgQYFgoAJhYhBLSYvEYEgjzzEMQCqgtEJzXf/1IRBQJmB4NAAhsMBQkFo5qAAAoJEAtEJzXf/1IRklEA/ipTfAI/onzNwZIp9sCdnt0bLhR5Oz8RD/FpbrJV1v7eAP0c/C6NQPDPWbQpobBR0pf1eTjWXjjr1fj2jxSvWbMRCw==
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi Daniel,

On Thu, 2024-04-04 at 15:27 +0200, Daniel Lezcano wrote:
> > Cycling is done through modulo.
> >=20
> > Quick and dirty example:
> >=20
> > static int profiles[] =3D {
> > 	PLATFORM_PROFILE_LOW_POWER,
> > 	PLATFORM_PROFILE_BALANCED,
> > 	PLATFORM_PROFILE_PERFORMANCE
> > };
> >=20
> > static int current_profile_index =3D 0;
> >=20
> > static void dytc_profile_cycle(struct ideapad_private *priv)
> > {
> > 	current_profile_index++
> >=20
> > 	current_profile_index =3D
> > 		current_profile_index % ARRAY_SIZE(profiles);
> >=20
> > 	dytc_profile_set(&priv->dytc->pprof,
> > 			profiles[current_profile_index]);
> >=20
> > 	platform_profile_notify();
> > }
> >=20

Thanks for your suggestions. I thought about it.
It would make this module complicated, but something like this fits
well in the platform_profile module.
I will implement the cycle there in v4.

Best regards,
Gergo