Received-SPF: pass (google.com: domain of linux-kernel+bounces-131714-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 04 Apr 2024 18:22:54 +0300
Message-Id: <D0BFWIX9KZIQ.191P9DWKCSHSX@kernel.org>
Cc: <linux-integrity@vger.kernel.org>, "Heiko Carstens" <hca@linux.ibm.com>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] char: tpm: handle HAS_IOPORT dependencies
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Arnd Bergmann" <arnd@kernel.org>, "Niklas Schnelle"
 <schnelle@linux.ibm.com>, "Peter Huewe" <peterhuewe@gmx.de>
References: <20240404105840.3396821-1-schnelle@linux.ibm.com>
 <20240404105840.3396821-2-schnelle@linux.ibm.com>
 <95a63afe-ccd7-4551-86af-00b7fb0d8ff9@app.fastmail.com>
In-Reply-To: <95a63afe-ccd7-4551-86af-00b7fb0d8ff9@app.fastmail.com>

On Thu Apr 4, 2024 at 2:17 PM EEST, Arnd Bergmann wrote:
> On Thu, Apr 4, 2024, at 12:58, Niklas Schnelle wrote:
> > diff --git a/drivers/char/tpm/tpm_infineon.c b/drivers/char/tpm/tpm_inf=
ineon.c
> > index 9c924a1440a9..99c6e565ec8d 100644
> > --- a/drivers/char/tpm/tpm_infineon.c
> > +++ b/drivers/char/tpm/tpm_infineon.c
> > @@ -26,7 +26,9 @@
> >  #define	TPM_MAX_TRIES		5000
> >  #define	TPM_INFINEON_DEV_VEN_VALUE	0x15D1
> >=20
> > +#ifdef CONFIG_HAS_IOPORT
> >  #define TPM_INF_IO_PORT		0x0
> > +#endif
> >  #define TPM_INF_IO_MEM		0x1
>
> I think hiding this definition in this version of a patch
> results in a build failure because of the assignment that
> you are not stubbing out:
>
>         /* read IO-ports through PnP */
>         if (pnp_port_valid(dev, 0) && pnp_port_valid(dev, 1) &&
>             !(pnp_port_flags(dev, 0) & IORESOURCE_DISABLED)) {
>                 tpm_dev.iotype =3D TPM_INF_IO_PORT;
>
> I don't know what changed since the earlier versions I tested,
> or if I just missed it, but I think you either have to remove
> the #ifdef above or add another one in tpm_inf_pnp_probe().
>
>     Arnd

Thanks for the remark. I placed the current patch to my master branch
which is not too critical ('next' is mirrored to linux-next) if anyone
wants to try it out:

git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git

I can repeal and replace it with a newer one later on.

BR, Jarkko