Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp162019lqp; Thu, 4 Apr 2024 09:30:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXOCFDCGDYbPTD7JN98lXS0DmH13DcP2ihdj5gJCNfuaTRSmJIvccOOtHH+DX9uwSuM7MF6ifzGTby7ltz4bVM0vgN0+8SI9YweumcNJw== X-Google-Smtp-Source: AGHT+IH8tggRiDZ+/hX1ahmK1aJ6+/creV2rtG6zE9XWvWae335cZkjzkwc9DIirzCgq40nKbaqO X-Received: by 2002:a17:906:4acb:b0:a51:946a:2d97 with SMTP id u11-20020a1709064acb00b00a51946a2d97mr917900ejt.47.1712248219879; Thu, 04 Apr 2024 09:30:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712248219; cv=pass; d=google.com; s=arc-20160816; b=qi6Hqr/3i/l1cCxupSVVvzua7t0E2vpizxzZrcCZwXDYB7dEX+iSg6OLSAoTxCwytH T9+TvabTQHIPV0bNy8PL2BkK/rkdgYmKSBGRw9hTL/PALA6oLB+XpazsbyRizTBPA2/L G0OgClRCPq/iC4wIFQb+8AhljPS1Y308nHzIP8KccE+OyvIyDO6v8JtSw8ttA4Rod1AF jUO0hPyZnVXOVTsLYdaefjjuoneeeEsWuFLVr1pZPsnnfzj2TH3iT+J0RGi7+ZV0S5Ei /tKf63AmoBTE7q0iG58xu0QZP356DZ3+52RxgRdJv65o6nqm+9uzuEmYdw958LHC8BQe Pe7Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=a9DlMTs5EIgsrsDd9bTRf6z4H/lq31trEsawS+rxMeY=; fh=fj0j4bC/diY0FXZwwDvz70my0F0Kd10Bdb+hTSX6jbo=; b=FoHfyo7K+JLiBzgazAIPc/rIQJVgY+MKtNIGB3+4gOz7MWcCdjPnFLJAR3VF/OSLS0 IZFD+r0D349ezCrsKGDFq+c7lio5NWciK7/8fH0sVJXLMJCdhJkCQyQe/BEq00ocfnac dhYyVgJaeRbFQEDCykCuIviOmZOvc6+PWtyMM20VpR26WL9eB3ZAhoFH4vVWvNxUq3vT +5CQ/F4bXotqBrV6ADh0nMNn0SDmZfy5ehD/GDyn2swYy95ZqtTAxfK+JuRHU/fPWsni mrdfaVcT376J/fLczhEuZDacvy+WHMoIlGS33lLy41tf0Bwdpc2AP+8S7wSmXutOPtAV Ro7A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="grUK/kSz"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-131815-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131815-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ay3-20020a170906d28300b00a4673747925si7769085ejb.506.2024.04.04.09.30.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 09:30:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-131815-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="grUK/kSz"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-131815-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131815-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 717571F29BD2 for ; Thu, 4 Apr 2024 16:30:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CF3AB12BF04; Thu, 4 Apr 2024 16:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="grUK/kSz" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F03A12CDAA for ; Thu, 4 Apr 2024 16:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712248202; cv=none; b=Zg32dGEYMf+KVTvFCjP71Oz18B6NoT9eDR3reEZKfoAt+BfzLEp0xK8nYazL4Z2AAXRYIwdLXQzLw8/2INSsQYBjpR4wE4spMn6JtTKETogTB8Qk0GXwMcaB5yCC7qOMS0wU+Vk7ZiBYlZI17h7KftkXsT3UkDEFHbvz6D+2kyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712248202; c=relaxed/simple; bh=ukPoBp5kG4sTXH505ujluCr/3o8JRDYY6pW8AP2EKww=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pJq734QyhGVSLSAvR6UvFQnIMUTGqU4MOPG8RH/uKrQ2Zli7xQR5zE2uN9UwGfjH3fybZE4eESXgMcl4zHealIAS1ebJr30xsYB+GtBIZYaEx5xAqMlDHz2aDvU8Zn9dkX2YD8Jg29N7xUyYWtqv3CLk2Z2Ne2jLLyehCJvkdN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=grUK/kSz; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712248202; x=1743784202; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ukPoBp5kG4sTXH505ujluCr/3o8JRDYY6pW8AP2EKww=; b=grUK/kSz3CQTe+E0oLTGLt4Yi51MK/65/pAiNK3kLf1llIv2Gpp0gfo2 2AzyqvkN/sQIkdjs7W7jC384DLdOlZbrultjNS5xsD6n7BwAdl6YwbTc5 ohgete3wx9OugtU8cK1FgT0gwVDX0G283p5qdxWz5sZpSl6CIlgzDeUdD M0hWntNzkX1FLSzUJatboTanT/hlEiL063mBvno2dZYHTiHCC/S8fr7MP zt3/ShZwZO3fDk3olcTtjQBUU7kRXMFeD5NQLQ6tajmkdby0hqnWfSJQr R3zvYkpZa4vCwCArZfU0i1rbs9cjvV9NiT3JMUiS/TgGXGBNpPEMp/Jdg w==; X-CSE-ConnectionGUID: FFGHCLdqQkqROG9UlTWA2g== X-CSE-MsgGUID: 4U2S44mgSDq7QSYb2tNMxg== X-IronPort-AV: E=McAfee;i="6600,9927,11034"; a="18980418" X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="18980418" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 09:30:01 -0700 X-CSE-ConnectionGUID: UWpLLerRQsGW1q6CdoY/uQ== X-CSE-MsgGUID: x11hElgqQQGgBu+YYs7scw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="23494100" Received: from vzaharie-mobl.amr.corp.intel.com (HELO [10.209.26.243]) ([10.209.26.243]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 09:29:59 -0700 Message-ID: <9af9094e-f8f6-4303-880b-8576cf51b7e4@intel.com> Date: Thu, 4 Apr 2024 09:29:59 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] x86/mm/pae: Align up pteval_t, pmdval_t and pudval_t to avoid split locks To: Brian Gerst , Ingo Molnar Cc: Javier Pello , linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" References: <20240401185451.6897208962d3fc47a12ffb5a@otheo.eu> <20240401185712.a80deeb2fddeded0ad42cc04@otheo.eu> <8ee463af-fdbf-4514-bb6e-bf2fd61fbc06@intel.com> <20240402192314.a9b4e05637444314f47557e4@otheo.eu> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/4/24 08:36, Brian Gerst wrote: >> It creates extra constraints on stack layout that wasn't there before, >> so it can only be an invariant if the compiler can reorder variables, >> or make the stack layout worse (introducing more holes). > For the record, stack alignments are not rare. > > objdump -dr vmlinux | grep "and.*,%.sp$" | wc -l > > 64-bit defconfig: 646 > 32-bit defconfig: 449 It's not about stack alignment for me. The bigger question is: are we going to *maintain* the 32-bit code base to keep it free of split locks. It's not even just a question of how many more of these are lurking today. Any future code that (for instance) checks system_has_cmpxchg64() and then goes to do something fancy on the stack, or with structure members that aren't carefully aligned will need maintenance. Sean is basically saying, "Please keep this feature so that it's easy to find these on 32-bit and maintain the code base to preserve performance". That's a perfectly reasonable argument, but only if we decide that it's worth maintaining the 32-bit code base in this way.