Received-SPF: pass (google.com: domain of linux-kernel+bounces-131841-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 4 Apr 2024 09:41:37 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
 <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
 <richardcochran@gmail.com>, <netdev@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next 2/2] net: phy: micrel: lan8814: Add support for
 PTP_PF_PEROUT
Message-ID: <20240404094137.51b1397e@kernel.org>
In-Reply-To: <20240404080115.450929-3-horatiu.vultur@microchip.com>
References: <20240404080115.450929-1-horatiu.vultur@microchip.com>
	<20240404080115.450929-3-horatiu.vultur@microchip.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 4 Apr 2024 10:01:15 +0200 Horatiu Vultur wrote:
> +	if (period_nsec < 200) {
> +		pr_warn_ratelimited("%s: perout period too small, minimum is 200 nsec\n",
> +				    phydev_name(phydev));
> +		return -EOPNOTSUPP;
> +	}
> +
> +	if (on_nsec >= period_nsec) {
> +		pr_warn_ratelimited("%s: pulse width must be smaller than period\n",
> +				    phydev_name(phydev));
> +		return -EINVAL;
> +	}

-ENOUNLOCK brought to you by coccicheck:

drivers/net/phy/micrel.c:3049:2-8: preceding lock on line 3017
-- 
pw-bot: cr