Received-SPF: pass (google.com: domain of linux-kernel+bounces-131842-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1b1dfe1f-57ed-416d-a9c0-408aafa69583@intel.com>
Date: Thu, 4 Apr 2024 18:40:33 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v3 1/5] net: create a dummy net_device allocator
To: Breno Leitao <leitao@debian.org>
CC: <kuba@kernel.org>, <davem@davemloft.net>, <pabeni@redhat.com>,
	<edumazet@google.com>, <elder@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>,
	<nbd@nbd.name>, <sean.wang@mediatek.com>, <Mark-MC.Lee@mediatek.com>,
	<lorenzo@kernel.org>, <taras.chornyi@plvision.eu>,
	<quic_jjohnson@quicinc.com>, <kvalo@kernel.org>, <leon@kernel.org>,
	<dennis.dalessandro@cornelisnetworks.com>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>, <bpf@vger.kernel.org>, Jiri Pirko
	<jiri@resnulli.us>, Simon Horman <horms@kernel.org>, Daniel Borkmann
	<daniel@iogearbox.net>, Sebastian Andrzej Siewior <bigeasy@linutronix.de>
References: <20240404114854.2498663-1-leitao@debian.org>
 <20240404114854.2498663-2-leitao@debian.org>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240404114854.2498663-2-leitao@debian.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MW5UQkNqQ0M4SHlUSXlUUjAySWsxbFIxSFE3clB3dmxzemJqY0wyWjlFL1lp?=
 =?utf-8?B?KzZwNzRjRjJJcTBTa2d1N3RUMGlNMmZ2cTRzaW4vb0ZoMWVLQ3lHcW54UlVu?=
 =?utf-8?B?aHRWclFJV3d0NG9HNGx0V01JNC9RcFJUb0c2eWlQMlk0TE8wUk4xZFoxRkUz?=
 =?utf-8?B?S0FLOFlqN3VMWVcxOERwNEM5NUgwRGhkMmFYYlJyR05zY3NvQ1BKTmNZaTAw?=
 =?utf-8?B?d2c3R3orQm1mMnhBTnIwbEtrQXhON3d1SVdxNTFBaDBaRm1IdFdsKy9mZ2xj?=
 =?utf-8?B?RDZOQU51bWR1TnNob2pCdGJKYk1CMXFkeUEyYm1YbXNxN0FNZ3B1R05CWTZU?=
 =?utf-8?B?STFPb2pQNVY2UW5KYUlOTUordGRMS01NemRPUGJKL2hmNE8rT3FTclp5dWdo?=
 =?utf-8?B?VlJKaHpUR2xhV3lDMHYyN1BEUC9GbHBDdE1ONnlBcHY1SFRwYjVhZ3F3TzJT?=
 =?utf-8?B?Sk8rQWJzK0ZxUlF1bUYwc2p1ZW5nT0o5LzhaTmlyQ2hDUVVNQW5QaHBIc1dW?=
 =?utf-8?B?S29TYVRvdkViUDRqa2lqL2FoZy80dmw1WW9YNVR4dHNhbXhja2NQNGQwYlQ5?=
 =?utf-8?B?VFVUaWQwN21WUDBRcURhTm5YQ3pEbys3OHJpYkNvVUIyem91eFFhM1MwcW51?=
 =?utf-8?B?emxKZjU4aG5wazZDSU9xOUZySWt4ajVaSlVLdEM0ajJ5UFNiazQ4VUxnaGhW?=
 =?utf-8?B?V3BZZWd1ZHU3ekZ0bjVDUEpLdktOWG0vdEY0Zjk4TWZtWTNHenFDVW5jeG1R?=
 =?utf-8?B?cFZUdnFtUm5NYjQ5dFF2dCtuNG53a3VNMVd6ZXlxNmlFTFZFVDB3dExIZDE0?=
 =?utf-8?B?bTBqbS9LVWw3VGI2TktXcVZvNCtLMldVenMxNlhFWWR5OFQxWldFR3hFYXN3?=
 =?utf-8?B?aU9KenJ4WHE5NXNrWFRGTkZZZnY5TXV4am5KZEdDWkg4cC9yTURWTTJRaWln?=
 =?utf-8?B?NGZWb1k1cHRCOEFkbEFLNUlVclZCVHliVmloaVI4RlJJSlhPcDc4b2Z3bkZG?=
 =?utf-8?B?cmpFbHByWWNYN3ZsL05kQ3FRQkJSRWk2NHZ5VXJmOXdNU1owSGdGS1d5Q3JI?=
 =?utf-8?B?ZTdJNTJyMGVmUFcrR05SeWxmWXJrcVBDMGRNemJhMjJ6MXlqU2NlQzQ0SFdx?=
 =?utf-8?B?OVhTbEFxbmFNQ1hEZHNTaFM3QmFJRitSY1drak01UGVJdGR3OXJUYUdPcFBH?=
 =?utf-8?B?ckZ1SWdsUStTS21yQ2tRazN1cUZmVlIzZ2x2eFNheVE4Rll1eGhDdmdNMTkx?=
 =?utf-8?B?NFNzRmVacE5qazNudFF0V1d3NEhySkQxMGFGZERlNkJ3VThyMFJCb0c1NWhl?=
 =?utf-8?B?SnlYUkp1eVRJSmE4TWcvdWxHcUxnTmtMYURURml1SWxHWVBvbmZERjBITUpZ?=
 =?utf-8?B?YWlFK2NuL3YrT3k5NVYrQldZL0ZUTzVES2hBTlVPY0JMNUJxY3hsQk1IaDgx?=
 =?utf-8?B?bUFBQmswNlg0VnpCOEhmNFo2OXRhSTV0a29hWFRYaEY2NE9qQmFyTnYrQ1NM?=
 =?utf-8?B?NXpmVTdTdmRxREQrbCtpeEpHZ08yS3JwenR4MkZQWkRmTXdIL09SbnNMSXVr?=
 =?utf-8?B?UzlFZGcxVXNTdjJnTSs2SURmZFV2MFNCd3p6aUE4SURqamZCZkdWQXhoeFN4?=
 =?utf-8?B?SVBvWlJIckY1a1lDMnkyaEVxZkdOb3ArN2hmRGk5TXorRDFqTTkxSEZTdnpq?=
 =?utf-8?B?NWE0MmViZDRiM1pCa0pWUUVsZEdUekZDRnlqZDgzUlAybUpRWDRlcERBcmM3?=
 =?utf-8?B?RUR4R0cwWTlMK0xodGN4NEl1K2k1TkloZlFIVCtndklPUzVOZjBEU3owME9F?=
 =?utf-8?B?Qml6YW56SkJHK1dmN3JMSDdLRUpYakZBU1QvaFBNNU9LS1pJVCtOZ1MrTXdT?=
 =?utf-8?B?MURGSmpQc2ExRnVmZ01qWHN1ZkhLdk5jU3M3U01DdE9TUDEvK3gyZWc2ZHZJ?=
 =?utf-8?B?b2VLQ0pscFdjeUg3bEY2VFhEUWZtb2txeENpSmg2dDJjYi8yanRmeDFXVlB2?=
 =?utf-8?B?QVRQb1l4SXJrVmZ6ZFpkU21EMjlWSGdEQm10b1hKSGkxb05ZcStLZ2N3bHZs?=
 =?utf-8?B?UnRDdDdQOHZQK2kwLzduSDQ4MzhqNUQxdlZTSUZkNHd5b1Rjak4vMGt5b2M4?=
 =?utf-8?B?blZUVkEvSWJVWmxjZmhjc25RSVFNT3RrSjFHdzR0clRaVS9QRG0xTU52ckR6?=
 =?utf-8?Q?u2wKxr+PBVAvmpqYhPvPVIQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d88724a2-0f55-4c72-6150-08dc54c623f9
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 16:41:56.5652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P08Tif2r0+LjXr9CWrij060feAnyB1FAOvgSHBg+Eagqr3fcOMyqfol4OhvD5hL0euVrLphhfTjT3Ha7askxOC+QpWhtUhbyudLfgdpAQl0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7811
X-OriginatorOrg: intel.com

From: Breno Leitao <leitao@debian.org>
Date: Thu, 4 Apr 2024 04:48:41 -0700

> It is impossible to use init_dummy_netdev together with alloc_netdev()
> as the 'setup' argument.
> 
> This is because alloc_netdev() initializes some fields in the net_device
> structure, and later init_dummy_netdev() memzero them all. This causes
> some problems as reported here:
> 
> 	https://lore.kernel.org/all/20240322082336.49f110cc@kernel.org/
> 
> Split the init_dummy_netdev() function in two. Create a new function called
> init_dummy_netdev_core() that does not memzero the net_device structure.
> Then have init_dummy_netdev() memzero-ing and calling
> init_dummy_netdev_core(), keeping the old behaviour.
> 
> init_dummy_netdev_core() is the new function that could be called as an
> argument for alloc_netdev().
> 
> Also, create a helper to allocate and initialize dummy net devices,
> leveraging init_dummy_netdev_core() as the setup argument. This function
> basically simplify the allocation of dummy devices, by allocating and
> initializing it. Freeing the device continue to be done through
> free_netdev()

[...]

> @@ -11063,6 +11070,17 @@ void free_netdev(struct net_device *dev)
>  }
>  EXPORT_SYMBOL(free_netdev);
>  
> +/**
> + * alloc_netdev_dummy - Allocate and initialize a dummy net device.
> + * @sizeof_priv: size of private data to allocate space for
> + */
> +struct net_device *alloc_netdev_dummy(int sizeof_priv)

Repeating my question from the previous thread: I see that in your
series you always pass 0 as @sizeof_priv, does it make sense to have
this argument or we can just pass 0 here to alloc_netdev() unconditionally?
Drivers that have &net_device embedded can't have any private data there
anyway.

> +{
> +	return alloc_netdev(sizeof_priv, "dummy#", NET_NAME_UNKNOWN,
> +			    init_dummy_netdev_core);
> +}
> +EXPORT_SYMBOL_GPL(alloc_netdev_dummy);
> +
>  /**
>   *	synchronize_net -  Synchronize with packet receive processing
>   *

Thanks,
Olek