Received: by 2002:ab2:7a55:0:b0:1f4:4a7d:290d with SMTP id u21csp185731lqp; Thu, 4 Apr 2024 10:06:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVItj2Nfe1IwN832iUVKDYN9oV7NghfGGVPm+mgcAQmpMuWf8FobrcDbvgx53ym6jhk+Y+JD4xnR8r4IqX4UV2g0nmrRjzrk4tUWnjeqw== X-Google-Smtp-Source: AGHT+IGxUpOn62I03PcSTKFf24PUertpO3UVyk8D3Umsf/OqJltRVSWQXeFO17d1X+9gdcHJ87aZ X-Received: by 2002:a05:6a20:4387:b0:1a3:cb50:b52d with SMTP id i7-20020a056a20438700b001a3cb50b52dmr501687pzl.31.1712250393087; Thu, 04 Apr 2024 10:06:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712250393; cv=pass; d=google.com; s=arc-20160816; b=HL/4wUUJRvG1TeGRJLontCfxLpWBLEcl2MJKcHxrOGO4mEVmcfVuC7ZjcWMaMQsdxL 8dGlo2Hn3ST/8b3dsreTi4ZUMIhaduoplS8XcipAHeFbNPWCCm9JhirXF+aqLUVMSLRD io91R/T16qJDpSaHobdmQvMbuRkzHA/iFt/WFVpPmAmhVWGdjgVfvR1q9SMaTvKcG3+g gl9Egzn+7B+oeXtrzYyss9D0oTKNavHT3vzq1xFJbjqkV3hLKTqKlXD7p9t8Ro35y5kl cYz2btz1zf5+e6fwYLBYgtdZ+Mu4S7vMRzEQ1o7UaElQpD6/uNemN6XE7wwqjWJnZemc kO4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=S4+pPZmfnMRvuzCTlrw9RHK+nPpZuPKzM5pjyBfGGjY=; fh=ccsx+4NNKeYstGur/bh4nfOl5lHJIB7YFJnEtoMEbo4=; b=GHnxKpeDci9OEJP/RdGSfXHvVFmOGtaIFbKDZ5MmcWVE2CMyBjvto24slk0Ya825kY h9KEowGGOSnU9436J+DuqMuF9DzB1R6fkfWU/EGv0fnUoYTuQWALMCq8BstyKJmkPgu5 yzdGqUBE/7IuDDWfZmafgEug6DzPvXqHx+fY2TzYVv3OB5MYZ0YZJu6n+XhnTH0ZOUc/ 0SU9wOG2yAIGzoPKp5mObUJ7PzfUWR/4NyAAq5IE/YOv5LINpEtmZSUwoszOYUpQkz36 ENozZFHJ9KVQufUx89q0diyq+QP6oD8CX7MAfXOphjdOU+Md+0NUvlozgsF8Fw6DIGTr gDnA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=OO3lc94R; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linuxfoundation.org dmarc=pass fromdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-131871-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131871-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e7-20020a17090a684700b002a2007b9726si2076965pjm.32.2024.04.04.10.06.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 10:06:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-131871-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=OO3lc94R; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linuxfoundation.org dmarc=pass fromdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-131871-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-131871-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BCD9528752B for ; Thu, 4 Apr 2024 17:06:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 104C312CDAF; Thu, 4 Apr 2024 17:06:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OO3lc94R" Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3CA14A8B for ; Thu, 4 Apr 2024 17:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712250386; cv=none; b=iJfYIPCeSjSKp8CCHVQ3uZwvyFwXb8Hn+gxJPP9d5HuAGXSizsWQ0x7k8wBE6Gu3DH6xbLywD+A09bS45FeH+pYKFGWWGIIv9ALibL4oMtNMWKFXiD5Sm+9vLF/vkR7t2AYYEC2+aPPgUJHIgduekaMpv+HCa3VBD5DhnLbdoTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712250386; c=relaxed/simple; bh=OSPqJ91WFQCaW0PJb6559Z/+qaB8INvw9x8X/jLyFgI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qTQKXq7ZRWIgfIcG6MSIpg2i0zlfKMozMiQp/bmVrTrLvoLPCE24r6Y2+HlaIon1AcKXQLgM6H8/4XaEuXBB4YQoyGnudtyVtncCttquSGgsASEUVpN3yrul+sHaTllWdEICrZfqdC38Otl7KZLIiPS3i6yeeqapx6VVE8gJJ5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OO3lc94R; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7cc5e664d52so26058439f.0 for ; Thu, 04 Apr 2024 10:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1712250384; x=1712855184; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S4+pPZmfnMRvuzCTlrw9RHK+nPpZuPKzM5pjyBfGGjY=; b=OO3lc94R4WR6QoxKazbfb7vIGroC/uHZbbsOqlfRXYpFDB5xw7WMB7hcfHEHxN1yxg 3+1+aBjXfBobKZ6R/0FOvmh8Rnqgaasfabvl6o6sJ3B8V25/OOm1esH7sHB3aTPSrLKB xAJD1xCVezt5HNfz+f2P5KAJJ8tKW8K1Ui3ag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712250384; x=1712855184; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S4+pPZmfnMRvuzCTlrw9RHK+nPpZuPKzM5pjyBfGGjY=; b=sUMQQHlZCqBYQ6jjrDIKwzfblZrPIhlzKjLFQAmGbWUB7tyAkP0cbMXd/xmdmmotva czED4quYutFdx7PiIAXkqI+FCvTVSTKHvI63zCkU7RFn5GLJP4/xoBWvZFSsu+FQ9g2F JYIZ/n6soq5ZGvhUCTn7GZ4KcNzL943PW3XOyTI1ZXXvK/F2/yqp7rlyvLSOdLCL4AU7 WyzCqmmJBHq7Ru52Kxsbo3vYMZnKCxAWRDsw9HVGbnzrMLuyybemv/Zj0FulekE/I788 zW2KYTtuz2h1E7iKYMPE3I/ZeveiTBJ77UvNwAyYNZIaWfHUqwRCt4iOYjRnz7YyogIf /pvw== X-Forwarded-Encrypted: i=1; AJvYcCVmWoWXd5OXTrLA6YzR0Cl5fEFcMMoS+QIyII1IBZhYE6Ewvs9NGniw1ueCemOiDcen3Pufp9iokcj5rjneFUOiCD3BcRDw76uhPpFt X-Gm-Message-State: AOJu0YxuhuTwsWp40rp4mniUC8NuBxbfPGKf+QG4s83zsQiGnlNpiXMG 9OVYejRwJB+WulKIb2mHOzQsJpQIKlGyDE07hVWFeInAPTTD4e4pzZjpDuyo/Xc= X-Received: by 2002:a6b:fc1a:0:b0:7d3:4f72:afd with SMTP id r26-20020a6bfc1a000000b007d34f720afdmr3224480ioh.0.1712250383695; Thu, 04 Apr 2024 10:06:23 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id g18-20020a05663816d200b00474d6e60dc4sm4679108jat.117.2024.04.04.10.06.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 10:06:23 -0700 (PDT) Message-ID: <7b7447d8-cf99-4a0a-9510-f4d2d9791264@linuxfoundation.org> Date: Thu, 4 Apr 2024 11:06:22 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kselftest: Add missing signature to the comments To: Muhammad Usama Anjum , Shuah Khan Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240404155511.57502-1-usama.anjum@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240404155511.57502-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/4/24 09:55, Muhammad Usama Anjum wrote: > The comment on top of the file is used by many developers to glance over > all the available functions. Add the recently added ksft_perror() to it. > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/kselftest.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h > index 7d650a06ca359..159bf8e314fa3 100644 > --- a/tools/testing/selftests/kselftest.h > +++ b/tools/testing/selftests/kselftest.h > @@ -16,6 +16,7 @@ > * For each test, report any progress, debugging, etc with: > * > * ksft_print_msg(fmt, ...); > + * ksft_perror(msg); > * > * and finally report the pass/fail/skip/xfail state of the test with one of: > * Thank you. Applied to linux-kselftest next for Linux 6.10-rc1 thanks, -- Shuah