Received-SPF: pass (google.com: domain of linux-kernel+bounces-131884-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 4 Apr 2024 18:21:50 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Lokesh Gidra <lokeshgidra@google.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, surenb@google.com,
	kernel-team@android.com, aarcange@redhat.com, peterx@redhat.com,
	david@redhat.com, zhengqi.arch@bytedance.com,
	kaleshsingh@google.com, ngeoffray@google.com
Subject: Re: [PATCH] userfaultfd: change src_folio after ensuring it's
 unpinned in UFFDIO_MOVE
Message-ID: <Zg7hrt5HudXLBUn_@casper.infradead.org>
References: <20240404171726.2302435-1-lokeshgidra@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240404171726.2302435-1-lokeshgidra@google.com>

On Thu, Apr 04, 2024 at 10:17:26AM -0700, Lokesh Gidra wrote:
> -		folio_move_anon_rmap(src_folio, dst_vma);
> -		WRITE_ONCE(src_folio->index, linear_page_index(dst_vma, dst_addr));
> -
>  		src_pmdval = pmdp_huge_clear_flush(src_vma, src_addr, src_pmd);
>  		/* Folio got pinned from under us. Put it back and fail the move. */
>  		if (folio_maybe_dma_pinned(src_folio)) {
> @@ -2270,6 +2267,9 @@ int move_pages_huge_pmd(struct mm_struct *mm, pmd_t *dst_pmd, pmd_t *src_pmd, pm
>  			goto unlock_ptls;
>  		}
>  
> +		folio_move_anon_rmap(src_folio, dst_vma);
> +		WRITE_ONCE(src_folio->index, linear_page_index(dst_vma, dst_addr));
> +

This use of WRITE_ONCE scares me.  We hold the folio locked.  Why do
we need to use WRITE_ONCE?  Who's looking at folio->index without
holding the folio lock?